-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add package-2018-12-preview #4868
Conversation
If you're a MSFT employee, click this link |
Automation for azure-sdk-for-pythonThe initial PR has been merged into your service PR: |
Automation for azure-sdk-for-jsThe initial PR has been merged into your service PR: |
Automation for azure-sdk-for-rubyNothing to generate for azure-sdk-for-ruby |
Automation for azure-sdk-for-goEncountered a Subprocess error: (azure-sdk-for-go)
Command: ['/usr/local/bin/autorest', '/tmp/tmpsc86_whn/rest/specification/iothub/resource-manager/readme.md', '--go', '--go-sdk-folder=/tmp/tmpsc86_whn/src/github.com/Azure/azure-sdk-for-go', '--multiapi', '--preview-chk', '--use=@microsoft.azure/autorest.go@~2.1.127', '--use-onever', '--verbose'] AutoRest code generation utility [version: 2.0.4283; node: v8.12.0]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest
Loading AutoRest core '/root/.autorest/@microsoft.azure_autorest-core@2.0.4289/node_modules/@microsoft.azure/autorest-core/dist' (2.0.4289)
Including configuration file 'file:///tmp/tmpsc86_whn/rest/specification/iothub/resource-manager/readme.go.md'
Loading AutoRest extension '@microsoft.azure/autorest.go' (~2.1.127->2.1.127)
Loading AutoRest extension '@microsoft.azure/autorest.modeler' (2.3.38->2.3.38)
Processing batch task - {"tag":"package-2018-12-preview"} .
Including configuration file 'file:///tmp/tmpsc86_whn/rest/specification/iothub/resource-manager/readme.go.md'
FATAL: System.InvalidOperationException: codegen for preview swagger Microsoft.Devices/preview/2018-12-01-preview/iothub.json must be under a preview subdirectory
at AutoRest.Go.CodeGeneratorGo.<Generate>d__6.MoveNext() in /home/vsts/work/1/s/src/CodeGeneratorGo.cs:line 51
--- End of stack trace from previous location where exception was thrown ---
at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
at AutoRest.Go.Program.<ProcessInternal>d__3.MoveNext() in /home/vsts/work/1/s/src/Program.cs:line 107
--- End of stack trace from previous location where exception was thrown ---
at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
at System.Runtime.CompilerServices.TaskAwaiter`1.GetResult()
at NewPlugin.<Process>d__20.MoveNext() in /home/vsts/work/1/s/autorest.common/src/Plugins/NewPlugin.cs:line 163
FATAL: go/generate - FAILED
FATAL: Error: Plugin go reported failure.
Process() cancelled due to exception : Plugin go reported failure.
Failure during batch task - {"tag":"package-2018-12-preview"} -- Error: Plugin go reported failure..
Error: Plugin go reported failure. |
Automation for azure-sdk-for-nodeNothing to generate for azure-sdk-for-node |
Automation for azure-sdk-for-javaNothing to generate for azure-sdk-for-java |
Can one of the admins verify this patch? |
``` yaml $(tag) == 'package-2018-12' && $(java) && $(multiapi) | ||
java: | ||
namespace: com.microsoft.azure.management.iothub.v2018_12_01 | ||
output-folder: $(azure-libraries-for-java-folder)/iothub/resource-manager/v2018_12_01 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
must have preview as suffix like this: https://github.com/Azure/azure-rest-api-specs/tree/master/specification/consumption/resource-manager#tag-package-2017-04-preview-and-java
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same for namespace. I would recommend having -preview on the tag as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
* Add package-2018-12 to Go SDK build * fixed PR failure * Adding 2018-12-01-preview package to GO * removing preview from Go * fixed PR comment
Latest improvements:
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
ARM API Review Checklist
Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.
Please follow the link to find more details on API review process.