-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating managed database swagger #4907
Conversation
If you're a MSFT employee, click this link |
Automation for azure-sdk-for-rubyThe initial PR has been merged into your service PR: |
Automation for azure-sdk-for-pythonThe initial PR has been merged into your service PR: |
Automation for azure-sdk-for-jsThe initial PR has been merged into your service PR: |
Automation for azure-sdk-for-goThe initial PR has been merged into your service PR: |
Automation for azure-sdk-for-javaThe initial PR has been merged into your service PR: |
Automation for azure-sdk-for-nodeNothing to generate for azure-sdk-for-node |
@v-djnisi this feature is already live? |
Yes, there was a PR for restorable dropped databases on MI couple of months ago. However since this only affects .Net clients, and since they weren't a priority nobody from team noticed this disparity. My guess is that we forgot to add ManagedDatabases swagger to the RestorableDropped PR. Hope this isn't a problem. |
If you're a MSFT employee, click this link |
Can one of the admins verify this patch? |
Clicked Close by mistake, sorry. |
No worries just want to make sure the functionality is available before merging. |
Latest improvements:
I am currently working on restorable dropped databases for Managed Instance. I noticed that swagger on azure-rest-api-specs is outdated compared to the swagger we have on our enlistment.
This swagger contains restorableDroppedDatabaseId as property, which is necessary for my PowerShell feature.
Contribution checklist:
ARM API Review Checklist
Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.
Please follow the link to find more details on API review process.