Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating managed database swagger #4907

Merged
merged 1 commit into from
Dec 13, 2018

Conversation

v-djnisi
Copy link
Contributor

@v-djnisi v-djnisi commented Dec 13, 2018

Latest improvements:

I am currently working on restorable dropped databases for Managed Instance. I noticed that swagger on azure-rest-api-specs is outdated compared to the swagger we have on our enlistment.

This swagger contains restorableDroppedDatabaseId as property, which is necessary for my PowerShell feature.


Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@openapi-portal-comment
Copy link

If you're a MSFT employee, click this link
to view this PR's validation status on our new OpenAPI Hub spec management tool.

@AutorestCI
Copy link

AutorestCI commented Dec 13, 2018

Automation for azure-sdk-for-ruby

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-ruby#1871

@AutorestCI
Copy link

AutorestCI commented Dec 13, 2018

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#3769

@AutorestCI
Copy link

AutorestCI commented Dec 13, 2018

Automation for azure-sdk-for-js

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-js#570

@AutorestCI
Copy link

AutorestCI commented Dec 13, 2018

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#3703

@AutorestCI
Copy link

AutorestCI commented Dec 13, 2018

Automation for azure-sdk-for-java

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-java#2138

@AutorestCI
Copy link

AutorestCI commented Dec 13, 2018

Automation for azure-sdk-for-node

Nothing to generate for azure-sdk-for-node

@jhendrixMSFT
Copy link
Member

@v-djnisi this feature is already live?

@v-djnisi
Copy link
Contributor Author

Yes, there was a PR for restorable dropped databases on MI couple of months ago. However since this only affects .Net clients, and since they weren't a priority nobody from team noticed this disparity. My guess is that we forgot to add ManagedDatabases swagger to the RestorableDropped PR. Hope this isn't a problem.

@v-djnisi v-djnisi closed this Dec 13, 2018
@kpajdzik kpajdzik removed the review label Dec 13, 2018
@v-djnisi v-djnisi reopened this Dec 13, 2018
@openapi-portal-comment
Copy link

If you're a MSFT employee, click this link
to view this PR's validation status on our new OpenAPI Hub spec management tool.

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@v-djnisi
Copy link
Contributor Author

Clicked Close by mistake, sorry.

@jhendrixMSFT
Copy link
Member

No worries just want to make sure the functionality is available before merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants