Managed Instance GeoRestore Cmds #4947

lixiachena · 2018-12-19T09:24:56Z

New Cmdlets for Management.Sql to allow customers to get recoverable managed databases and create database by recovery

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.
The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

New Cmdlets for Management.Sql to allow customers to get recoverable managed databases and create database by recovery

openapi-portal-comment · 2018-12-19T09:24:57Z

If you're a MSFT employee, click this link
to view this PR's validation status on our new OpenAPI Hub spec management tool.

AutorestCI · 2018-12-19T09:26:42Z

Automation for azure-sdk-for-ruby

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-ruby#2143

AutorestCI · 2018-12-19T09:26:48Z

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#3769

azuresdkci · 2018-12-19T09:27:48Z

Can one of the admins verify this patch?

AutorestCI · 2018-12-19T09:27:51Z

Automation for azure-sdk-for-js

A PR has been created for you:
Azure/azure-sdk-for-js#964

AutorestCI · 2018-12-19T09:28:56Z

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#3919

AutorestCI · 2018-12-19T09:33:27Z

Automation for azure-sdk-for-java

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-java#2138

AutorestCI · 2018-12-19T09:44:08Z

Automation for azure-sdk-for-node

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-node#4181

hovsepm · 2018-12-20T23:17:28Z

@lixiachena please add your spec to readme.md file as well.

lixiachena · 2019-01-03T20:13:00Z

This feature is not available in public, I will add spec to readme.md once the feature is available in public.

hovsepm · 2019-01-03T23:36:17Z

@lixiachena please fix model validation errors:

error : 
operationId: RecoverableManagedDatabases_ListByInstance
scenario: List recoverable databases by managed instances
source: response
responseCode: '200'
severity: 0
errorCode: OBJECT_ADDITIONAL_PROPERTIES
errorDetails:
  code: OBJECT_ADDITIONAL_PROPERTIES
  params:
    - - location
  message: 'Additional properties not allowed: location'
  path: value/0
  title: /definitions/RecoverableManagedDatabase
  description: A recoverable managed database resource.
  similarPaths:
    - value/1
  position:
    line: 170
    column: 35
  url: >-
    specification/sql/resource-manager/Microsoft.Sql/preview/2017-10-01-preview/recoverableManagedDatabases.json
  directives: {}
  jsonPosition:
    line: 12
    column: 19
  jsonUrl: >-
    specification/sql/resource-manager/Microsoft.Sql/preview/2017-10-01-preview/examples/ListRecoverableManagedDatabasesByServer.json
 error : 
operationId: RecoverableManagedDatabases_Get
scenario: Gets a recoverable databases by managed instances
source: request
responseCode: ALL
severity: 0
errorCode: REQUIRED_PARAMETER_EXAMPLE_NOT_FOUND
errorDetails:
  code: REQUIRED_PARAMETER_EXAMPLE_NOT_FOUND
  id: OAV105
  message: >-
    In operation "RecoverableManagedDatabases_Get", parameter
    recoverableDatabaseName is required in the swagger spec but is not present
    in the provided example parameter values.
 error : 
operationId: RecoverableManagedDatabases_Get
scenario: Gets a recoverable databases by managed instances
source: response
responseCode: '200'
severity: 0
errorCode: OBJECT_ADDITIONAL_PROPERTIES
errorDetails:
  code: OBJECT_ADDITIONAL_PROPERTIES
  params:
    - - location
  message: 'Additional properties not allowed: location'
  path: ''
  title: /definitions/RecoverableManagedDatabase
  description: A recoverable managed database resource.
  position:
    line: 170
    column: 35
  url: >-
    specification/sql/resource-manager/Microsoft.Sql/preview/2017-10-01-preview/recoverableManagedDatabases.json
  directives: {}
  jsonUrl: >-
    specification/sql/resource-manager/Microsoft.Sql/preview/2017-10-01-preview/examples/GetRecoverableManagedDatabase.json

Modify example files and readme.md for get recoverable managed databases

ravbhatnagar

nothing major, couple of minor notes.

ravbhatnagar · 2019-01-09T22:52:05Z

...l/resource-manager/Microsoft.Sql/preview/2017-10-01-preview/recoverableManagedDatabases.json

+      "description": "The recoverable managed database's properties.",
+      "type": "object",
+      "properties": {
+        "lastAvailableBackupDate": {


This should be ISO 8601 compliant and so the format should be date-time

This is actually a string format. This value will be used later by customer for restore

Lixia, what should this property's data type be in generated C# code? string, or datetime?

ravbhatnagar · 2019-01-09T22:53:32Z

...l/resource-manager/Microsoft.Sql/preview/2017-10-01-preview/recoverableManagedDatabases.json

+  "produces": [
+    "application/json"
+  ],
+  "paths": {


Is it possible to delete a recoverableDatabase through an API? Or is this a valid scenario? I am assuming that databases are automatically categorized as recoverable or not by the service.

Recoverabledatabase is a read only. Customer can't drop it

@ravbhatnagar their lifetime is managed by the service, so no create or delete API is possible or needed.

ravbhatnagar · 2019-01-10T21:06:26Z

@lixiachena - please take a look at the comments. thanks!

lixiachena · 2019-01-11T22:29:48Z

@lixiachena please add your spec to readme.md file as well.
Added. Thanks

openapi-portal-comment · 2019-01-14T21:41:09Z

If you're a MSFT employee, click this link
to view this PR's validation status on our new OpenAPI Hub spec management tool.

hovsepm · 2019-01-14T21:47:59Z

@ravbhatnagar per PR author your feedback is addressed. Could you verify?

KrisBash

Signing off for ARM

sarangan12 · 2019-01-17T23:19:13Z

Left feedback to fix the model validator error (through IM), Waiting for response

Fix one typo

Update recoverableManagedDatabaseName to recoverableDatabaseName

Swagger PR Links Azure/azure-rest-api-specs#4947 Add SDK for database recovery on Managed Instance •Add getrecoverabledatabases on managed instance and create databases using geo-backup •Add test •Generate client from azure and update session records •Add release notes

* Managed Instance GeoRestore Cmds New Cmdlets for Management.Sql to allow customers to get recoverable managed databases and create database by recovery * Modify example files and readme.md Modify example files and readme.md for get recoverable managed databases * Update GetRecoverableManagedDatabase.json Fix one typo * Update recoverableManagedDatabaseName to recoverableDatabaseName Update recoverableManagedDatabaseName to recoverableDatabaseName

Swagger PR Links Azure/azure-rest-api-specs#4947 Add SDK for database recovery on Managed Instance •Add getrecoverabledatabases on managed instance and create databases using geo-backup •Add test •Generate client from azure and update session records •Add release notes

Managed Instance GeoRestore Cmds

24079f9

New Cmdlets for Management.Sql to allow customers to get recoverable managed databases and create database by recovery

kpajdzik added the review label Dec 19, 2018

azuresdkci assigned hovsepm Dec 19, 2018

azuresdkci requested a review from hovsepm December 19, 2018 09:25

AutorestCI mentioned this pull request Dec 19, 2018

[AutoPR sql/resource-manager] Managed Instance GeoRestore Cmds Azure/azure-sdk-for-ruby#2104

Closed

jaredmoo approved these changes Jan 3, 2019

View reviewed changes

hovsepm added WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required DoNotMerge <valid label in PR review process> use to hold merge after approval labels Jan 3, 2019

Modify example files and readme.md

6bb8cd6

Modify example files and readme.md for get recoverable managed databases

ravbhatnagar reviewed Jan 9, 2019

View reviewed changes

ravbhatnagar added the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Jan 9, 2019

hovsepm removed their assignment Jan 10, 2019

hovsepm added the Reassign label Jan 10, 2019

azuresdkci removed the Reassign label Jan 10, 2019

azuresdkci assigned sarangan12 Jan 10, 2019

azuresdkci requested a review from sarangan12 January 10, 2019 02:04

lixiachena closed this Jan 11, 2019

hovsepm removed their request for review January 14, 2019 21:37

lixiachena reopened this Jan 14, 2019

AutorestCI mentioned this pull request Jan 14, 2019

[AutoPR sql/resource-manager] Managed Instance GeoRestore Cmds Azure/azure-sdk-for-go#3868

Merged

KrisBash approved these changes Jan 17, 2019

View reviewed changes

lixiachena added 2 commits January 17, 2019 16:20

Update GetRecoverableManagedDatabase.json

874878e

Fix one typo

Update recoverableManagedDatabaseName to recoverableDatabaseName

056912d

Update recoverableManagedDatabaseName to recoverableDatabaseName

sarangan12 approved these changes Jan 22, 2019

View reviewed changes

sarangan12 merged commit 9899774 into Azure:master Jan 22, 2019

AutorestCI mentioned this pull request Jan 22, 2019

[AutoPR sql/resource-manager] Managed Instance GeoRestore Cmds Azure/azure-sdk-for-js#964

Closed

lixiachena mentioned this pull request Jan 29, 2019

Add SDK for database recovery on Managed Instance Azure/azure-sdk-for-net#5186

Merged

9 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Managed Instance GeoRestore Cmds #4947

Managed Instance GeoRestore Cmds #4947

lixiachena commented Dec 19, 2018

openapi-portal-comment bot commented Dec 19, 2018

AutorestCI commented Dec 19, 2018 •

edited

Loading

AutorestCI commented Dec 19, 2018 •

edited

Loading

azuresdkci commented Dec 19, 2018

AutorestCI commented Dec 19, 2018 •

edited

Loading

AutorestCI commented Dec 19, 2018 •

edited

Loading

AutorestCI commented Dec 19, 2018 •

edited

Loading

AutorestCI commented Dec 19, 2018 •

edited

Loading

hovsepm commented Dec 20, 2018

lixiachena commented Jan 3, 2019

hovsepm commented Jan 3, 2019

ravbhatnagar left a comment

ravbhatnagar Jan 9, 2019

lixiachena Jan 11, 2019 •

edited

Loading

jaredmoo Jan 14, 2019

ravbhatnagar Jan 9, 2019

lixiachena Jan 11, 2019 •

edited

Loading

jaredmoo Jan 14, 2019

ravbhatnagar commented Jan 10, 2019

lixiachena commented Jan 11, 2019

openapi-portal-comment bot commented Jan 14, 2019

hovsepm commented Jan 14, 2019

KrisBash left a comment

sarangan12 commented Jan 17, 2019

Managed Instance GeoRestore Cmds #4947

Managed Instance GeoRestore Cmds #4947

Conversation

lixiachena commented Dec 19, 2018

Latest improvements:

Contribution checklist:

ARM API Review Checklist

openapi-portal-comment bot commented Dec 19, 2018

AutorestCI commented Dec 19, 2018 • edited Loading

Automation for azure-sdk-for-ruby

AutorestCI commented Dec 19, 2018 • edited Loading

Automation for azure-sdk-for-python

azuresdkci commented Dec 19, 2018

AutorestCI commented Dec 19, 2018 • edited Loading

Automation for azure-sdk-for-js

AutorestCI commented Dec 19, 2018 • edited Loading

Automation for azure-sdk-for-go

AutorestCI commented Dec 19, 2018 • edited Loading

Automation for azure-sdk-for-java

AutorestCI commented Dec 19, 2018 • edited Loading

Automation for azure-sdk-for-node

hovsepm commented Dec 20, 2018

lixiachena commented Jan 3, 2019

hovsepm commented Jan 3, 2019

ravbhatnagar left a comment

Choose a reason for hiding this comment

ravbhatnagar Jan 9, 2019

Choose a reason for hiding this comment

lixiachena Jan 11, 2019 • edited Loading

Choose a reason for hiding this comment

jaredmoo Jan 14, 2019

Choose a reason for hiding this comment

ravbhatnagar Jan 9, 2019

Choose a reason for hiding this comment

lixiachena Jan 11, 2019 • edited Loading

Choose a reason for hiding this comment

jaredmoo Jan 14, 2019

Choose a reason for hiding this comment

ravbhatnagar commented Jan 10, 2019

lixiachena commented Jan 11, 2019

openapi-portal-comment bot commented Jan 14, 2019

hovsepm commented Jan 14, 2019

KrisBash left a comment

Choose a reason for hiding this comment

sarangan12 commented Jan 17, 2019

AutorestCI commented Dec 19, 2018 •

edited

Loading

AutorestCI commented Dec 19, 2018 •

edited

Loading

AutorestCI commented Dec 19, 2018 •

edited

Loading

AutorestCI commented Dec 19, 2018 •

edited

Loading

AutorestCI commented Dec 19, 2018 •

edited

Loading

AutorestCI commented Dec 19, 2018 •

edited

Loading

lixiachena Jan 11, 2019 •

edited

Loading

lixiachena Jan 11, 2019 •

edited

Loading