Add version 2018-11-27-preview to Microsoft.Insights #4987

aydany · 2019-01-04T15:02:55Z

If you are a MSFT employee you can view your work branch via this link.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.

…6-01-preview to version 2018-11-27-preview

Removed some of the autogenerated files and added the swagger file and examples for the new api.

Made it the same as the rest of the specs

openapi-portal-comment · 2019-01-04T15:02:57Z

If you're a MSFT employee, click this link
to view this PR's validation status on our new OpenAPI Hub spec management tool.

AutorestCI · 2019-01-04T15:03:14Z

Automation for azure-sdk-for-js

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-js#672

AutorestCI · 2019-01-04T15:03:30Z

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#2761

AutorestCI · 2019-01-04T15:03:41Z

Automation for azure-sdk-for-java

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-java#2139

AutorestCI · 2019-01-04T15:03:58Z

Automation for azure-sdk-for-node

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-node#4284

AutorestCI · 2019-01-04T15:04:05Z

Automation for azure-sdk-for-ruby

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-ruby#2146

AutorestCI · 2019-01-04T15:05:54Z

Automation for azure-sdk-for-go

Nothing to generate for azure-sdk-for-go

aydany · 2019-01-04T15:20:26Z

This changeset introduces a new extension resource in Microsoft.Insights. This resource is modelled as a singleton collection that provides information about the onboarding status of a resource/resource scope to VM Insights, a component of Azure Monitor.

The new resource has been reviewed with the ARM review board.

This API is not yet enabled in ARM. We were asked to submit this PR and have it approved, before making the manifest changes.

azuresdkci · 2019-01-04T15:24:08Z

Can one of the admins verify this patch?

specification/monitor/resource-manager/readme.md

The latest package including support for the new API will be generated. This required several changes: - The defintion of Resource used by the other specs was incompatible. This was because the other resources were tracked and the new ones is proxy. Defined a new ProxyResource type. - The ErrorResponse definition was incompatible with the rest of the specs in the folder. This is actually a bug in the exesiting specs. They do not respect the contract of { "error": {"code": "", "message": ""}}, i.e., they lack the top-level error element. To work around this issue, defined a new response type, ResponseWithError, which is compliant with the latest ARM requirements.

ravbhatnagar · 2019-01-07T23:12:15Z

This was reviewed in person by Vlad and @KrisBash. Kris - please feel free to sign off if it looks good.

sarangan12 · 2019-01-07T23:46:22Z

Notified @lmazuel @anuchandy @daschult regarding the SDK generation failure and waiting for their update.

lmazuel · 2019-01-08T02:02:12Z

@AutorestCI rebuild

lmazuel · 2019-01-08T18:58:40Z

@sarangan12 @aydany I added a commit to the PR to workaround a bug in our CI, because the last commit message contained a "{" character.

aydany · 2019-01-08T19:51:28Z

@lmazuel Thank you!

aydany · 2019-01-09T05:50:21Z

@sarangan12 What else do we need to resolve to complete this PR? Thanks!

KrisBash · 2019-01-10T23:24:03Z

...resource-manager/Microsoft.Insights/preview/2018-11-27-preview/vmInsightsOnboarding_API.json

+                },
+                "description": "The onboarding status for the resource. Note that, a higher level scope, e.g., resource group or subscription, is considered onboarded if at least one resource under it is onboarded."
+              },
+              "dataStatus": {


So, dataStatus is an aggregate in the case of multiple destinations? I.e. if the VM were onboarded to multiple destinations, and only sending to one, it would still be present? Is this enough fidelity or should the status be a property of the destination?

KrisBash

Signing off with comment

* Adds base for updating Microsoft.Insights from version preview/2018-06-01-preview to version 2018-11-27-preview * Updates readme * Updates API version in new specs and examples * Add initial swagger Removed some of the autogenerated files and added the swagger file and examples for the new api. * Remove extra / from examples * Fix swagger file * Improve docs * Update resource model Made it the same as the rest of the specs * Fix the resource data model: no location and tags * Fix readme * Generate the latest package The latest package including support for the new API will be generated. This required several changes: - The defintion of Resource used by the other specs was incompatible. This was because the other resources were tracked and the new ones is proxy. Defined a new ProxyResource type. - The ErrorResponse definition was incompatible with the rest of the specs in the folder. This is actually a bug in the exesiting specs. They do not respect the contract of { "error": {"code": "", "message": ""}}, i.e., they lack the top-level error element. To work around this issue, defined a new response type, ResponseWithError, which is compliant with the latest ARM requirements. * Update Python version

aydany and others added 9 commits January 3, 2019 14:55

Adds base for updating Microsoft.Insights from version preview/2018-0…

0ca4e58

…6-01-preview to version 2018-11-27-preview

Updates readme

09ce935

Updates API version in new specs and examples

789dd40

Add initial swagger

839519f

Removed some of the autogenerated files and added the swagger file and examples for the new api.

Remove extra / from examples

0f57a91

Fix swagger file

699c449

Improve docs

a9a9b32

Update resource model

444d940

Made it the same as the rest of the specs

Fix the resource data model: no location and tags

6b4c716

kpajdzik added the review label Jan 4, 2019

azuresdkci assigned sarangan12 Jan 4, 2019

azuresdkci requested a review from sarangan12 January 4, 2019 15:03

AutorestCI mentioned this pull request Jan 4, 2019

[AutoPR monitor/resource-manager] [Hub Generated] Review request for Microsoft.Insights to add version 2018-11-27-preview Azure/azure-sdk-for-ruby#2121

Merged

AutorestCI mentioned this pull request Jan 4, 2019

[AutoPR monitor/resource-manager] [Hub Generated] Review request for Microsoft.Insights to add version 2018-11-27-preview Azure/azure-sdk-for-go#3800

Closed

Fix readme

0be37eb

aydany changed the title ~~[Hub Generated] Review request for Microsoft.Insights to add version 2018-11-27-preview~~ Add version 2018-11-27-preview to Microsoft.Insights Jan 4, 2019

sarangan12 requested changes Jan 4, 2019

View reviewed changes

specification/monitor/resource-manager/readme.md Outdated Show resolved Hide resolved

ravbhatnagar added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jan 7, 2019

Update Python version

9771d96

Azure deleted a comment from AutorestCI Jan 8, 2019

AutorestCI mentioned this pull request Jan 8, 2019

[AutoPR monitor/resource-manager] Add version 2018-11-27-preview to Microsoft.Insights Azure/azure-sdk-for-python#4139

Merged

AutorestCI mentioned this pull request Jan 8, 2019

[AutoPR monitor/resource-manager] Add version 2018-11-27-preview to Microsoft.Insights Azure/azure-sdk-for-java#2826

Merged

KrisBash reviewed Jan 10, 2019

View reviewed changes

KrisBash approved these changes Jan 10, 2019

View reviewed changes

KrisBash added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Jan 10, 2019

sarangan12 approved these changes Jan 14, 2019

View reviewed changes

sarangan12 merged commit b980271 into Azure:master Jan 14, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add version 2018-11-27-preview to Microsoft.Insights #4987

Add version 2018-11-27-preview to Microsoft.Insights #4987

aydany commented Jan 4, 2019 •

edited

Loading

openapi-portal-comment bot commented Jan 4, 2019

AutorestCI commented Jan 4, 2019 •

edited

Loading

AutorestCI commented Jan 4, 2019 •

edited

Loading

AutorestCI commented Jan 4, 2019 •

edited

Loading

AutorestCI commented Jan 4, 2019 •

edited

Loading

AutorestCI commented Jan 4, 2019 •

edited

Loading

AutorestCI commented Jan 4, 2019 •

edited

Loading

aydany commented Jan 4, 2019

azuresdkci commented Jan 4, 2019

ravbhatnagar commented Jan 7, 2019

sarangan12 commented Jan 7, 2019

lmazuel commented Jan 8, 2019

lmazuel commented Jan 8, 2019

aydany commented Jan 8, 2019

aydany commented Jan 9, 2019

KrisBash Jan 10, 2019

KrisBash left a comment

Add version 2018-11-27-preview to Microsoft.Insights #4987

Add version 2018-11-27-preview to Microsoft.Insights #4987

Conversation

aydany commented Jan 4, 2019 • edited Loading

Contribution checklist:

openapi-portal-comment bot commented Jan 4, 2019

AutorestCI commented Jan 4, 2019 • edited Loading

Automation for azure-sdk-for-js

AutorestCI commented Jan 4, 2019 • edited Loading

Automation for azure-sdk-for-python

AutorestCI commented Jan 4, 2019 • edited Loading

Automation for azure-sdk-for-java

AutorestCI commented Jan 4, 2019 • edited Loading

Automation for azure-sdk-for-node

AutorestCI commented Jan 4, 2019 • edited Loading

Automation for azure-sdk-for-ruby

AutorestCI commented Jan 4, 2019 • edited Loading

Automation for azure-sdk-for-go

aydany commented Jan 4, 2019

azuresdkci commented Jan 4, 2019

ravbhatnagar commented Jan 7, 2019

sarangan12 commented Jan 7, 2019

lmazuel commented Jan 8, 2019

lmazuel commented Jan 8, 2019

aydany commented Jan 8, 2019

aydany commented Jan 9, 2019

KrisBash Jan 10, 2019

Choose a reason for hiding this comment

KrisBash left a comment

Choose a reason for hiding this comment

aydany commented Jan 4, 2019 •

edited

Loading

AutorestCI commented Jan 4, 2019 •

edited

Loading

AutorestCI commented Jan 4, 2019 •

edited

Loading

AutorestCI commented Jan 4, 2019 •

edited

Loading

AutorestCI commented Jan 4, 2019 •

edited

Loading

AutorestCI commented Jan 4, 2019 •

edited

Loading

AutorestCI commented Jan 4, 2019 •

edited

Loading