Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding data connectors APIs #5125

Merged
merged 29 commits into from
Feb 5, 2019
Merged

Adding data connectors APIs #5125

merged 29 commits into from
Feb 5, 2019

Conversation

nirgfani
Copy link
Contributor

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

nirgfani and others added 25 commits December 31, 2018 15:00
@nirgfani
Creating first and basic swagger for new RP of ASI (Azure Security In…
9af9e38 
…sight).

This RP is an extension RP of "Microsoft.operationalinsights", and it is coupled to a Log analytics workspace.

This is a first iteration in order to create a simple RP with single endpoint, after it wil work the API will be changed with the actual and full endpoints based on the learnings from this POC.
@nirgfani
updating the operationalInsightsResourceProvider to be a global param…
de2a4c9 
…eter and reuse it in the PUT same as in the GET
@nirgfani
Fixing comments from PR
8e0cd13
@nirgfani
Fixing the Microsoft.OperationalInsight to the right form
7d0a4c7
@nirgfani
Updating the location to be under- "resource-manager"
fd243ea
@nirgfani
adding readme files for the swagger
f16db7f
@nirgfani
Changing the path of the files to the correct path
1703e6f
@nirgfani
Change the location of the readme files
36aca1e
@nirgfani
Fixing inconsistency in the naming- changing everything to SecurityIn…
5326e67 
…sights
@nirgfani
Missed the file when aligned the name to SecurityInsights
a9475d1
@nirgfani
Fixing a redundant space in the examples
93b148d
@nirgfani
add alertRule to the CreateAlertRule.json and do some indentation fixes
73565ce
@nirgfani
Merge pull request #1 from Azure/master
5ed047d 
Merging from Azure Repo
@nirgfani
Creates the "real" API for Scheduled Alert Rules
8808c18
@nirgfani
Merge branch 'master' of https://github.com/nirgfani/azure-rest-api-s…
b63cbf7 
…pecs
@nirgfani
Update the name alertRule to alertScheduledtRule in the creation example
12beca7
@nirgfani
Fixing comments from PR-
1d1029b 
* Changing durations to fit standards
* Changing operators to fit other RPs
* Align naming to scheduledAlertRules
* Adding 200 response to DeleteScheduledAlertRule
@nirgfani
Changing naming-
863597a 
alertTriggerOperator => triggerOperator
alertTriggerThreshold => triggerThreshold
@nirgfani
Adding kind to AlertRule and making Scheduled as a specific kind
573869d
@nirgfani
Fix some errors
27d8376
@nirgfani
Trying to solve the model validator issues
0f74576
@nirgfani
Fixing indentation
831ec10
@nirgfani
Adding data connectors endpoints
37aea3e
@nirgfani
Merge pull request #2 from Azure/master
26f94da 
Merge back
@nirgfani
Merge branch 'master' into Backup
32dd110
@AutorestCI
Copy link

AutorestCI commented Jan 31, 2019 •
edited
Loading

Automation for azure-sdk-for-js

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-js#1035

@AutorestCI
Copy link

AutorestCI commented Jan 31, 2019 •
edited
Loading

Automation for azure-sdk-for-go

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-go#4040

@AutorestCI
Copy link

AutorestCI commented Jan 31, 2019 •
edited
Loading

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

@AutorestCI
Copy link

AutorestCI commented Jan 31, 2019 •
edited
Loading

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#4268

@azuresdkci azuresdkci requested a review from jianghaolu January 31, 2019 12:44
@AutorestCI
Copy link

AutorestCI commented Jan 31, 2019 •
edited
Loading

Automation for azure-sdk-for-java

Nothing to generate for azure-sdk-for-java

@AutorestCI
Copy link

AutorestCI commented Jan 31, 2019 •
edited
Loading

Automation for azure-sdk-for-node

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-node#4609

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

This was referenced Jan 31, 2019
Merged
Merged
Merged
Merged
nschonni
nschonni reviewed Jan 31, 2019
View reviewed changes
...resource-manager/Microsoft.SecurityInsights/preview/2019-01-01-preview/SecurityInsights.json Outdated Show resolved Hide resolved
...resource-manager/Microsoft.SecurityInsights/preview/2019-01-01-preview/SecurityInsights.json Outdated Show resolved Hide resolved
...resource-manager/Microsoft.SecurityInsights/preview/2019-01-01-preview/SecurityInsights.json Outdated Show resolved Hide resolved
...resource-manager/Microsoft.SecurityInsights/preview/2019-01-01-preview/SecurityInsights.json Outdated Show resolved Hide resolved
...resource-manager/Microsoft.SecurityInsights/preview/2019-01-01-preview/SecurityInsights.json Outdated Show resolved Hide resolved
...resource-manager/Microsoft.SecurityInsights/preview/2019-01-01-preview/SecurityInsights.json Outdated Show resolved Hide resolved
...resource-manager/Microsoft.SecurityInsights/preview/2019-01-01-preview/SecurityInsights.json Outdated Show resolved Hide resolved
...resource-manager/Microsoft.SecurityInsights/preview/2019-01-01-preview/SecurityInsights.json Outdated Show resolved Hide resolved
...resource-manager/Microsoft.SecurityInsights/preview/2019-01-01-preview/SecurityInsights.json Outdated Show resolved Hide resolved
...resource-manager/Microsoft.SecurityInsights/preview/2019-01-01-preview/SecurityInsights.json Outdated Show resolved Hide resolved
@jianghaolu
Copy link
Contributor

Please check the possible typos - otherwise LGTM.

@jianghaolu jianghaolu merged commit 39901f9 into Azure:master Feb 5, 2019
@jhendrixMSFT
Copy link
Member

@AutorestCI regenerate azure-sdk-for-go

@AutorestCI AutorestCI mentioned this pull request Feb 6, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jianghaolu jianghaolu jianghaolu approved these changes

@nschonni nschonni nschonni left review comments

Assignees

@jianghaolu jianghaolu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@nirgfani @AutorestCI @azuresdkci @jianghaolu @jhendrixMSFT @nschonni