Update swagger for DataFactory-SapOpenHub #5146

icehuhu · 2019-02-02T09:41:03Z

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.
The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

msftclas · 2019-02-02T09:41:14Z

All CLA requirements met.

azuresdkci · 2019-02-02T09:41:31Z

Can one of the admins verify this patch?

AutorestCI · 2019-02-02T09:41:39Z

Automation for azure-sdk-for-ruby

Encountered an unknown error: (azure-sdk-for-ruby)

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 33, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 170, in rest_handle_action
    return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 185, in rest_pull_close
    rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
    sdk_tag=sdk_tag
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 254, in generate_sdk_from_git_object
    with manage_git_folder(gh_token, Path(temp_dir) / Path("rest"), branched_rest_api_id, pr_number=pr_number) as restapi_git_folder, \
  File "/usr/lib/python3.6/contextlib.py", line 81, in __enter__
    return next(self.gen)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 272, in manage_git_folder
    clone_to_path(gh_token, temp_dir, split_git_id[0], branch_or_commit=branch, pr_number=pr_number)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 212, in clone_to_path
    repo.git.checkout(branch_or_commit)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 548, in <lambda>
    return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 1014, in _call_process
    return self.execute(call, **exec_kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 825, in execute
    raise GitCommandError(command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(128)
  cmdline: git checkout 1e8ee7342694426fb497e1b99ca6b01cdddebd64
  stderr: 'fatal: reference is not a tree: 1e8ee7342694426fb497e1b99ca6b01cdddebd64'

AutorestCI · 2019-02-02T09:42:44Z

Automation for azure-sdk-for-python

Encountered an unknown error: (azure-sdk-for-python)

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 33, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 170, in rest_handle_action
    return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 185, in rest_pull_close
    rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
    sdk_tag=sdk_tag
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 254, in generate_sdk_from_git_object
    with manage_git_folder(gh_token, Path(temp_dir) / Path("rest"), branched_rest_api_id, pr_number=pr_number) as restapi_git_folder, \
  File "/usr/lib/python3.6/contextlib.py", line 81, in __enter__
    return next(self.gen)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 272, in manage_git_folder
    clone_to_path(gh_token, temp_dir, split_git_id[0], branch_or_commit=branch, pr_number=pr_number)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 212, in clone_to_path
    repo.git.checkout(branch_or_commit)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 548, in <lambda>
    return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 1014, in _call_process
    return self.execute(call, **exec_kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 825, in execute
    raise GitCommandError(command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(128)
  cmdline: git checkout 1e8ee7342694426fb497e1b99ca6b01cdddebd64
  stderr: 'fatal: reference is not a tree: 1e8ee7342694426fb497e1b99ca6b01cdddebd64'

AutorestCI · 2019-02-02T09:46:04Z

Automation for azure-sdk-for-go

Encountered an unknown error: (azure-sdk-for-go)

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 33, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 170, in rest_handle_action
    return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 185, in rest_pull_close
    rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
    sdk_tag=sdk_tag
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 254, in generate_sdk_from_git_object
    with manage_git_folder(gh_token, Path(temp_dir) / Path("rest"), branched_rest_api_id, pr_number=pr_number) as restapi_git_folder, \
  File "/usr/lib/python3.6/contextlib.py", line 81, in __enter__
    return next(self.gen)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 272, in manage_git_folder
    clone_to_path(gh_token, temp_dir, split_git_id[0], branch_or_commit=branch, pr_number=pr_number)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 212, in clone_to_path
    repo.git.checkout(branch_or_commit)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 548, in <lambda>
    return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 1014, in _call_process
    return self.execute(call, **exec_kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 825, in execute
    raise GitCommandError(command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(128)
  cmdline: git checkout 1e8ee7342694426fb497e1b99ca6b01cdddebd64
  stderr: 'fatal: reference is not a tree: 1e8ee7342694426fb497e1b99ca6b01cdddebd64'

AutorestCI · 2019-02-02T09:46:44Z

Automation for azure-sdk-for-java

Encountered an unknown error: (azure-sdk-for-java)

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 33, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 170, in rest_handle_action
    return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 185, in rest_pull_close
    rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
    sdk_tag=sdk_tag
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 254, in generate_sdk_from_git_object
    with manage_git_folder(gh_token, Path(temp_dir) / Path("rest"), branched_rest_api_id, pr_number=pr_number) as restapi_git_folder, \
  File "/usr/lib/python3.6/contextlib.py", line 81, in __enter__
    return next(self.gen)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 272, in manage_git_folder
    clone_to_path(gh_token, temp_dir, split_git_id[0], branch_or_commit=branch, pr_number=pr_number)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 212, in clone_to_path
    repo.git.checkout(branch_or_commit)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 548, in <lambda>
    return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 1014, in _call_process
    return self.execute(call, **exec_kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 825, in execute
    raise GitCommandError(command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(128)
  cmdline: git checkout 1e8ee7342694426fb497e1b99ca6b01cdddebd64
  stderr: 'fatal: reference is not a tree: 1e8ee7342694426fb497e1b99ca6b01cdddebd64'

AutorestCI · 2019-02-02T09:48:19Z

Automation for azure-sdk-for-node

Encountered an unknown error: (azure-sdk-for-node)

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 33, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 170, in rest_handle_action
    return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 185, in rest_pull_close
    rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
    sdk_tag=sdk_tag
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 254, in generate_sdk_from_git_object
    with manage_git_folder(gh_token, Path(temp_dir) / Path("rest"), branched_rest_api_id, pr_number=pr_number) as restapi_git_folder, \
  File "/usr/lib/python3.6/contextlib.py", line 81, in __enter__
    return next(self.gen)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 272, in manage_git_folder
    clone_to_path(gh_token, temp_dir, split_git_id[0], branch_or_commit=branch, pr_number=pr_number)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 212, in clone_to_path
    repo.git.checkout(branch_or_commit)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 548, in <lambda>
    return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 1014, in _call_process
    return self.execute(call, **exec_kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 825, in execute
    raise GitCommandError(command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(128)
  cmdline: git checkout 1e8ee7342694426fb497e1b99ca6b01cdddebd64
  stderr: 'fatal: reference is not a tree: 1e8ee7342694426fb497e1b99ca6b01cdddebd64'

AutorestCI · 2019-02-02T10:05:27Z

Automation for azure-sdk-for-js

Encountered an unknown error: (azure-sdk-for-js)

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 33, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 170, in rest_handle_action
    return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 185, in rest_pull_close
    rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
    sdk_tag=sdk_tag
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 254, in generate_sdk_from_git_object
    with manage_git_folder(gh_token, Path(temp_dir) / Path("rest"), branched_rest_api_id, pr_number=pr_number) as restapi_git_folder, \
  File "/usr/lib/python3.6/contextlib.py", line 81, in __enter__
    return next(self.gen)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 272, in manage_git_folder
    clone_to_path(gh_token, temp_dir, split_git_id[0], branch_or_commit=branch, pr_number=pr_number)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 212, in clone_to_path
    repo.git.checkout(branch_or_commit)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 548, in <lambda>
    return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 1014, in _call_process
    return self.execute(call, **exec_kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 825, in execute
    raise GitCommandError(command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(128)
  cmdline: git checkout 1e8ee7342694426fb497e1b99ca6b01cdddebd64
  stderr: 'fatal: reference is not a tree: 1e8ee7342694426fb497e1b99ca6b01cdddebd64'

anthony-c-martin · 2019-02-08T06:48:43Z

...tory/resource-manager/Microsoft.DataFactory/stable/2018-06-01/entityTypes/LinkedService.json

+      ],
+      "properties": {
+        "typeProperties": {
+          "description": "Properties specific to this linked service type.",


Please add a more specific description

Hi @antmarti-microsoft thanks very much for your comments. I refined this accordingly and merge the change in #5195. could you please take a look? Thanks.

Will abandon this if that gets merged thanks.

anthony-c-martin · 2019-02-08T06:48:47Z

...tory/resource-manager/Microsoft.DataFactory/stable/2018-06-01/entityTypes/LinkedService.json

+      ]
+    },
+    "SapOpenHubLinkedServiceTypeProperties": {
+      "description": "Properties specific to this linked service type.",


Please add a more specific description

same as above.

anthony-c-martin · 2019-02-08T06:52:13Z

...atafactory/resource-manager/Microsoft.DataFactory/stable/2018-06-01/entityTypes/Dataset.json

+      "description": "Sap Business Warehouse Open Hub Destination Table properties.",
+      "properties": {
+        "openHubDestinationName": {
+          "type": "object",


Is it possible to define an entity for the type here (string/expression) rather than declaring as object?

Hi @antmarti-microsoft, thanks for your comments. it looks all the other datasets have been using the object as the type. could you please share a little bit more information on the criteria when the object will be used comparing with when the specific type(e.g. string) will be used? I recalled that the other objects were changed from specific types to object some time ago for some reasons. Thanks.

I move this change to #5195. Thanks.

praries880 · 2019-02-19T17:40:55Z

@icehuhu Pinging back on the status of changes requested by ARM.

ravbhatnagar · 2019-02-21T21:55:07Z

#5195 has been signed off. We dont need this PR. Removing the ARM labels from this.

praries880 · 2019-02-22T17:33:48Z

Closed as this PR is replaced by #5195

Update swagger for DataFactory-SapOpenHub

e2e0849

azuresdkci assigned praries880 Feb 2, 2019

azuresdkci requested a review from praries880 February 2, 2019 09:41

AutorestCI mentioned this pull request Feb 2, 2019

[AutoPR datafactory/resource-manager] Update swagger for DataFactory-SapOpenHub Azure/azure-sdk-for-python#4299

Closed

This was referenced Feb 2, 2019

[AutoPR datafactory/resource-manager] Update swagger for DataFactory-SapOpenHub Azure/azure-sdk-for-go#4007

Closed

[AutoPR datafactory/resource-manager] Update swagger for DataFactory-SapOpenHub Azure/azure-sdk-for-java#2909

Closed

This was referenced Feb 2, 2019

[AutoPR datafactory/resource-manager] Update swagger for DataFactory-SapOpenHub Azure/azure-sdk-for-node#4633

Closed

[AutoPR datafactory/resource-manager] Update swagger for DataFactory-SapOpenHub Azure/azure-sdk-for-js#1096

Closed

praries880 added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Feb 4, 2019

anthony-c-martin requested changes Feb 8, 2019

View reviewed changes

praries880 added ARMReviewInProgress ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review labels Feb 11, 2019

ravbhatnagar removed ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review ARMReviewInProgress WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Feb 21, 2019

praries880 closed this Feb 22, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update swagger for DataFactory-SapOpenHub #5146

Update swagger for DataFactory-SapOpenHub #5146

icehuhu commented Feb 2, 2019 •

edited

Loading

msftclas commented Feb 2, 2019 •

edited

Loading

azuresdkci commented Feb 2, 2019

AutorestCI commented Feb 2, 2019 •

edited

Loading

AutorestCI commented Feb 2, 2019 •

edited

Loading

AutorestCI commented Feb 2, 2019 •

edited

Loading

AutorestCI commented Feb 2, 2019 •

edited

Loading

AutorestCI commented Feb 2, 2019 •

edited

Loading

AutorestCI commented Feb 2, 2019 •

edited

Loading

anthony-c-martin Feb 8, 2019

wenbof-zz Feb 13, 2019

wenbof-zz Feb 13, 2019

anthony-c-martin Feb 8, 2019

wenbof-zz Feb 13, 2019

anthony-c-martin Feb 8, 2019

wenbof-zz Feb 13, 2019

wenbof-zz Feb 13, 2019

praries880 commented Feb 19, 2019

ravbhatnagar commented Feb 21, 2019

praries880 commented Feb 22, 2019

Update swagger for DataFactory-SapOpenHub #5146

Update swagger for DataFactory-SapOpenHub #5146

Conversation

icehuhu commented Feb 2, 2019 • edited Loading

Latest improvements:

Contribution checklist:

ARM API Review Checklist

msftclas commented Feb 2, 2019 • edited Loading

azuresdkci commented Feb 2, 2019

AutorestCI commented Feb 2, 2019 • edited Loading

Automation for azure-sdk-for-ruby

AutorestCI commented Feb 2, 2019 • edited Loading

Automation for azure-sdk-for-python

AutorestCI commented Feb 2, 2019 • edited Loading

Automation for azure-sdk-for-go

AutorestCI commented Feb 2, 2019 • edited Loading

Automation for azure-sdk-for-java

AutorestCI commented Feb 2, 2019 • edited Loading

Automation for azure-sdk-for-node

AutorestCI commented Feb 2, 2019 • edited Loading

Automation for azure-sdk-for-js

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

praries880 commented Feb 19, 2019

ravbhatnagar commented Feb 21, 2019

praries880 commented Feb 22, 2019

icehuhu commented Feb 2, 2019 •

edited

Loading

msftclas commented Feb 2, 2019 •

edited

Loading

AutorestCI commented Feb 2, 2019 •

edited

Loading

AutorestCI commented Feb 2, 2019 •

edited

Loading

AutorestCI commented Feb 2, 2019 •

edited

Loading

AutorestCI commented Feb 2, 2019 •

edited

Loading

AutorestCI commented Feb 2, 2019 •

edited

Loading

AutorestCI commented Feb 2, 2019 •

edited

Loading