-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating Data Classification Swaggers. #5148
Conversation
Update data classification swaggers.
Automation for azure-sdk-for-jsThe initial PR has been merged into your service PR: |
Automation for azure-sdk-for-rubyThe initial PR has been merged into your service PR: |
Can one of the admins verify this patch? |
Automation for azure-sdk-for-pythonThe initial PR has been merged into your service PR: |
Automation for azure-sdk-for-goA PR has been created for you based on this PR content. Once this PR will be merged, content will be added to your service PR: |
Automation for azure-sdk-for-nodeThe initial PR has been merged into your service PR: |
Automation for azure-sdk-for-javaThe initial PR has been merged into your service PR: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI is failing syntax and semantic checks, please take a look at those first, so the other tools can properly execute. If you need help, please let me know. Thanks!
@veronicagg Automation for azure-sdk-for-java is failing since I added - ./Microsoft.Sql/preview/2017-03-01-preview/sensitivityLabels.json under package-pure-2017-03-preview in the readme.md file. |
@bashahee there's probably a class name that's duplicated in that version when you add the file, so it's colliding on SDK generation - "Duplicate File Generation". |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comments inline.
@veronicagg I am not introducing new APIs, these APIs are already in production. I am updating swagger files in order to generate SDK clients, as part of my work on implementing PowerShell Cmdlets. |
@veronicagg Can this PR be merged now? |
@bashahee Identified an issue in java codegen and created an issue here Azure/autorest.java#323. However fixing it requires some time, meantime to unblock your PR, I've updated readme Java section and opened this PR https://github.com/bashahee/azure-rest-api-specs/pull/1, could you merge it? |
@bashahee I was waiting on the java code gen issue, please take a look at the PR suggested by @anuchandy , if it makes sense to you to do the rename to avoid collisions, please merge that in, and I'll approve/merge this PR. Thanks! |
Fixing java codegen
@AutorestCI regenerate azure-sdk-for-go |
This PR updates Data Classification swagger files and examples. This is not a breaking change, as reference to these files was not present in the readme.me file, hence clients were not generated yet.
Latest improvements:
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
ARM API Review Checklist
Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.
Please follow the link to find more details on API review process.