Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed "x-ms-pageable" from the elevateAccess API #5154

Merged
merged 3 commits into from
Feb 6, 2019

Conversation

rosgu
Copy link
Contributor

@rosgu rosgu commented Feb 4, 2019

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@AutorestCI
Copy link

AutorestCI commented Feb 4, 2019

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#4061

@AutorestCI
Copy link

AutorestCI commented Feb 4, 2019

Automation for azure-sdk-for-ruby

Encountered a Subprocess error: (azure-sdk-for-ruby)

Command: bundle install && rake arm:regen_all_profiles['azure_mgmt_authorization']
Finished with return code 1
and output:

Don't run Bundler as root. Bundler can ask for sudo if it is needed, and
installing your bundle as root will break this application for all non-root
users on this machine.
Fetching gem metadata from https://rubygems.org/.........
Resolving dependencies...
Using rake 12.3.2
Using public_suffix 3.0.3
Using addressable 2.5.2
Using multipart-post 2.0.0
Using faraday 0.15.4
Using faraday_middleware 0.13.1
Using mini_portile2 2.4.0
Using nokogiri 1.10.1
Using azure-core 0.1.15
Using azure-storage 0.14.0.preview
Using concurrent-ruby 1.1.4
Using unf_ext 0.0.7.5
Using unf 0.1.4
Using domain_name 0.5.20180417
Using http-cookie 1.0.3
Using faraday-cookie_jar 0.0.6
Using timeliness 0.3.10
Using ms_rest 0.7.3
Using ms_rest_azure 0.11.0
Using azure_cognitiveservices_autosuggest 0.17.0 from source at `data/azure_cognitiveservices_autosuggest`
Using azure_cognitiveservices_computervision 0.17.0 from source at `data/azure_cognitiveservices_computervision`
Using azure_cognitiveservices_contentmoderator 0.17.1 from source at `data/azure_cognitiveservices_contentmoderator`
Using azure_cognitiveservices_customimagesearch 0.17.0 from source at `data/azure_cognitiveservices_customimagesearch`
Using azure_cognitiveservices_customsearch 0.18.0 from source at `data/azure_cognitiveservices_customsearch`
Using azure_cognitiveservices_customvisionprediction 0.17.0 from source at `data/azure_cognitiveservices_customvisionprediction`
Using azure_cognitiveservices_customvisiontraining 0.17.0 from source at `data/azure_cognitiveservices_customvisiontraining`
Using azure_cognitiveservices_entitysearch 0.18.0 from source at `data/azure_cognitiveservices_entitysearch`
Using azure_cognitiveservices_face 0.17.0 from source at `data/azure_cognitiveservices_face`
Using azure_cognitiveservices_imagesearch 0.18.0 from source at `data/azure_cognitiveservices_imagesearch`
Using azure_cognitiveservices_localsearch 0.17.0 from source at `data/azure_cognitiveservices_localsearch`
Using azure_cognitiveservices_newssearch 0.18.0 from source at `data/azure_cognitiveservices_newssearch`
Using azure_cognitiveservices_qnamaker 0.17.0 from source at `data/azure_cognitiveservices_qnamaker`
Using azure_cognitiveservices_spellcheck 0.18.0 from source at `data/azure_cognitiveservices_spellcheck`
Using azure_cognitiveservices_textanalytics 0.17.1 from source at `data/azure_cognitiveservices_textanalytics`
Using azure_cognitiveservices_videosearch 0.18.0 from source at `data/azure_cognitiveservices_videosearch`
Using azure_cognitiveservices_visualsearch 0.18.0 from source at `data/azure_cognitiveservices_visualsearch`
Using azure_cognitiveservices_websearch 0.18.0 from source at `data/azure_cognitiveservices_websearch`
Using azure_event_grid 0.17.0 from source at `data/azure_event_grid`
Using azure_graph_rbac 0.17.0 from source at `data/azure_graph_rbac`
Using azure_key_vault 0.17.1 from source at `data/azure_key_vault`
Using azure_mgmt_analysis_services 0.17.1 from source at `management/azure_mgmt_analysis_services`
Using azure_mgmt_api_management 0.18.1 from source at `management/azure_mgmt_api_management`
Using azure_mgmt_authorization 0.18.2 from source at `management/azure_mgmt_authorization`
Using azure_mgmt_automation 0.17.1 from source at `management/azure_mgmt_automation`
Using azure_mgmt_batch 0.17.1 from source at `management/azure_mgmt_batch`
Using azure_mgmt_billing 0.17.1 from source at `management/azure_mgmt_billing`
Using azure_mgmt_cdn 0.17.1 from source at `management/azure_mgmt_cdn`
Using azure_mgmt_cognitive_services 0.17.0 from source at `management/azure_mgmt_cognitive_services`
Using azure_mgmt_commerce 0.17.0 from source at `management/azure_mgmt_commerce`
Using azure_mgmt_compute 0.18.3 from source at `management/azure_mgmt_compute`
Using azure_mgmt_consumption 0.17.1 from source at `management/azure_mgmt_consumption`
Using azure_mgmt_container_instance 0.17.3 from source at `management/azure_mgmt_container_instance`
Using azure_mgmt_container_registry 0.17.2 from source at `management/azure_mgmt_container_registry`
Using azure_mgmt_container_service 0.18.1 from source at `management/azure_mgmt_container_service`
Using azure_mgmt_customer_insights 0.17.1 from source at `management/azure_mgmt_customer_insights`
Using azure_mgmt_data_migration 0.17.0 from source at `management/azure_mgmt_data_migration`
Using azure_mgmt_datalake_analytics 0.17.1 from source at `management/azure_mgmt_datalake_analytics`
Using azure_mgmt_datalake_store 0.17.1 from source at `management/azure_mgmt_datalake_store`
Using azure_mgmt_dev_spaces 0.17.1 from source at `management/azure_mgmt_dev_spaces`
Using azure_mgmt_devtestlabs 0.17.1 from source at `management/azure_mgmt_devtestlabs`
Using azure_mgmt_dns 0.17.2 from source at `management/azure_mgmt_dns`
Using azure_mgmt_event_grid 0.17.2 from source at `management/azure_mgmt_event_grid`
Using azure_mgmt_event_hub 0.17.1 from source at `management/azure_mgmt_event_hub`
Using azure_mgmt_features 0.17.1 from source at `management/azure_mgmt_features`
Using azure_mgmt_iot_central 0.17.2 from source at `management/azure_mgmt_iot_central`
Using azure_mgmt_iot_hub 0.17.1 from source at `management/azure_mgmt_iot_hub`
Using azure_mgmt_key_vault 0.17.2 from source at `management/azure_mgmt_key_vault`
Using azure_mgmt_kusto 0.17.0 from source at `management/azure_mgmt_kusto`
Using azure_mgmt_links 0.17.1 from source at `management/azure_mgmt_links`
Using azure_mgmt_locks 0.17.1 from source at `management/azure_mgmt_locks`
Using azure_mgmt_logic 0.17.2 from source at `management/azure_mgmt_logic`
Using azure_mgmt_machine_learning 0.17.1 from source at `management/azure_mgmt_machine_learning`
Using azure_mgmt_managed_applications 0.17.1 from source at `management/azure_mgmt_managed_applications`
Using azure_mgmt_marketplace_ordering 0.17.1 from source at `management/azure_mgmt_marketplace_ordering`
Using azure_mgmt_media_services 0.17.2 from source at `management/azure_mgmt_media_services`
Using azure_mgmt_monitor 0.17.1 from source at `management/azure_mgmt_monitor`
Using azure_mgmt_msi 0.17.0 from source at `management/azure_mgmt_msi`
Using azure_mgmt_network 0.18.2 from source at `management/azure_mgmt_network`
Using azure_mgmt_notification_hubs 0.17.1 from source at `management/azure_mgmt_notification_hubs`
Using azure_mgmt_operational_insights 0.17.1 from source at `management/azure_mgmt_operational_insights`
Using azure_mgmt_policy 0.17.1 from source at `management/azure_mgmt_policy`
Using azure_mgmt_policy_insights 0.17.0 from source at `management/azure_mgmt_policy_insights`
Using azure_mgmt_powerbi_embedded 0.17.0 from source at `management/azure_mgmt_powerbi_embedded`
Using azure_mgmt_recovery_services 0.17.1 from source at `management/azure_mgmt_recovery_services`
Using azure_mgmt_recovery_services_backup 0.17.1 from source at `management/azure_mgmt_recovery_services_backup`
Using azure_mgmt_recovery_services_site_recovery 0.17.1 from source at `management/azure_mgmt_recovery_services_site_recovery`
Using azure_mgmt_redis 0.17.1 from source at `management/azure_mgmt_redis`
Using azure_mgmt_relay 0.17.1 from source at `management/azure_mgmt_relay`
Using azure_mgmt_resources 0.17.2 from source at `management/azure_mgmt_resources`
Using azure_mgmt_resources_management 0.17.0 from source at `management/azure_mgmt_resources_management`
Using azure_mgmt_scheduler 0.17.0 from source at `management/azure_mgmt_scheduler`
Using azure_mgmt_search 0.17.1 from source at `management/azure_mgmt_search`
Using azure_mgmt_security 0.17.1 from source at `management/azure_mgmt_security`
Using azure_mgmt_service_bus 0.17.1 from source at `management/azure_mgmt_service_bus`
Using azure_mgmt_service_fabric 0.17.1 from source at `management/azure_mgmt_service_fabric`
Using azure_mgmt_signalr 0.17.2 from source at `management/azure_mgmt_signalr`
Using azure_mgmt_sql 0.17.1 from source at `management/azure_mgmt_sql`
Using azure_mgmt_sqlvirtualmachine 0.17.1 from source at `management/azure_mgmt_sqlvirtualmachine`
Using azure_mgmt_stor_simple8000_series 0.17.1 from source at `management/azure_mgmt_stor_simple8000_series`
Using azure_mgmt_storage 0.17.4 from source at `management/azure_mgmt_storage`
Using azure_mgmt_stream_analytics 0.17.1 from source at `management/azure_mgmt_stream_analytics`
Using azure_mgmt_subscriptions 0.17.1 from source at `management/azure_mgmt_subscriptions`
Using azure_mgmt_traffic_manager 0.17.1 from source at `management/azure_mgmt_traffic_manager`
Using azure_mgmt_web 0.17.2 from source at `management/azure_mgmt_web`
Using azure_sdk 0.19.7 from source at `azure_sdk`
Using azure_service_fabric 0.17.0 from source at `data/azure_service_fabric`
Using bundler 1.16.1
Using diff-lcs 1.3
Using dotenv 2.6.0
Using sawyer 0.8.1
Using octokit 4.13.0
Using os 1.0.0
Using rspec-support 3.8.0
Using rspec-core 3.8.0
Using rspec-expectations 3.8.2
Using rspec-mocks 3.8.0
Using rspec 3.8.0
Using vcr 4.0.0
Bundle complete! 93 Gemfile dependencies, 118 gems now installed.
Use `bundle info [gemname]` to see where a bundled gem is installed.
Cleaning folder - /tmp/tmpzgcpskz8/sdk/azure_sdk/lib/v2018_03_01
Cleaning folder - /tmp/tmpzgcpskz8/sdk/azure_sdk/lib/v2017_03_09
Cleaning folder - /tmp/tmpzgcpskz8/sdk/azure_sdk/lib/latest
running: bundle exec ruby /tmp/tmpzgcpskz8/sdk/generators/profilegen/src/profile_generator_client.rb --dir_metadata=/tmp/tmpzgcpskz8/sdk/config/dir_metadata.json --profile=/tmp/tmpzgcpskz8/sdk/config/profiles.json --mode=rollup --key=azure_sdk --sdk_path=/tmp/tmpzgcpskz8/sdk
FAILED !!!
/tmp/tmpzgcpskz8/sdk/generators/profilegen/src/profile_generator.rb:208:in `generate_operation_types': uninitialized constant Azure::Authorization::Mgmt::V2015_07_01 (NameError)
Did you mean?  Azure::Authorization::Mgmt::V2015_07_01_preview
	from /tmp/tmpzgcpskz8/sdk/generators/profilegen/src/profile_generator.rb:123:in `block (4 levels) in generate_modules'
	from /tmp/tmpzgcpskz8/sdk/generators/profilegen/src/profile_generator.rb:122:in `each'
	from /tmp/tmpzgcpskz8/sdk/generators/profilegen/src/profile_generator.rb:122:in `block (3 levels) in generate_modules'
	from /tmp/tmpzgcpskz8/sdk/generators/profilegen/src/profile_generator.rb:118:in `each'
	from /tmp/tmpzgcpskz8/sdk/generators/profilegen/src/profile_generator.rb:118:in `block (2 levels) in generate_modules'
	from /tmp/tmpzgcpskz8/sdk/generators/profilegen/src/profile_generator.rb:101:in `each'
	from /tmp/tmpzgcpskz8/sdk/generators/profilegen/src/profile_generator.rb:101:in `block in generate_modules'
	from /tmp/tmpzgcpskz8/sdk/generators/profilegen/src/profile_generator.rb:95:in `each'
	from /tmp/tmpzgcpskz8/sdk/generators/profilegen/src/profile_generator.rb:95:in `generate_modules'
	from /tmp/tmpzgcpskz8/sdk/generators/profilegen/src/profile_generator.rb:68:in `generate_profile_sdk'
	from /tmp/tmpzgcpskz8/sdk/generators/profilegen/src/profile_generator.rb:38:in `generate'
	from /tmp/tmpzgcpskz8/sdk/generators/profilegen/src/profile_generator_client.rb:15:in `block in <main>'
	from /tmp/tmpzgcpskz8/sdk/generators/profilegen/src/profile_generator_client.rb:14:in `each'
	from /tmp/tmpzgcpskz8/sdk/generators/profilegen/src/profile_generator_client.rb:14:in `<main>'

@AutorestCI
Copy link

AutorestCI commented Feb 4, 2019

Automation for azure-sdk-for-js

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-js#542

@AutorestCI
Copy link

AutorestCI commented Feb 4, 2019

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#4038

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@AutorestCI
Copy link

AutorestCI commented Feb 5, 2019

Automation for azure-sdk-for-node

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-node#4150

@AutorestCI
Copy link

AutorestCI commented Feb 5, 2019

Automation for azure-sdk-for-java

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-java#2628

@jianghaolu jianghaolu merged commit 27d10c9 into Azure:master Feb 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants