[DO NOT MERGE] Changes for introduction of transfer products API for Microsoft.Billing #5176

batman11235 · 2019-02-08T10:32:09Z

These are the API changes for the transfer products API for Azure modern billing platform infrastructure. The remaining changes for the APIs have been already approved.

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.
The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

These are the API changes for the transfer products API for Azure modern billing platform infrastructure

AutorestCI · 2019-02-08T10:32:42Z

Automation for azure-sdk-for-js

Encountered an unknown error: (azure-sdk-for-js)

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 33, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 170, in rest_handle_action
    return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 185, in rest_pull_close
    rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
    sdk_tag=sdk_tag
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 254, in generate_sdk_from_git_object
    with manage_git_folder(gh_token, Path(temp_dir) / Path("rest"), branched_rest_api_id, pr_number=pr_number) as restapi_git_folder, \
  File "/usr/lib/python3.6/contextlib.py", line 81, in __enter__
    return next(self.gen)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 272, in manage_git_folder
    clone_to_path(gh_token, temp_dir, split_git_id[0], branch_or_commit=branch, pr_number=pr_number)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 212, in clone_to_path
    repo.git.checkout(branch_or_commit)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 548, in <lambda>
    return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 1014, in _call_process
    return self.execute(call, **exec_kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 825, in execute
    raise GitCommandError(command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(128)
  cmdline: git checkout d64e68299f6f4338cad41df2227a784282e77734
  stderr: 'fatal: reference is not a tree: d64e68299f6f4338cad41df2227a784282e77734'

AutorestCI · 2019-02-08T10:32:51Z

Automation for azure-sdk-for-python

Encountered an unknown error: (azure-sdk-for-python)

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 33, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 170, in rest_handle_action
    return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 185, in rest_pull_close
    rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
    sdk_tag=sdk_tag
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 254, in generate_sdk_from_git_object
    with manage_git_folder(gh_token, Path(temp_dir) / Path("rest"), branched_rest_api_id, pr_number=pr_number) as restapi_git_folder, \
  File "/usr/lib/python3.6/contextlib.py", line 81, in __enter__
    return next(self.gen)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 272, in manage_git_folder
    clone_to_path(gh_token, temp_dir, split_git_id[0], branch_or_commit=branch, pr_number=pr_number)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 212, in clone_to_path
    repo.git.checkout(branch_or_commit)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 548, in <lambda>
    return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 1014, in _call_process
    return self.execute(call, **exec_kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 825, in execute
    raise GitCommandError(command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(128)
  cmdline: git checkout d64e68299f6f4338cad41df2227a784282e77734
  stderr: 'fatal: reference is not a tree: d64e68299f6f4338cad41df2227a784282e77734'

AutorestCI · 2019-02-08T10:33:12Z

Automation for azure-sdk-for-ruby

Encountered an unknown error: (azure-sdk-for-ruby)

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 33, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 170, in rest_handle_action
    return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 185, in rest_pull_close
    rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
    sdk_tag=sdk_tag
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 254, in generate_sdk_from_git_object
    with manage_git_folder(gh_token, Path(temp_dir) / Path("rest"), branched_rest_api_id, pr_number=pr_number) as restapi_git_folder, \
  File "/usr/lib/python3.6/contextlib.py", line 81, in __enter__
    return next(self.gen)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 272, in manage_git_folder
    clone_to_path(gh_token, temp_dir, split_git_id[0], branch_or_commit=branch, pr_number=pr_number)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 212, in clone_to_path
    repo.git.checkout(branch_or_commit)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 548, in <lambda>
    return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 1014, in _call_process
    return self.execute(call, **exec_kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 825, in execute
    raise GitCommandError(command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(128)
  cmdline: git checkout d64e68299f6f4338cad41df2227a784282e77734
  stderr: 'fatal: reference is not a tree: d64e68299f6f4338cad41df2227a784282e77734'

AutorestCI · 2019-02-08T10:33:38Z

Automation for azure-sdk-for-node

Encountered an unknown error: (azure-sdk-for-node)

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 33, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 170, in rest_handle_action
    return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 185, in rest_pull_close
    rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
    sdk_tag=sdk_tag
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 254, in generate_sdk_from_git_object
    with manage_git_folder(gh_token, Path(temp_dir) / Path("rest"), branched_rest_api_id, pr_number=pr_number) as restapi_git_folder, \
  File "/usr/lib/python3.6/contextlib.py", line 81, in __enter__
    return next(self.gen)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 272, in manage_git_folder
    clone_to_path(gh_token, temp_dir, split_git_id[0], branch_or_commit=branch, pr_number=pr_number)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 212, in clone_to_path
    repo.git.checkout(branch_or_commit)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 548, in <lambda>
    return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 1014, in _call_process
    return self.execute(call, **exec_kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 825, in execute
    raise GitCommandError(command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(128)
  cmdline: git checkout d64e68299f6f4338cad41df2227a784282e77734
  stderr: 'fatal: reference is not a tree: d64e68299f6f4338cad41df2227a784282e77734'

AutorestCI · 2019-02-08T10:33:57Z

Automation for azure-sdk-for-java

Encountered an unknown error: (azure-sdk-for-java)

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 33, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 170, in rest_handle_action
    return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 185, in rest_pull_close
    rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
    sdk_tag=sdk_tag
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 254, in generate_sdk_from_git_object
    with manage_git_folder(gh_token, Path(temp_dir) / Path("rest"), branched_rest_api_id, pr_number=pr_number) as restapi_git_folder, \
  File "/usr/lib/python3.6/contextlib.py", line 81, in __enter__
    return next(self.gen)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 272, in manage_git_folder
    clone_to_path(gh_token, temp_dir, split_git_id[0], branch_or_commit=branch, pr_number=pr_number)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 212, in clone_to_path
    repo.git.checkout(branch_or_commit)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 548, in <lambda>
    return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 1014, in _call_process
    return self.execute(call, **exec_kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 825, in execute
    raise GitCommandError(command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(128)
  cmdline: git checkout d64e68299f6f4338cad41df2227a784282e77734
  stderr: 'fatal: reference is not a tree: d64e68299f6f4338cad41df2227a784282e77734'

AutorestCI · 2019-02-08T10:34:33Z

Automation for azure-sdk-for-go

Encountered an unknown error: (azure-sdk-for-go)

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 33, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 170, in rest_handle_action
    return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 185, in rest_pull_close
    rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
    sdk_tag=sdk_tag
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 254, in generate_sdk_from_git_object
    with manage_git_folder(gh_token, Path(temp_dir) / Path("rest"), branched_rest_api_id, pr_number=pr_number) as restapi_git_folder, \
  File "/usr/lib/python3.6/contextlib.py", line 81, in __enter__
    return next(self.gen)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 272, in manage_git_folder
    clone_to_path(gh_token, temp_dir, split_git_id[0], branch_or_commit=branch, pr_number=pr_number)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 212, in clone_to_path
    repo.git.checkout(branch_or_commit)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 548, in <lambda>
    return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 1014, in _call_process
    return self.execute(call, **exec_kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 825, in execute
    raise GitCommandError(command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(128)
  cmdline: git checkout d64e68299f6f4338cad41df2227a784282e77734
  stderr: 'fatal: reference is not a tree: d64e68299f6f4338cad41df2227a784282e77734'

azuresdkci · 2019-02-08T10:34:47Z

Can one of the admins verify this patch?

specification/billing/resource-manager/readme.go.md

...ification/billing/resource-manager/Microsoft.Billing/preview/2018-11-01-preview/billing.json

anthony-c-martin · 2019-02-08T23:43:22Z

...ification/billing/resource-manager/Microsoft.Billing/preview/2018-11-01-preview/billing.json

+        "responses": {
+          "202": {
+            "description": "Accepted",
+            "headers": {


Which header contains the async operation status URI? Location or Azure-AsyncOperation? I think you can also simplify this to something like this

I am following the pattern in our swagger so far, location is the operationsresults and asyncoperations - for the async operation status. We have internally debated on this and the next PR with all the changes, we will be working to address that. I will be looping in our lead developer separately.

anthony-c-martin · 2019-02-08T23:46:04Z

...ification/billing/resource-manager/Microsoft.Billing/preview/2018-11-01-preview/billing.json

+      "in": "query",
+      "required": true,
+      "type": "string",
+      "description": "Version of the API to be used with the client request. The current version is 2018-11-01-preview."


Might be easier not to mention the current version - one less thing to forget when next updating the schema, and not necessarily accurate depending on the current status of your service.

...ification/billing/resource-manager/Microsoft.Billing/preview/2018-11-01-preview/billing.json

.../resource-manager/Microsoft.Billing/preview/2018-11-01-preview/examples/TransferProduct.json

[DO NOT MERGE] Changes for introduction of transfer products API

5cea84d

These are the API changes for the transfer products API for Azure modern billing platform infrastructure

AutorestCI mentioned this pull request Feb 8, 2019

[AutoPR billing/resource-manager] [DO NOT MERGE] Changes for introduction of transfer products API Azure/azure-sdk-for-js#1159

Closed

AutorestCI mentioned this pull request Feb 8, 2019

[AutoPR billing/resource-manager] [DO NOT MERGE] Changes for introduction of transfer products API Azure/azure-sdk-for-python#4335

Closed

batman11235 changed the title ~~[DO NOT MERGE] Changes for introduction of transfer products API~~ [DO NOT MERGE] Changes for introduction of transfer products API for Microsoft.Billing Feb 8, 2019

AutorestCI mentioned this pull request Feb 8, 2019

[AutoPR billing/resource-manager] [DO NOT MERGE] Changes for introduction of transfer products API Azure/azure-sdk-for-ruby#2212

Closed

azuresdkci assigned praries880 Feb 8, 2019

azuresdkci requested a review from praries880 February 8, 2019 10:33

AutorestCI mentioned this pull request Feb 8, 2019

[AutoPR billing/resource-manager] [DO NOT MERGE] Changes for introduction of transfer products API Azure/azure-sdk-for-node#4657

Closed

AutorestCI mentioned this pull request Feb 8, 2019

[AutoPR billing/resource-manager] [DO NOT MERGE] Changes for introduction of transfer products API Azure/azure-sdk-for-go#4055

Closed

batman11235 closed this Feb 8, 2019

batman11235 reopened this Feb 8, 2019

nschonni reviewed Feb 8, 2019

View reviewed changes

specification/billing/resource-manager/readme.go.md Show resolved Hide resolved

nschonni reviewed Feb 8, 2019

View reviewed changes

...ification/billing/resource-manager/Microsoft.Billing/preview/2018-11-01-preview/billing.json Outdated Show resolved Hide resolved

batman11235 added 2 commits February 8, 2019 13:02

Changes for the Microsoft Billing APIs

f7bd66f

Updates to Microsoft.Billing Manifests

eb2615f

anthony-c-martin requested changes Feb 8, 2019

View reviewed changes

Swagger changes for Microsoft.Billing for GTM product transfers

4ef0f1d

anthony-c-martin approved these changes Feb 9, 2019

View reviewed changes

batman11235 closed this Feb 9, 2019

wilcobmsft mentioned this pull request Mar 19, 2019

Add GTM APIs. #5423

Merged

5 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[DO NOT MERGE] Changes for introduction of transfer products API for Microsoft.Billing #5176

[DO NOT MERGE] Changes for introduction of transfer products API for Microsoft.Billing #5176

batman11235 commented Feb 8, 2019 •

edited

Loading

AutorestCI commented Feb 8, 2019 •

edited

Loading

AutorestCI commented Feb 8, 2019 •

edited

Loading

AutorestCI commented Feb 8, 2019 •

edited

Loading

AutorestCI commented Feb 8, 2019 •

edited

Loading

AutorestCI commented Feb 8, 2019 •

edited

Loading

AutorestCI commented Feb 8, 2019 •

edited

Loading

azuresdkci commented Feb 8, 2019

anthony-c-martin Feb 8, 2019

batman11235 Feb 9, 2019

anthony-c-martin Feb 8, 2019

[DO NOT MERGE] Changes for introduction of transfer products API for Microsoft.Billing #5176

[DO NOT MERGE] Changes for introduction of transfer products API for Microsoft.Billing #5176

Conversation

batman11235 commented Feb 8, 2019 • edited Loading

Latest improvements:

Contribution checklist:

ARM API Review Checklist

AutorestCI commented Feb 8, 2019 • edited Loading

Automation for azure-sdk-for-js

AutorestCI commented Feb 8, 2019 • edited Loading

Automation for azure-sdk-for-python

AutorestCI commented Feb 8, 2019 • edited Loading

Automation for azure-sdk-for-ruby

AutorestCI commented Feb 8, 2019 • edited Loading

Automation for azure-sdk-for-node

AutorestCI commented Feb 8, 2019 • edited Loading

Automation for azure-sdk-for-java

AutorestCI commented Feb 8, 2019 • edited Loading

Automation for azure-sdk-for-go

azuresdkci commented Feb 8, 2019

anthony-c-martin Feb 8, 2019

Choose a reason for hiding this comment

batman11235 Feb 9, 2019

Choose a reason for hiding this comment

anthony-c-martin Feb 8, 2019

Choose a reason for hiding this comment

batman11235 commented Feb 8, 2019 •

edited

Loading

AutorestCI commented Feb 8, 2019 •

edited

Loading

AutorestCI commented Feb 8, 2019 •

edited

Loading

AutorestCI commented Feb 8, 2019 •

edited

Loading

AutorestCI commented Feb 8, 2019 •

edited

Loading

AutorestCI commented Feb 8, 2019 •

edited

Loading

AutorestCI commented Feb 8, 2019 •

edited

Loading