Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Private DNS Swagger spec for API version 2018-09-01 #5198

Merged
merged 3 commits into from
Feb 13, 2019

Conversation

muwaqar
Copy link
Contributor

@muwaqar muwaqar commented Feb 13, 2019

This PR was previously approved against the private repository by both ARM and OpenAPI teams.

OpenAPI Hub was not used for this PR since it does not allow onboarding of a new resource type as of yet. This feedback has been given to Samer previously.

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@AutorestCI
Copy link

AutorestCI commented Feb 13, 2019

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#4359

@AutorestCI
Copy link

AutorestCI commented Feb 13, 2019

Automation for azure-sdk-for-js

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-js#1212

@AutorestCI
Copy link

AutorestCI commented Feb 13, 2019

Automation for azure-sdk-for-ruby

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-ruby#2233

@AutorestCI
Copy link

AutorestCI commented Feb 13, 2019

Automation for azure-sdk-for-node

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-node#4680

@AutorestCI
Copy link

AutorestCI commented Feb 13, 2019

Automation for azure-sdk-for-java

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-java#2998

@AutorestCI
Copy link

AutorestCI commented Feb 13, 2019

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#4082

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@sergey-shandar
Copy link
Contributor

Waiting for codeowners approval.

@muwaqar muwaqar requested review from a user and sunilkh31 February 13, 2019 18:54
@sergey-shandar sergey-shandar merged commit 9a29f45 into Azure:master Feb 13, 2019
@muwaqar muwaqar deleted the dev-privatedns-2018-09-01 branch February 14, 2019 18:30
@jianghaolu
Copy link
Contributor

@AutorestCI regenerate azure-sdk-for-java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants