Security: 2017-08-01-preview - Introduce IoT security solution resource #5234

dortibi · 2019-02-20T10:50:44Z

Add relevent APIs for new resource called Iot Security Solution part Microsoft.Security provider
- new definitions
- new get, put, delete, list operations
- new examples files

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.
The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

chnage the iotSecuritySolution schema

AutorestCI · 2019-02-20T10:51:13Z

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

AutorestCI · 2019-02-20T10:51:35Z

Automation for azure-sdk-for-python

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-python#3782

AutorestCI · 2019-02-20T10:51:57Z

Automation for azure-sdk-for-java

Nothing to generate for azure-sdk-for-java

AutorestCI · 2019-02-20T10:52:04Z

Automation for azure-sdk-for-js

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-js#1835

AutorestCI · 2019-02-20T10:53:08Z

Automation for azure-sdk-for-go

Nothing to generate for azure-sdk-for-go

AutorestCI · 2019-02-20T10:54:57Z

Automation for azure-sdk-for-node

A PR has been created for you:
Azure/azure-sdk-for-node#4857

dortibi · 2019-02-20T12:01:14Z

Could you please add a label - DoNotMerge?

azuresdkci · 2019-02-20T12:04:54Z

Can one of the admins verify this patch?

veronicagg

I've added [Do not merge] in the title, will you continue to add changes to the PR?
Have the changes been reviewed by ARM? I'll add them to the review.
Thanks!

veronicagg · 2019-02-20T18:13:30Z

BTW, you can browse your validation results and generated documentation using your work branch page in the OpenAPI Hub.

dortibi · 2019-02-24T09:00:40Z

@veronicagg, there is no more changes.
could you please add @RyanBensonMSFT from ARM and @galmicrosoft for review?

...cation/security/resource-manager/Microsoft.Security/preview/2017-08-01-preview/security.json

KrisBash

ARM comments appear to be addressed. Thanks

veronicagg · 2019-02-26T19:14:45Z

@dortibi

Please resolve branch conflicts.
The tag defined in the readme.md file "--tag=package-composite-v1" is composing "security.json" for 2 api versions, is that intentional on your end?
CI is failing on some SDK generation jobs, I'd like to see the results after conflicts are resolved.
In order to merge the PR, the APIs should be deployed, so SDKs generated out of it work for customers, please let us know when that happens.

Thanks!

# Conflicts: # specification/security/resource-manager/Microsoft.Security/preview/2017-08-01-preview/security.json

REST Spec PR 'Azure/azure-rest-api-specs#5234' REST Spec PR Author 'dortibi' REST Spec PR Last commit

veronicagg · 2019-03-18T17:23:47Z

@dortibi CI is looking good now. Please let know if you have more pending updates, and answers to my questions above. Thanks.

dortibi · 2019-03-26T11:00:03Z

Hi @veronicagg,
could you please remove the [Do not merge] and merge the PR?
This PR ready for merge.

veronicagg · 2019-03-26T22:57:18Z

@dortibi Have the APIs been deployed?
Also, the tag defined in the readme.md file "--tag=package-composite-v1" is composing "security.json" for 2 api versions, is that intentional on your end?

dortibi · 2019-03-28T09:58:11Z

Hi @veronicagg ,
Yes, the APIs deployed.
about the API versions, our team is not the owners of this resource provider. maybe @chlahav could answer you.
Anyway, this API spec should be merged since we announce this service today and the service deployed and ready.

Tibi Tibi added 8 commits January 21, 2019 12:50

Add security solution API

b8341bf

remove output.json

e8f5c2a

add location to the singular APIs.

c148d21

chnage the iotSecuritySolution schema

changing the APIs and examples

f6b9e2b

fixing indent 🤷🏿‍♂️

a2eafe1

fix autorest errors and warnings

2d96b57

fixing errors Open API Hub

e439fce

use 4 spaces indention instead of 2 spaces

d1c465e

AutorestCI mentioned this pull request Feb 20, 2019

[AutoPR security/resource-manager] Security: 2017-08-01-preview - Introduce IoT security solution resource Azure/azure-sdk-for-python#4394

Closed

AutorestCI mentioned this pull request Feb 20, 2019

[AutoPR security/resource-manager] Security: 2017-08-01-preview - Introduce IoT security solution resource Azure/azure-sdk-for-go#4109

Closed

AutorestCI mentioned this pull request Feb 20, 2019

[AutoPR security/resource-manager] Security: 2017-08-01-preview - Introduce IoT security solution resource Azure/azure-sdk-for-node#4711

Closed

azuresdkci assigned veronicagg Feb 20, 2019

azuresdkci requested a review from veronicagg February 20, 2019 11:02

fix description and add body to put

f22e2bf

veronicagg changed the title ~~Security: 2017-08-01-preview - Introduce IoT security solution resource~~ [Do not merge] Security: 2017-08-01-preview - Introduce IoT security solution resource Feb 20, 2019

veronicagg suggested changes Feb 20, 2019

View reviewed changes

veronicagg added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Feb 20, 2019

split the array and enums, and review of technical writer

cb701bb

AutorestCI mentioned this pull request Feb 24, 2019

[AutoPR security/resource-manager] [Do not merge] Security: 2017-08-01-preview - Introduce IoT security solution resource Azure/azure-sdk-for-node#4737

Closed

ravbhatnagar reviewed Feb 25, 2019

View reviewed changes

ravbhatnagar added the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Feb 25, 2019

change the resource name to lower camel case

e071426

KrisBash approved these changes Feb 26, 2019

View reviewed changes

KrisBash added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review labels Feb 26, 2019

KrisBash removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Feb 28, 2019

Merge branch 'master' of https://github.com/Azure/azure-rest-api-specs

d4e67b5

# Conflicts: # specification/security/resource-manager/Microsoft.Security/preview/2017-08-01-preview/security.json

adxsdknet added a commit to adxsdknet/azure-sdk-for-net that referenced this pull request Mar 10, 2019

.NET SDK Resource Provider:'SecurityCenter'

fdf44c1

REST Spec PR 'Azure/azure-rest-api-specs#5234' REST Spec PR Author 'dortibi' REST Spec PR Last commit

veronicagg changed the title ~~[Do not merge] Security: 2017-08-01-preview - Introduce IoT security solution resource~~ Security: 2017-08-01-preview - Introduce IoT security solution resource Mar 26, 2019

veronicagg approved these changes Mar 28, 2019

View reviewed changes

veronicagg merged commit 0791f29 into Azure:master Mar 28, 2019

AutorestCI mentioned this pull request Mar 28, 2019

[AutoPR security/resource-manager] Security: 2017-08-01-preview - Introduce IoT security solution resource Azure/azure-sdk-for-js#1834

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Security: 2017-08-01-preview - Introduce IoT security solution resource #5234

Security: 2017-08-01-preview - Introduce IoT security solution resource #5234

dortibi commented Feb 20, 2019

AutorestCI commented Feb 20, 2019 •

edited

Loading

AutorestCI commented Feb 20, 2019 •

edited

Loading

AutorestCI commented Feb 20, 2019 •

edited

Loading

AutorestCI commented Feb 20, 2019 •

edited

Loading

AutorestCI commented Feb 20, 2019 •

edited

Loading

AutorestCI commented Feb 20, 2019 •

edited

Loading

dortibi commented Feb 20, 2019

azuresdkci commented Feb 20, 2019

veronicagg left a comment

veronicagg commented Feb 20, 2019

dortibi commented Feb 24, 2019

KrisBash left a comment

veronicagg commented Feb 26, 2019

veronicagg commented Mar 18, 2019

dortibi commented Mar 26, 2019

veronicagg commented Mar 26, 2019

dortibi commented Mar 28, 2019

Security: 2017-08-01-preview - Introduce IoT security solution resource #5234

Security: 2017-08-01-preview - Introduce IoT security solution resource #5234

Conversation

dortibi commented Feb 20, 2019

Latest improvements:

Contribution checklist:

ARM API Review Checklist

AutorestCI commented Feb 20, 2019 • edited Loading

Automation for azure-sdk-for-ruby

AutorestCI commented Feb 20, 2019 • edited Loading

Automation for azure-sdk-for-python

AutorestCI commented Feb 20, 2019 • edited Loading

Automation for azure-sdk-for-java

AutorestCI commented Feb 20, 2019 • edited Loading

Automation for azure-sdk-for-js

AutorestCI commented Feb 20, 2019 • edited Loading

Automation for azure-sdk-for-go

AutorestCI commented Feb 20, 2019 • edited Loading

Automation for azure-sdk-for-node

dortibi commented Feb 20, 2019

azuresdkci commented Feb 20, 2019

veronicagg left a comment

Choose a reason for hiding this comment

veronicagg commented Feb 20, 2019

dortibi commented Feb 24, 2019

KrisBash left a comment

Choose a reason for hiding this comment

veronicagg commented Feb 26, 2019

veronicagg commented Mar 18, 2019

dortibi commented Mar 26, 2019

veronicagg commented Mar 26, 2019

dortibi commented Mar 28, 2019

AutorestCI commented Feb 20, 2019 •

edited

Loading

AutorestCI commented Feb 20, 2019 •

edited

Loading

AutorestCI commented Feb 20, 2019 •

edited

Loading

AutorestCI commented Feb 20, 2019 •

edited

Loading

AutorestCI commented Feb 20, 2019 •

edited

Loading

AutorestCI commented Feb 20, 2019 •

edited

Loading