upgrade api version for action group, add useUnifiedSchema field to a… #5257

kikicandy11 · 2019-02-23T00:35:45Z

…ctions

Also revert an incorrect change in RyanD1@39d45de that change the api-verion in readme.md file for existing packages

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.
The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

…ctions

AutorestCI · 2019-02-23T00:36:32Z

Automation for azure-sdk-for-python

Encountered an unknown error: (azure-sdk-for-python)

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 33, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 170, in rest_handle_action
    return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 185, in rest_pull_close
    rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
    sdk_tag=sdk_tag
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 254, in generate_sdk_from_git_object
    with manage_git_folder(gh_token, Path(temp_dir) / Path("rest"), branched_rest_api_id, pr_number=pr_number) as restapi_git_folder, \
  File "/usr/lib/python3.6/contextlib.py", line 81, in __enter__
    return next(self.gen)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 272, in manage_git_folder
    clone_to_path(gh_token, temp_dir, split_git_id[0], branch_or_commit=branch, pr_number=pr_number)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 212, in clone_to_path
    repo.git.checkout(branch_or_commit)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 548, in <lambda>
    return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 1014, in _call_process
    return self.execute(call, **exec_kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 825, in execute
    raise GitCommandError(command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(128)
  cmdline: git checkout e8f650325ba52f0cc16dcd83ace45c3567f896ec
  stderr: 'fatal: reference is not a tree: e8f650325ba52f0cc16dcd83ace45c3567f896ec'

AutorestCI · 2019-02-23T00:37:21Z

Automation for azure-sdk-for-ruby

Encountered an unknown error: (azure-sdk-for-ruby)

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 33, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 170, in rest_handle_action
    return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 185, in rest_pull_close
    rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
    sdk_tag=sdk_tag
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 254, in generate_sdk_from_git_object
    with manage_git_folder(gh_token, Path(temp_dir) / Path("rest"), branched_rest_api_id, pr_number=pr_number) as restapi_git_folder, \
  File "/usr/lib/python3.6/contextlib.py", line 81, in __enter__
    return next(self.gen)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 272, in manage_git_folder
    clone_to_path(gh_token, temp_dir, split_git_id[0], branch_or_commit=branch, pr_number=pr_number)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 212, in clone_to_path
    repo.git.checkout(branch_or_commit)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 548, in <lambda>
    return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 1014, in _call_process
    return self.execute(call, **exec_kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 825, in execute
    raise GitCommandError(command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(128)
  cmdline: git checkout e8f650325ba52f0cc16dcd83ace45c3567f896ec
  stderr: 'fatal: reference is not a tree: e8f650325ba52f0cc16dcd83ace45c3567f896ec'

AutorestCI · 2019-02-23T00:37:35Z

Automation for azure-sdk-for-js

Encountered an unknown error: (azure-sdk-for-js)

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 33, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 170, in rest_handle_action
    return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 185, in rest_pull_close
    rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
    sdk_tag=sdk_tag
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 254, in generate_sdk_from_git_object
    with manage_git_folder(gh_token, Path(temp_dir) / Path("rest"), branched_rest_api_id, pr_number=pr_number) as restapi_git_folder, \
  File "/usr/lib/python3.6/contextlib.py", line 81, in __enter__
    return next(self.gen)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 272, in manage_git_folder
    clone_to_path(gh_token, temp_dir, split_git_id[0], branch_or_commit=branch, pr_number=pr_number)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 212, in clone_to_path
    repo.git.checkout(branch_or_commit)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 548, in <lambda>
    return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 1014, in _call_process
    return self.execute(call, **exec_kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 825, in execute
    raise GitCommandError(command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(128)
  cmdline: git checkout e8f650325ba52f0cc16dcd83ace45c3567f896ec
  stderr: 'fatal: reference is not a tree: e8f650325ba52f0cc16dcd83ace45c3567f896ec'

AutorestCI · 2019-02-23T00:37:48Z

Automation for azure-sdk-for-java

Encountered an unknown error: (azure-sdk-for-java)

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 33, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 170, in rest_handle_action
    return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 185, in rest_pull_close
    rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
    sdk_tag=sdk_tag
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 254, in generate_sdk_from_git_object
    with manage_git_folder(gh_token, Path(temp_dir) / Path("rest"), branched_rest_api_id, pr_number=pr_number) as restapi_git_folder, \
  File "/usr/lib/python3.6/contextlib.py", line 81, in __enter__
    return next(self.gen)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 272, in manage_git_folder
    clone_to_path(gh_token, temp_dir, split_git_id[0], branch_or_commit=branch, pr_number=pr_number)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 212, in clone_to_path
    repo.git.checkout(branch_or_commit)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 548, in <lambda>
    return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 1014, in _call_process
    return self.execute(call, **exec_kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 825, in execute
    raise GitCommandError(command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(128)
  cmdline: git checkout e8f650325ba52f0cc16dcd83ace45c3567f896ec
  stderr: 'fatal: reference is not a tree: e8f650325ba52f0cc16dcd83ace45c3567f896ec'

AutorestCI · 2019-02-23T00:38:17Z

Automation for azure-sdk-for-node

Encountered an unknown error: (azure-sdk-for-node)

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 33, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 170, in rest_handle_action
    return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 185, in rest_pull_close
    rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
    sdk_tag=sdk_tag
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 254, in generate_sdk_from_git_object
    with manage_git_folder(gh_token, Path(temp_dir) / Path("rest"), branched_rest_api_id, pr_number=pr_number) as restapi_git_folder, \
  File "/usr/lib/python3.6/contextlib.py", line 81, in __enter__
    return next(self.gen)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 272, in manage_git_folder
    clone_to_path(gh_token, temp_dir, split_git_id[0], branch_or_commit=branch, pr_number=pr_number)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 212, in clone_to_path
    repo.git.checkout(branch_or_commit)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 548, in <lambda>
    return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 1014, in _call_process
    return self.execute(call, **exec_kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 825, in execute
    raise GitCommandError(command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(128)
  cmdline: git checkout e8f650325ba52f0cc16dcd83ace45c3567f896ec
  stderr: 'fatal: reference is not a tree: e8f650325ba52f0cc16dcd83ace45c3567f896ec'

AutorestCI · 2019-02-23T00:38:56Z

Automation for azure-sdk-for-go

Encountered an unknown error: (azure-sdk-for-go)

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 33, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 170, in rest_handle_action
    return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 185, in rest_pull_close
    rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
    sdk_tag=sdk_tag
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 254, in generate_sdk_from_git_object
    with manage_git_folder(gh_token, Path(temp_dir) / Path("rest"), branched_rest_api_id, pr_number=pr_number) as restapi_git_folder, \
  File "/usr/lib/python3.6/contextlib.py", line 81, in __enter__
    return next(self.gen)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 272, in manage_git_folder
    clone_to_path(gh_token, temp_dir, split_git_id[0], branch_or_commit=branch, pr_number=pr_number)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 212, in clone_to_path
    repo.git.checkout(branch_or_commit)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 548, in <lambda>
    return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 1014, in _call_process
    return self.execute(call, **exec_kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 825, in execute
    raise GitCommandError(command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(128)
  cmdline: git checkout e8f650325ba52f0cc16dcd83ace45c3567f896ec
  stderr: 'fatal: reference is not a tree: e8f650325ba52f0cc16dcd83ace45c3567f896ec'

azuresdkci · 2019-02-23T00:59:58Z

Can one of the admins verify this patch?

veronicagg

@kikicandy11 thanks for submitting the PR. It looks like you've copied a previous api-version and just updated a few things for the new api-version. If you're planning to make more changes, it'd be great to have one commit with the original spec you copied and another one with the changes so it's easier to see them. It's recommended to use our on-boarding experience OpenAPI Hub where you can indicate you'd like to create a new api version and it'll copy the files for you and make the api-version changes in the spec and examples too.

The change to the spec looks fine. Is this new API version already deployed?
Will you be adding the new spec and api-version to the readme.md file?

kikicandy11 · 2019-02-26T18:42:12Z

@veronicagg I don't plan to add more change to the new api-version, this PR includes all the changes.
The new API is not in PROD yet, it's code complete.
When should I add the new spec and api-version to the readme.md file?

veronicagg · 2019-02-26T18:51:14Z

@kikicandy11 It should be in this PR, generally when a new api-version gets introduced, a new tag in the readme.md file gets created with the files you'd ship in the SDK for that version. (BTW, OpenAPIHub would automatically have done this for you, and you could validate it's what you intended).
Please also edit each language readme.md file, you'll see the generated PRs for SDKs posted as messages in this PR.
In order to merge this PR, the APIs should be deployed, so that any SDK generated out of it, works for customers. If you need to request SDK releases, please see OpenAPI Hub - Request SDK release.
Thanks!

…0-01 to version 2019-03-01

…oft.Insights-2019-03-01 Dev applicationinsights microsoft.insights 2019 03 01

kikicandy11 · 2019-02-28T00:26:36Z

I merged some changes by mistake, will abandon the PR and create a new one

upgrade api version for action group, add useUnifiedSchema field to a…

6d78dc3

…ctions

AutorestCI mentioned this pull request Feb 23, 2019

[AutoPR monitor/resource-manager] upgrade api version for action group, add useUnifiedSchema field to a… Azure/azure-sdk-for-ruby#2258

Closed

AutorestCI mentioned this pull request Feb 23, 2019

[AutoPR monitor/resource-manager] upgrade api version for action group, add useUnifiedSchema field to a… Azure/azure-sdk-for-node#4735

Closed

AutorestCI mentioned this pull request Feb 23, 2019

[AutoPR monitor/resource-manager] upgrade api version for action group, add useUnifiedSchema field to a… Azure/azure-sdk-for-go#4129

Closed

azuresdkci assigned veronicagg Feb 23, 2019

azuresdkci requested a review from veronicagg February 23, 2019 00:59

fix format

62cb754

veronicagg suggested changes Feb 26, 2019

View reviewed changes

yuelilu33 added 4 commits February 27, 2019 16:03

Adds base for updating Microsoft.Insights from version preview/2017-1…

76eb940

…0-01 to version 2019-03-01

Updates readme

7f748f8

Updates API version in new specs and examples

03f088b

Merge pull request #1 from kikicandy11/dev-applicationinsights-Micros…

37e8d80

…oft.Insights-2019-03-01 Dev applicationinsights microsoft.insights 2019 03 01

AutorestCI mentioned this pull request Feb 28, 2019

[AutoPR monitor/resource-manager/applicationinsights/resource-manager] upgrade api version for action group, add useUnifiedSchema field to a… Azure/azure-sdk-for-ruby#2275

Closed

kikicandy11 closed this Feb 28, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

upgrade api version for action group, add useUnifiedSchema field to a… #5257

upgrade api version for action group, add useUnifiedSchema field to a… #5257

kikicandy11 commented Feb 23, 2019 •

edited

Loading

AutorestCI commented Feb 23, 2019 •

edited

Loading

AutorestCI commented Feb 23, 2019 •

edited

Loading

AutorestCI commented Feb 23, 2019 •

edited

Loading

AutorestCI commented Feb 23, 2019 •

edited

Loading

AutorestCI commented Feb 23, 2019 •

edited

Loading

AutorestCI commented Feb 23, 2019 •

edited

Loading

azuresdkci commented Feb 23, 2019

veronicagg left a comment

kikicandy11 commented Feb 26, 2019

veronicagg commented Feb 26, 2019 •

edited

Loading

kikicandy11 commented Feb 28, 2019

upgrade api version for action group, add useUnifiedSchema field to a… #5257

upgrade api version for action group, add useUnifiedSchema field to a… #5257

Conversation

kikicandy11 commented Feb 23, 2019 • edited Loading

Latest improvements:

Contribution checklist:

ARM API Review Checklist

AutorestCI commented Feb 23, 2019 • edited Loading

Automation for azure-sdk-for-python

AutorestCI commented Feb 23, 2019 • edited Loading

Automation for azure-sdk-for-ruby

AutorestCI commented Feb 23, 2019 • edited Loading

Automation for azure-sdk-for-js

AutorestCI commented Feb 23, 2019 • edited Loading

Automation for azure-sdk-for-java

AutorestCI commented Feb 23, 2019 • edited Loading

Automation for azure-sdk-for-node

AutorestCI commented Feb 23, 2019 • edited Loading

Automation for azure-sdk-for-go

azuresdkci commented Feb 23, 2019

veronicagg left a comment

Choose a reason for hiding this comment

kikicandy11 commented Feb 26, 2019

veronicagg commented Feb 26, 2019 • edited Loading

kikicandy11 commented Feb 28, 2019

kikicandy11 commented Feb 23, 2019 •

edited

Loading

AutorestCI commented Feb 23, 2019 •

edited

Loading

AutorestCI commented Feb 23, 2019 •

edited

Loading

AutorestCI commented Feb 23, 2019 •

edited

Loading

AutorestCI commented Feb 23, 2019 •

edited

Loading

AutorestCI commented Feb 23, 2019 •

edited

Loading

AutorestCI commented Feb 23, 2019 •

edited

Loading

veronicagg commented Feb 26, 2019 •

edited

Loading