Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add globalReachEnabled, Add Get and list for peer express route circuit connections. #5266

Merged
merged 3 commits into from
Mar 1, 2019
Merged

Add globalReachEnabled, Add Get and list for peer express route circuit connections. #5266

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4f75906
Added GlobalReachEnabled field. Added GET and List apis for peer expr…
syfarogh Feb 25, 2019
4c0bb1e
adding allow gloabl reach back
syfarogh Feb 26, 2019
7b7534a
fixed typo
syfarogh Feb 27, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion ...nager/Microsoft.Network/stable/2018-12-01/examples/ExpressRouteCircuitConnectionList.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
{
"parameters": {
"connectionName": "circuitConnectionUSAUS",
syfarogh marked this conversation as resolved.
Show resolved Hide resolved
"resourceGroupName": "rg1",
"api-version": "2018-12-01",
"subscriptionId": "subid1",
Expand Down
32 changes: 32 additions & 0 deletions ...er/Microsoft.Network/stable/2018-12-01/examples/PeerExpressRouteCircuitConnectionGet.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,32 @@
{
"parameters": {
"connectionName": "60aee347-e889-4a42-8c1b-0aae8b1e4013",
"resourceGroupName": "rg1",
"api-version": "2018-12-01",
"subscriptionId": "subid1",
"circuitName": "ExpressRouteARMCircuitA",
"peeringName": "AzurePrivatePeering"
},
"responses": {
"200": {
"body": {
"name": "60aee347-e889-4a42-8c1b-0aae8b1e4013",
"id": "/subscriptions/subid1/resourceGroups/rg1/providers/Microsoft.Network/expressRouteCircuits/ExpressRouteARMCircuitA/peerings/AzurePrivatePeering/peerConnections/60aee347-e889-4a42-8c1b-0aae8b1e4013",
"etag": "W/\"6ffbbb06-da20-44ca-a34f-280c4653b1e9\"",
"properties": {
"provisioningState": "Succeeded",
"expressRouteCircuitPeering": {
"id": "/subscriptions/subid1/resourceGroups/rg1/providers/Microsoft.Network/expressRouteCircuits/ExpressRouteARMCircuitA/peerings/AzurePrivatePeering"
},
"peerExpressRouteCircuitPeering": {
"id": "/subscriptions/subid1/resourceGroups/rg1/providers/Microsoft.Network/expressRouteCircuits/ExpressRouteARMCircuitB/peerings/AzurePrivatePeering"
},
"addressPrefix": "20.0.0.0/29",
"circuitConnectionStatus": "Connected",
"connectionName": "circuitConnectionWestusEastus",
"authResourceGuid": ""
syfarogh marked this conversation as resolved.
Show resolved Hide resolved
}
}
}
}
}
53 changes: 53 additions & 0 deletions ...r/Microsoft.Network/stable/2018-12-01/examples/PeerExpressRouteCircuitConnectionList.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,53 @@
{
"parameters": {
"resourceGroupName": "rg1",
"api-version": "2018-12-01",
"subscriptionId": "subid1",
"circuitName": "ExpressRouteARMCircuitA",
"peeringName": "AzurePrivatePeering"
},
"responses": {
"200": {
"body": {
"value": [
{
"name": "60aee347-e889-4a42-8c1b-0aae8b1e4013",
"id": "/subscriptions/subid1/resourceGroups/rg1/providers/Microsoft.Network/expressRouteCircuits/ExpressRouteARMCircuitA/peerings/AzurePrivatePeering/peerConnections/60aee347-e889-4a42-8c1b-0aae8b1e4013",
"etag": "W/\"6ffbbb06-da20-44ca-a34f-280c4653b1e9\"",
"properties": {
"provisioningState": "Succeeded",
"expressRouteCircuitPeering": {
"id": "/subscriptions/subid1/resourceGroups/rg1/providers/Microsoft.Network/expressRouteCircuits/ExpressRouteARMCircuitA/peerings/AzurePrivatePeering"
},
"peerExpressRouteCircuitPeering": {
"id": "/subscriptions/subid1/resourceGroups/rg1/providers/Microsoft.Network/expressRouteCircuits/ExpressRouteARMCircuitB/peerings/AzurePrivatePeering"
},
"addressPrefix": "20.0.0.0/29",
"circuitConnectionStatus": "Connected",
"connectionName": "circuitConnectionWestusEastus",
"authResourceGuid": ""
}
},
{
"name": "c8b17193-8dd3-4f61-866d-8cdd2e2e268e",
"id": "/subscriptions/subid1/resourceGroups/rg1/providers/Microsoft.Network/expressRouteCircuits/ExpressRouteARMCircuitA/peerings/AzurePrivatePeering/peerConnections/c8b17193-8dd3-4f61-866d-8cdd2e2e268e",
"etag": "W/\"6ffbbb06-da20-44ca-a34f-280c4653b1e9\"",
"properties": {
"provisioningState": "Succeeded",
"expressRouteCircuitPeering": {
"id": "/subscriptions/subid1/resourceGroups/rg1/providers/Microsoft.Network/expressRouteCircuits/ExpressRouteARMCircuitA/peerings/AzurePrivatePeering"
},
"peerExpressRouteCircuitPeering": {
"id": "/subscriptions/subid2/resourceGroups/rg1/providers/Microsoft.Network/expressRouteCircuits/ExpressRouteARMCircuitC/peerings/AzurePrivatePeering"
},
"addressPrefix": "30.0.0.0/29",
"circuitConnectionStatus": "Connected",
"connectionName": "circuitConnectionCentralusEastus",
"authResourceGuid": "64283012-d377-421d-8398-f6aeb2ac7ea0"
}
}
]
}
}
}
}
204 changes: 204 additions & 0 deletions ...ion/network/resource-manager/Microsoft.Network/stable/2018-12-01/expressRouteCircuit.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -690,6 +690,116 @@
}
}
},
"/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Network/expressRouteCircuits/{circuitName}/peerings/{peeringName}/peerConnections/{connectionName}": {
"get": {
"tags": [
"PeerExpressRouteCircuitConnections"
],
"operationId": "PeerExpressRouteCircuitConnections_Get",
"description": "Gets the specified Peer Express Route Circuit Connection from the specified express route circuit.",
"parameters": [
{
"name": "resourceGroupName",
"in": "path",
"required": true,
"type": "string",
"description": "The name of the resource group."
},
{
"name": "circuitName",
"in": "path",
"required": true,
"type": "string",
"description": "The name of the express route circuit."
},
{
"name": "peeringName",
"in": "path",
"required": true,
"type": "string",
"description": "The name of the peering."
},
{
"name": "connectionName",
"in": "path",
"required": true,
"type": "string",
"description": "The name of the peer express route circuit connection."
},
{
"$ref": "./network.json#/parameters/ApiVersionParameter"
},
{
"$ref": "./network.json#/parameters/SubscriptionIdParameter"
}
],
"responses": {
"200": {
"description": "Request successful. The operation returns the resulting Peer Express Route Circuit Connection resource.",
"schema": {
"$ref": "#/definitions/PeerExpressRouteCircuitConnection"
}
}
},
"x-ms-examples": {
"PeerExpressRouteCircuitConnectionGet": {
"$ref": "./examples/PeerExpressRouteCircuitConnectionGet.json"
}
}
}
},
"/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Network/expressRouteCircuits/{circuitName}/peerings/{peeringName}/peerConnections": {
"get": {
"tags": [
"PeerExpressRouteCircuitConnections"
],
"operationId": "PeerExpressRouteCircuitConnections_List",
syfarogh marked this conversation as resolved.
Show resolved Hide resolved
"description": "Gets all global reach peer connections associated with a private peering in an express route circuit.",
"parameters": [
{
"name": "resourceGroupName",
"in": "path",
"required": true,
"type": "string",
"description": "The name of the resource group."
},
{
"name": "circuitName",
"in": "path",
"required": true,
"type": "string",
"description": "The name of the circuit."
},
{
"name": "peeringName",
"in": "path",
"required": true,
"type": "string",
"description": "The name of the peering."
},
{
"$ref": "./network.json#/parameters/ApiVersionParameter"
},
{
"$ref": "./network.json#/parameters/SubscriptionIdParameter"
}
],
"responses": {
"200": {
"description": "Request successful. The operation returns a list of PeerExpressRouteCircuitConnections resources.",
"schema": {
"$ref": "#/definitions/PeerExpressRouteCircuitConnectionListResult"
}
}
},
"x-ms-pageable": {
"nextLinkName": "nextLink"
},
"x-ms-examples": {
"List Peer ExpressRouteCircuit Connection": { "$ref": "./examples/PeerExpressRouteCircuitConnectionList.json" }
}
}
},
"/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Network/expressRouteCircuits/{circuitName}": {
"delete": {
"tags": [
Expand Down Expand Up @@ -1510,6 +1620,14 @@
"$ref": "#/definitions/ExpressRouteCircuitConnection"
},
"description": "The list of circuit connections associated with Azure Private Peering for this circuit."
},
"peeredConnections": {
"type": "array",
"items": {
"$ref": "#/definitions/PeerExpressRouteCircuitConnection"
},
"readOnly": true,
"description": "The list of peered circuit connections associated with Azure Private Peering for this circuit."
}
}
},
Expand Down Expand Up @@ -1655,6 +1773,88 @@
},
"description": "Response for ListConnections API service call retrieves all global reach connections that belongs to a Private Peering for an ExpressRouteCircuit."
},
"PeerExpressRouteCircuitConnectionPropertiesFormat": {
"properties": {
"expressRouteCircuitPeering": {
"$ref": "./network.json#/definitions/SubResource",
"description": "Reference to Express Route Circuit Private Peering Resource of the circuit."
},
"peerExpressRouteCircuitPeering": {
"$ref": "./network.json#/definitions/SubResource",
"description": "Reference to Express Route Circuit Private Peering Resource of the peered circuit."
},
"addressPrefix": {
"type": "string",
"description": "/29 IP address space to carve out Customer addresses for tunnels."
},
"circuitConnectionStatus": {
"type": "string",
"description": "Express Route Circuit Connection State. Possible values are: 'Connected' and 'Disconnected'.",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit - the description lists two possible values while the enum describes three.

"enum": [
"Connected",
"Connecting",
"Disconnected"
],
"readOnly": true,
"x-ms-enum": {
"name": "circuitConnectionStatus",
"modelAsString": true
}
},
"connectionName": {
"type": "string",
"description": "The name of the express route circuit connection resource."
},
"authResourceGuid": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For my information, is this sensitive information?

"type": "string",
"description": "The resource guid of the authorization used for the express route circuit connection."
},
"provisioningState": {
"type": "string",
"readOnly": true,
"description": "Provisioning state of the peer express route circuit connection resource. Possible values are: 'Succeeded', 'Updating', 'Deleting', and 'Failed'."
}
}
},
"PeerExpressRouteCircuitConnection": {
"properties": {
"properties": {
"x-ms-client-flatten": true,
"$ref": "#/definitions/PeerExpressRouteCircuitConnectionPropertiesFormat"
},
"name": {
"type": "string",
"description": "Gets name of the resource that is unique within a resource group. This name can be used to access the resource."
},
"etag": {
"readOnly": true,
"type": "string",
"description": "A unique read-only string that changes whenever the resource is updated."
}
},
"allOf": [
{
"$ref": "./network.json#/definitions/SubResource"
}
],
"description": "Peer Express Route Circuit Connection in an ExpressRouteCircuitPeering resource."
},
"PeerExpressRouteCircuitConnectionListResult": {
"properties": {
"value": {
"type": "array",
"items": {
"$ref": "#/definitions/PeerExpressRouteCircuitConnection"
},
"description": "The global reach peer circuit connection associated with Private Peering in an ExpressRoute Circuit."
},
"nextLink": {
"type": "string",
"description": "The URL to get the next set of results."
}
},
"description": "Response for ListPeeredConnections API service call retrieves all global reach peer circuit connections that belongs to a Private Peering for an ExpressRouteCircuit."
},
"ExpressRouteCircuitSku": {
"properties": {
"name": {
Expand Down Expand Up @@ -1782,6 +1982,10 @@
"allowGlobalReach": {
"type": "boolean",
"description": "Flag to enable Global Reach on the circuit."
},
"globalReachEnabled": {
syfarogh marked this conversation as resolved.
Show resolved Hide resolved
"type": "boolean",
"description": "Flag denoting Global reach status."
}
},
"description": "Properties of ExpressRouteCircuit."
Expand Down