Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Azure DevOps time outs and display names. #5273

Merged
merged 3 commits into from
Feb 26, 2019
Merged

Conversation

sergey-shandar
Copy link
Contributor

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@AutorestCI
Copy link

AutorestCI commented Feb 26, 2019

Automation for azure-sdk-for-python

Unable to detect any generation context from this PR.

@AutorestCI
Copy link

AutorestCI commented Feb 26, 2019

Automation for azure-sdk-for-go

Unable to detect any generation context from this PR.

@AutorestCI
Copy link

AutorestCI commented Feb 26, 2019

Automation for azure-sdk-for-node

Unable to detect any generation context from this PR.

@AutorestCI
Copy link

AutorestCI commented Feb 26, 2019

Automation for azure-sdk-for-js

Unable to detect any generation context from this PR.

@AutorestCI
Copy link

AutorestCI commented Feb 26, 2019

Automation for azure-sdk-for-java

Unable to detect any generation context from this PR.

@AutorestCI
Copy link

AutorestCI commented Feb 26, 2019

Automation for azure-sdk-for-ruby

Unable to detect any generation context from this PR.

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?


- job: "SDK"
timeoutInMinutes: 120

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh wow, just curious is there a sample of something that comes even close to 2 hours ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, Network #5266

Copy link
Contributor

@veronicagg veronicagg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sergey-shandar sergey-shandar merged commit b1de6f7 into master Feb 26, 2019
@sergey-shandar sergey-shandar deleted the sergey/timeout branch February 26, 2019 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants