Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update UserAssignedIdentities spec in Web #5288

Merged
merged 2 commits into from
Mar 4, 2019

Commits on Feb 27, 2019

  1. Update UserAssignedIdentities spec in Web

    Microsoft.Web recently added support for UserAssigned managed service identities (in preview), but the swagger spec is incorrect for the identity payload as it follows the old construct of sending an array of identityIds as opposed to the updated spec which instead sends a dictionary object called userAssignedIdentities. 
    
    Spec + history outlined here:
    http://sharepoint/sites/AzureUX/Sparta/_layouts/15/WopiFrame2.aspx?sourcedoc=%7b633632B4-02E4-4DE2-92A9-EDCAF9BE73D4%7d&file=ARM%2BMSI.docx&action=default 
    
    Our swagger contains identityids[] because of previous work to future support UserAssigned identities, but never released the feature in that state, rather we opted to wait for the new spec to be supported and then integrated with that on our end. 
    
    Our MSI implementation reflects Microsoft.Compute's spec for user assigned.
    
    https://github.com/Azure/azure-rest-api-specs/blob/78e1feab142c605839aa3cec23442ca26b8ef04d/specification/compute/resource-manager/Microsoft.Compute/stable/2018-06-01/compute.json
    Hamster-Huey authored Feb 27, 2019
    Configuration menu
    Copy the full SHA
    c2d7ae7 View commit details
    Browse the repository at this point in the history

Commits on Feb 28, 2019

  1. fix linterdiff tool

    sergey-shandar committed Feb 28, 2019
    Configuration menu
    Copy the full SHA
    28eed48 View commit details
    Browse the repository at this point in the history