Azure Search: Resource Manager: Support 'None' Identity type #5319
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,81 @@ | ||
| { | ||
| "parameters": { | ||
| "searchServiceName": "mysearchservice", | ||
| "resourceGroupName": "rg1", | ||
| "api-version": "2015-08-19", | ||
| "subscriptionId": "subid", | ||
| "service": { | ||
| "location": "westus", | ||
| "tags": { | ||
| "app-name": "My e-commerce app" | ||
| }, | ||
| "sku": { | ||
| "name": "standard" | ||
| }, | ||
| "properties": { | ||
| "replicaCount": 3, | ||
| "partitionCount": 1, | ||
| "hostingMode": "default" | ||
| }, | ||
| "identity": { | ||
| "type": "SystemAssigned" | ||
| } | ||
| } | ||
| }, | ||
| "responses": { | ||
| "200": { | ||
| "body": { | ||
| "id": "/subscriptions/subid/resourceGroups/rg1/providers/Microsoft.Search/searchServices/mysearchservice", | ||
| "name": "mysearchservice", | ||
| "location": "westus", | ||
| "type": "Microsoft.Search/searchServices", | ||
| "tags": { | ||
| "app-name": "My e-commerce app" | ||
| }, | ||
| "sku": { | ||
| "name": "standard" | ||
| }, | ||
| "properties":{ | ||
| "replicaCount": 3, | ||
| "partitionCount": 1, | ||
| "status": "provisioning", | ||
| "statusDetails": "", | ||
| "hostingMode": "default", | ||
| "provisioningState": "provisioning" | ||
| }, | ||
| "identity": { | ||
| "type": "SystemAssigned", | ||
| "principalId": "9d1e1f18-2122-4988-a11c-878782e40a5c", | ||
| "tenantId": "f686d426-8d16-42db-81b7-ab578e110ccd" | ||
| } | ||
| } | ||
| }, | ||
| "201": { | ||
| "body": { | ||
| "id": "/subscriptions/subid/resourceGroups/rg1/providers/Microsoft.Search/searchServices/mysearchservice", | ||
| "name": "mysearchservice", | ||
| "location": "westus", | ||
| "type": "Microsoft.Search/searchServices", | ||
| "tags": { | ||
| "app-name": "My e-commerce app" | ||
| }, | ||
| "sku": { | ||
| "name": "standard" | ||
| }, | ||
| "properties":{ | ||
| "replicaCount": 3, | ||
| "partitionCount": 1, | ||
| "status": "provisioning", | ||
| "statusDetails": "", | ||
| "hostingMode": "default", | ||
| "provisioningState": "provisioning" | ||
| }, | ||
| "identity": { | ||
| "type": "SystemAssigned", | ||
| "principalId": "9d1e1f18-2122-4988-a11c-878782e40a5c", | ||
| "tenantId": "f686d426-8d16-42db-81b7-ab578e110ccd" | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,42 @@ | ||
| { | ||
| "parameters": { | ||
| "searchServiceName": "mysearchservice", | ||
| "resourceGroupName": "rg1", | ||
| "api-version": "2015-08-19", | ||
| "subscriptionId": "subid", | ||
| "service": { | ||
| "sku": { | ||
| "name": "standard" | ||
| }, | ||
| "identity": { | ||
| "type": "None" | ||
| } | ||
| } | ||
| }, | ||
| "responses": { | ||
| "200": { | ||
| "body": { | ||
| "id": "/subscriptions/subid/resourceGroups/rg1/providers/Microsoft.Search/searchServices/mysearchservice", | ||
| "name": "mysearchservice", | ||
| "location": "westus", | ||
| "type": "Microsoft.Search/searchServices", | ||
| "tags": { | ||
| }, | ||
| "sku": { | ||
| "name": "standard" | ||
| }, | ||
| "properties":{ | ||
| "replicaCount": 3, | ||
| "partitionCount": 1, | ||
| "status": "running", | ||
| "statusDetails": "", | ||
| "hostingMode": "default", | ||
| "provisioningState": "succeeded" | ||
| }, | ||
| "identity": { | ||
| "type": "None" | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -331,7 +331,8 @@ | |
| ], | ||
| "operationId": "Services_CreateOrUpdate", | ||
| "x-ms-examples": { | ||
| "SearchCreateOrUpdateService": { "$ref": "./examples/SearchCreateOrUpdateService.json" }, | ||
| "SearchCreateOrUpdateServiceWithIdentity": { "$ref": "./examples/SearchCreateOrUpdateServiceWithIdentity.json" } | ||
| }, | ||
| "description": "Creates or updates a Search service in the given resource group. If the Search service already exists, all properties will be updated with the given values.", | ||
| "externalDocs": { | ||
|
|
@@ -395,7 +396,8 @@ | |
| ], | ||
| "operationId": "Services_Update", | ||
| "x-ms-examples": { | ||
| "SearchUpdateService": { "$ref": "./examples/SearchUpdateService.json" }, | ||
| "SearchUpdateServiceToRemoveIdentity": { "$ref": "./examples/SearchUpdateServiceToRemoveIdentity.json" } | ||
| }, | ||
| "description": "Updates an existing Search service in the given resource group.", | ||
| "externalDocs": { | ||
|
|
@@ -1064,6 +1066,7 @@ | |
| "type": "string", | ||
| "description": "The identity type.", | ||
| "enum": [ | ||
| "None", | ||
|
There was a problem hiding this comment. @natinimni Adding a new enum value is a client-side breaking change, so make sure to bump the major version of the .NET Management SDK. There was a problem hiding this comment. It also wouldn't hurt to ensure there's an example of using this value. There was a problem hiding this comment. thanks @brjohnstmsft ! |
||
| "SystemAssigned" | ||
| ], | ||
| "x-ms-enum": { | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@natinimni I trust these are not real IDs. :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The 'tenantId' is real, but public. The 'principalId' is not real, and not considered a secret :)