Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated property from VMScaleSetVM properties #5347

Merged
merged 1 commit into from
Mar 27, 2019
Merged

Remove deprecated property from VMScaleSetVM properties #5347

merged 1 commit into from
Mar 27, 2019

Conversation

ashintre
Copy link
Member

@ashintre ashintre commented Mar 8, 2019 •
edited
Loading

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@AutorestCI
Copy link

AutorestCI commented Mar 8, 2019 •
edited
Loading

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

@AutorestCI AutorestCI mentioned this pull request Mar 8, 2019
Closed
@AutorestCI
Copy link

AutorestCI commented Mar 8, 2019 •
edited
Loading

Automation for azure-sdk-for-js

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-js#1819

@AutorestCI AutorestCI mentioned this pull request Mar 8, 2019
Merged
@AutorestCI
Copy link

AutorestCI commented Mar 8, 2019 •
edited
Loading

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#4151

adxsdknet added a commit to adxsdknet/azure-sdk-for-net that referenced this pull request Mar 8, 2019
@adxsdknet
.NET SDK Resource Provider:'Compute'
4f87b96 
REST Spec PR 'Azure/azure-rest-api-specs#5347'
REST Spec PR Author 'ashintre'
REST Spec PR Last commit
@AutorestCI AutorestCI mentioned this pull request Mar 8, 2019
Merged
@AutorestCI
Copy link

AutorestCI commented Mar 8, 2019 •
edited
Loading

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#4406

@AutorestCI
Copy link

AutorestCI commented Mar 8, 2019 •
edited
Loading

Automation for azure-sdk-for-java

Nothing to generate for azure-sdk-for-java

@AutorestCI AutorestCI mentioned this pull request Mar 8, 2019
Closed
@AutorestCI
Copy link

AutorestCI commented Mar 8, 2019 •
edited
Loading

Automation for azure-sdk-for-node

A PR has been created for you:
Azure/azure-sdk-for-node#4847

@anuchandy anuchandy added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Mar 10, 2019
anuchandy
anuchandy reviewed Mar 10, 2019
View reviewed changes
Copy link
Member

@anuchandy anuchandy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ravbhatnagar PR removes a deprecated property from stable API Version. Could you review?

specification/compute/resource-manager/Microsoft.Compute/stable/2018-10-01/compute.json Show resolved Hide resolved
@sanjaiganesh sanjaiganesh added the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Mar 12, 2019
@ravbhatnagar
Copy link
Contributor

@ashintre - can you please confirm service behavior if this property is used as currently modeled in swagger. If it is going to fail on service side, then I am fine approving this PR even though its a breaking change. But since it would never have worked before, we should be fine making this change. Please confirm.

@anthony-c-martin anthony-c-martin added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Mar 22, 2019
@anuchandy
Copy link
Member

Response from @ashintre : "Yes, it would fail on the service side. Luckily, when I checked a week ago, our data showed no one had attempted to use it thus far"

@anuchandy anuchandy merged commit 09e04e7 into Azure:master Mar 27, 2019
@AutorestCI AutorestCI mentioned this pull request Mar 27, 2019
Merged
dsgouda pushed a commit to Azure/azure-sdk-for-net that referenced this pull request Mar 29, 2019
@adxsdknet @dsgouda
.NET SDK Resource Provider:'Compute' (#5346)
3582410 
REST Spec PR 'Azure/azure-rest-api-specs#5347'
REST Spec PR Author 'ashintre'
REST Spec PR Last commit
mentat9 pushed a commit to mentat9/azure-sdk-for-net that referenced this pull request Jun 10, 2019
@adxsdknet @mentat9
.NET SDK Resource Provider:'Compute' (Azure#5346)
c86b116 
REST Spec PR 'Azure/azure-rest-api-specs#5347'
REST Spec PR Author 'ashintre'
REST Spec PR Last commit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanjaiganesh sanjaiganesh sanjaiganesh left review comments

@anuchandy anuchandy anuchandy approved these changes

@anthony-c-martin anthony-c-martin anthony-c-martin approved these changes

Assignees

@anuchandy anuchandy

@ravbhatnagar ravbhatnagar

Labels
ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review potential-sdk-breaking-change WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@ashintre @azuresdkci @AutorestCI @ravbhatnagar @anuchandy @sanjaiganesh @anthony-c-martin