-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Small correction to list handling #5446
Conversation
NFSAAS-1505 minor update and validation fixes
Put (and patch) for snapshots. Service level definition changes.
NFSAAS-1505 bring in line with RP
NFSAAS-1505 correct resource reference and limits
Incorrect pool resource reference Name elements of property not required Correction to return status code
NFSAAS-1505 resource and property changes
NFSAAS-1505 status codes
NFSAAS-1505 tidy up examples
NFSAAS-1505 tidy up examples
NFSAAS-1644 remove mt get and add put status code
NFSAAS-1644 remove mt get add status for put
NFSAAS-1875 update to R3.5 standard
* NFSAAS-1875 Update to R3.5 Standard * NFSAAS-1875 update to R3.5 standard
* NFSAAS-1875 Update to R3.5 Standard * NFSAAS-1875 update to R3.5 standard * NFSAAS-1875 updated from review comments
Merging to fork from azure master
NFSAAS-1875 small correction
Automation for azure-sdk-for-pythonThe initial PR has been merged into your service PR: |
Automation for azure-sdk-for-goThe initial PR has been merged into your service PR: |
Automation for azure-sdk-for-rubyNothing to generate for azure-sdk-for-ruby |
Can one of the admins verify this patch? |
REST Spec PR 'Azure/azure-rest-api-specs#5446' REST Spec PR Author 'leonardbf' REST Spec PR Last commit
Automation for azure-sdk-for-netA PR has been created for you: |
REST Spec PR 'Azure/azure-rest-api-specs#5446' REST Spec PR Author 'leonardbf' REST Spec PR Last commit
This is just a small change and a quick turn around would be really appreciated. Many thanks. |
Automation for azure-sdk-for-jsA PR has been created for you based on this PR content. Once this PR will be merged, content will be added to your service PR: |
@leonardbf could you clean up the commit history here (git rebase -i) |
Automation for azure-sdk-for-javaNothing to generate for azure-sdk-for-java |
Thanks for a quick response. Can you give me the full steps for this? Do you mean simply clone my master branch, perform git rebase -i then push back to master? Note this commit history is from earlier commits that have already been merged. This last change was a single commit - does that make a difference? If not then I could perform this squash on my next commit. I was hoping this one could be merged quickly so the SDKs can be generated as soon as possible. |
@leonardbf pull from latest Azure master to your master, if this doesn't work you can simply clone Azure master and copy over your changes in a new branch (hacky and you can skip if it's too much work) |
Hmm, this was actually a clean branch that I pushed from a newly cloned repo. I did it that way because there were merge conflicts. I'm not really sure why this commit history is here. @dsgouda Is this a blocker? While I understand the interest in a clean commit history, it's like you say, trying to sort it can be more effort than it's worth especially when time is short. |
@dsgouda hey, I see you tried to contact me on the devex teams channel. I've noticed previously that this is only accessible to me on my SAW machine which is in the office. Teams on my development laptop does not show this channel even when clicking through from the email to my b- account you triggered in Teams (I'm assuming you are on Pacific Time but I'm on UTC in Iceland and won't be in the office for 8 hours or so). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Still preview - breaking changes not an issue
Latest improvements:
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
ARM API Review Checklist
Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.
Please follow the link to find more details on API review process.