Add IOT central app templates api in swagger #5494

kawayiboy · 2019-03-27T23:01:44Z

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.
The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

AutorestCI · 2019-03-27T23:02:31Z

Automation for azure-sdk-for-python

Encountered an unknown error: (azure-sdk-for-python)

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 33, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 170, in rest_handle_action
    return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 185, in rest_pull_close
    rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
    sdk_tag=sdk_tag
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 254, in generate_sdk_from_git_object
    with manage_git_folder(gh_token, Path(temp_dir) / Path("rest"), branched_rest_api_id, pr_number=pr_number) as restapi_git_folder, \
  File "/usr/lib/python3.6/contextlib.py", line 81, in __enter__
    return next(self.gen)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 272, in manage_git_folder
    clone_to_path(gh_token, temp_dir, split_git_id[0], branch_or_commit=branch, pr_number=pr_number)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 212, in clone_to_path
    repo.git.checkout(branch_or_commit)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 548, in <lambda>
    return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 1014, in _call_process
    return self.execute(call, **exec_kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 825, in execute
    raise GitCommandError(command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(128)
  cmdline: git checkout c56187501e6a4ccdd065dec4a854abcc47fc5d66
  stderr: 'fatal: reference is not a tree: c56187501e6a4ccdd065dec4a854abcc47fc5d66'

AutorestCI · 2019-03-27T23:02:49Z

Automation for azure-sdk-for-js

A PR has been created for you:
Azure/azure-sdk-for-js#1822

AutorestCI · 2019-03-27T23:03:12Z

Automation for azure-sdk-for-ruby

A PR has been created for you:
Azure/azure-sdk-for-ruby#2367

AutorestCI · 2019-03-27T23:04:03Z

Automation for azure-sdk-for-java

A PR has been created for you:
Azure/azure-sdk-for-java#3238

AutorestCI · 2019-03-27T23:04:15Z

Automation for azure-sdk-for-go

Encountered an unknown error: (azure-sdk-for-go)

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 33, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 170, in rest_handle_action
    return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 185, in rest_pull_close
    rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
    sdk_tag=sdk_tag
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 254, in generate_sdk_from_git_object
    with manage_git_folder(gh_token, Path(temp_dir) / Path("rest"), branched_rest_api_id, pr_number=pr_number) as restapi_git_folder, \
  File "/usr/lib/python3.6/contextlib.py", line 81, in __enter__
    return next(self.gen)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 272, in manage_git_folder
    clone_to_path(gh_token, temp_dir, split_git_id[0], branch_or_commit=branch, pr_number=pr_number)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 212, in clone_to_path
    repo.git.checkout(branch_or_commit)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 548, in <lambda>
    return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 1014, in _call_process
    return self.execute(call, **exec_kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 825, in execute
    raise GitCommandError(command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(128)
  cmdline: git checkout c56187501e6a4ccdd065dec4a854abcc47fc5d66
  stderr: 'fatal: reference is not a tree: c56187501e6a4ccdd065dec4a854abcc47fc5d66'

azuresdkci · 2019-03-27T23:20:16Z

Can one of the admins verify this patch?

REST Spec PR 'Azure/azure-rest-api-specs#5494' REST Spec PR Author 'kawayiboy' REST Spec PR Last commit

...ification/iotcentral/resource-manager/Microsoft.IoTCentral/stable/2018-09-01/iotcentral.json

majastrz

Can you take a look at comments and add the missing route?

dsgouda · 2019-04-17T22:25:17Z

startbuild

REST Spec PR 'Azure/azure-rest-api-specs#5494' REST Spec PR Author 'kawayiboy' REST Spec PR Last commit

adxsdknet · 2019-04-17T22:34:15Z

Automation for azure-sdk-for-net

A PR has been created for you:
Azure/azure-sdk-for-net#5854
.NET SDK Commits:
adxsdknet/azure-sdk-for-net@2d0a035

ravbhatnagar · 2019-05-15T17:47:05Z

@kawayiboy can we close this PR if its not needed? It creates unnecessary noise for reviewers.

ravbhatnagar · 2019-05-15T17:48:40Z

Looks like this PR is not needed and the new PR has already been merged #5495. Removing ARMlabel on this one @sarangan12 please close this one.

sarangan12 · 2019-07-24T17:45:24Z

Closing this PR based on @ravbhatnagar last comment

Add IOT central app templates api in swagger

9f906f3

AutorestCI mentioned this pull request Mar 27, 2019

[AutoPR iotcentral/resource-manager] Add IOT central app templates api in swagger Azure/azure-sdk-for-python#4704

Closed

AutorestCI mentioned this pull request Mar 27, 2019

[AutoPR iotcentral/resource-manager] Add IOT central app templates api in swagger Azure/azure-sdk-for-js#1822

Closed

AutorestCI mentioned this pull request Mar 27, 2019

[AutoPR iotcentral/resource-manager] Add IOT central app templates api in swagger Azure/azure-sdk-for-ruby#2367

Closed

azuresdkci assigned sarangan12 Mar 27, 2019

azuresdkci requested a review from sarangan12 March 27, 2019 23:03

AutorestCI mentioned this pull request Mar 27, 2019

[AutoPR iotcentral/resource-manager] Add IOT central app templates api in swagger Azure/azure-sdk-for-java#3238

Closed

AutorestCI mentioned this pull request Mar 27, 2019

[AutoPR iotcentral/resource-manager] Add IOT central app templates api in swagger Azure/azure-sdk-for-go#4409

Closed

adxsdknet added a commit to adxsdknet/azure-sdk-for-net that referenced this pull request Mar 27, 2019

.NET SDK Resource Provider:'IotCentral'

f62850f

REST Spec PR 'Azure/azure-rest-api-specs#5494' REST Spec PR Author 'kawayiboy' REST Spec PR Last commit

kawayiboy requested a review from majastrz March 28, 2019 18:55

kawayiboy assigned majastrz and unassigned sarangan12 Mar 28, 2019

majastrz added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Mar 29, 2019

majastrz reviewed Mar 29, 2019

View reviewed changes

...ification/iotcentral/resource-manager/Microsoft.IoTCentral/stable/2018-09-01/iotcentral.json Show resolved Hide resolved

majastrz reviewed Mar 29, 2019

View reviewed changes

...ification/iotcentral/resource-manager/Microsoft.IoTCentral/stable/2018-09-01/iotcentral.json Show resolved Hide resolved

majastrz reviewed Mar 29, 2019

View reviewed changes

...ification/iotcentral/resource-manager/Microsoft.IoTCentral/stable/2018-09-01/iotcentral.json Show resolved Hide resolved

majastrz requested changes Mar 29, 2019

View reviewed changes

Azure deleted a comment from adxsdknet Apr 17, 2019

adxsdknet added a commit to adxsdknet/azure-sdk-for-net that referenced this pull request Apr 17, 2019

.NET SDK Resource Provider:'IotCentral'

2d0a035

REST Spec PR 'Azure/azure-rest-api-specs#5494' REST Spec PR Author 'kawayiboy' REST Spec PR Last commit

ravbhatnagar removed the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label May 15, 2019

sarangan12 closed this Jul 24, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add IOT central app templates api in swagger #5494

Add IOT central app templates api in swagger #5494

kawayiboy commented Mar 27, 2019

AutorestCI commented Mar 27, 2019 •

edited

Loading

AutorestCI commented Mar 27, 2019 •

edited

Loading

AutorestCI commented Mar 27, 2019 •

edited

Loading

AutorestCI commented Mar 27, 2019 •

edited

Loading

AutorestCI commented Mar 27, 2019 •

edited

Loading

azuresdkci commented Mar 27, 2019

majastrz left a comment

dsgouda commented Apr 17, 2019

adxsdknet commented Apr 17, 2019

ravbhatnagar commented May 15, 2019

ravbhatnagar commented May 15, 2019

sarangan12 commented Jul 24, 2019

Add IOT central app templates api in swagger #5494

Add IOT central app templates api in swagger #5494

Conversation

kawayiboy commented Mar 27, 2019

Latest improvements:

Contribution checklist:

ARM API Review Checklist

AutorestCI commented Mar 27, 2019 • edited Loading

Automation for azure-sdk-for-python

AutorestCI commented Mar 27, 2019 • edited Loading

Automation for azure-sdk-for-js

AutorestCI commented Mar 27, 2019 • edited Loading

Automation for azure-sdk-for-ruby

AutorestCI commented Mar 27, 2019 • edited Loading

Automation for azure-sdk-for-java

AutorestCI commented Mar 27, 2019 • edited Loading

Automation for azure-sdk-for-go

azuresdkci commented Mar 27, 2019

majastrz left a comment

Choose a reason for hiding this comment

dsgouda commented Apr 17, 2019

adxsdknet commented Apr 17, 2019

Automation for azure-sdk-for-net

ravbhatnagar commented May 15, 2019

ravbhatnagar commented May 15, 2019

sarangan12 commented Jul 24, 2019

AutorestCI commented Mar 27, 2019 •

edited

Loading

AutorestCI commented Mar 27, 2019 •

edited

Loading

AutorestCI commented Mar 27, 2019 •

edited

Loading

AutorestCI commented Mar 27, 2019 •

edited

Loading

AutorestCI commented Mar 27, 2019 •

edited

Loading