Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hub Generated] Review request for Microsoft.CostManagement to add version stable/2019-01-01 #5601

Merged
merged 8 commits into from
Apr 16, 2019
Merged

[Hub Generated] Review request for Microsoft.CostManagement to add version stable/2019-01-01 #5601

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
d055bd9
Fix urls of external docs from consumption to cost management
Jul 25, 2018
127a04b
Merge branch 'master' of https://github.com/Azure/azure-rest-api-specs
Apr 8, 2019
177ac54
Update enum of billing timegrain for budget API
Apr 8, 2019
47c7830
Revert "Update enum of billing timegrain for budget API"
Apr 9, 2019
4662309
Update enum of billing timegrain for budget API
Apr 9, 2019
4b2eeaf
Add billing timeframe to export API
Apr 10, 2019
ebf33d2
Merge branch 'master' into dev-cost-management-Microsoft.CostManageme…
Apr 16, 2019
2446632
Move enum values to the end
Apr 16, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions ...anagement/resource-manager/Microsoft.CostManagement/stable/2019-01-01/costmanagement.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -831,9 +831,11 @@
"enum": [
"WeekToDate",
"MonthToDate",
"BillingMonthToDate",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bgsky could you add new enum items to the end?

Copy link
Contributor

@sergey-shandar sergey-shandar Apr 15, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some model validation errors. Could you fix them? https://dev.azure.com/azure-sdk/public/_build/results?buildId=16605

Copy link
Contributor Author

@bgsky bgsky Apr 16, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sergey-shandar We addressed your comments by moving enum values to the end. In terms of model validation errors. A separate PR #5612 fixed them recently, and there is no error from new iteration. Please review and we expect to merge fast.

"YearToDate",
"TheLastWeek",
"TheLastMonth",
"TheLastBillingMonth",
"TheLastYear",
"Custom"
],
Expand Down