Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add list_by_scope #5757

Merged
merged 2 commits into from
May 1, 2019
Merged

Add list_by_scope #5757

merged 2 commits into from
May 1, 2019

Conversation

yuwzho
Copy link
Contributor

@yuwzho yuwzho commented Apr 25, 2019 •
edited
Loading

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.


Fixes #5751

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@AutorestCI
Copy link

AutorestCI commented Apr 25, 2019 •
edited
Loading

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

@AutorestCI
Copy link

AutorestCI commented Apr 25, 2019 •
edited
Loading

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#4232

@AutorestCI
Copy link

AutorestCI commented Apr 25, 2019 •
edited
Loading

Automation for azure-sdk-for-js

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-js#2621

@azuresdkci azuresdkci requested a review from kpajdzik April 25, 2019 09:18
@AutorestCI AutorestCI mentioned this pull request Apr 25, 2019
Merged
@AutorestCI
Copy link

AutorestCI commented Apr 25, 2019 •
edited
Loading

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#4724

@adxsdknet
Copy link

Automation for azure-sdk-for-net

A PR has been created for you:
Azure/azure-sdk-for-net#5953
.NET SDK Commits:
adxsdknet/azure-sdk-for-net@5941a51

adxsdknet added a commit to adxsdknet/azure-sdk-for-net that referenced this pull request Apr 25, 2019
@adxsdknet
.NET SDK Resource Provider:'Resource'
5941a51 
REST Spec PR 'Azure/azure-rest-api-specs#5757'
REST Spec PR Author 'yuwzho'
REST Spec PR Last commit
This was referenced Apr 25, 2019
Closed
Merged
Merged
@AutorestCI
Copy link

AutorestCI commented Apr 25, 2019 •
edited
Loading

Automation for azure-sdk-for-java

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-java#3337

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@yuwzho
Copy link
Contributor Author

yuwzho commented Apr 25, 2019 •
edited
Loading

Can anyone help me on the CI? It gives an error message ApplicationException: Unable to determine SDK generation directory. Exiting...., I have no idea about it.

@kpajdzik
Copy link
Contributor

Can anyone help me on the CI? It gives an error message ApplicationException: Unable to determine SDK generation directory. Exiting...., I have no idea about it.

Don't worry about .NET generation failures

@kpajdzik kpajdzik added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Apr 25, 2019
kpajdzik
kpajdzik approved these changes Apr 25, 2019
View reviewed changes
Copy link
Contributor

@kpajdzik kpajdzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. It's a simple change but let's wait for ARM team to approve as well.

@kpajdzik
Copy link
Contributor

If you haven't taken a look at our new onboarding experience at OpenAPIHub, it's a convenient way to create your PR when you're copying from an existing API version or when you're editing your existing specs. If you have any feedback or questions, feel free to use the feedback button on top of the site for help. Thanks!

@yuwzho
Copy link
Contributor Author

yuwzho commented Apr 26, 2019

@kpajdzik Thank you!

@anthony-c-martin anthony-c-martin added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed ARMReviewInProgress WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Apr 30, 2019
@kpajdzik kpajdzik merged commit f949c31 into Azure:master May 1, 2019
@AutorestCI AutorestCI mentioned this pull request May 1, 2019
Merged
@yuwzho yuwzho deleted the locks branch May 5, 2019 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kpajdzik kpajdzik kpajdzik approved these changes

@anthony-c-martin anthony-c-martin anthony-c-martin approved these changes

Assignees

@kpajdzik kpajdzik

Labels
ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ManagementLockClient] Add list_locks_by_scope API in swagger
6 participants
@yuwzho @AutorestCI @adxsdknet @azuresdkci @kpajdzik @anthony-c-martin