Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Swagger and Examples for shared dashboards to Azure #5811

Merged
merged 1 commit into from
May 1, 2019

Conversation

jjbfour
Copy link
Contributor

@jjbfour jjbfour commented Apr 30, 2019

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@jjbfour jjbfour requested a review from jhendrixMSFT April 30, 2019 19:00
@jjbfour
Copy link
Contributor Author

jjbfour commented Apr 30, 2019

@AutorestCI
Copy link

AutorestCI commented Apr 30, 2019

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#5017

@AutorestCI
Copy link

AutorestCI commented Apr 30, 2019

Automation for azure-sdk-for-js

Nothing to generate for azure-sdk-for-js

@AutorestCI
Copy link

AutorestCI commented Apr 30, 2019

Automation for azure-sdk-for-ruby

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-ruby#2434

@AutorestCI
Copy link

AutorestCI commented Apr 30, 2019

Automation for azure-sdk-for-java

Nothing to generate for azure-sdk-for-java

@AutorestCI
Copy link

AutorestCI commented Apr 30, 2019

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#4721

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

Copy link
Contributor

@veronicagg veronicagg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jjbfour looks good to merge as it's referencing an already reviewed PR.

@veronicagg veronicagg merged commit cefbe32 into Azure:master May 1, 2019
mccleanp pushed a commit that referenced this pull request Mar 23, 2022
* base version

* PlayerAccountPool and Title

* api-version

* debug examples

* changes for Segments Swagger added

* changes to swagger

* Update readme.md

* changes to swagger

* swagger changes as per cadl generated

* changes to swagger

* changes

* Prettier formatting

* changes

* changes

* changes

* changes

* example model validation check

* example model validation check

* example model validation check

* example model validation check

* example model validation check

* changes to swagger

* trying prettier fix

* changes

* fixing Prettier problems

* Update readme.md

* changes to fix problems reported by Prettier

* Update readme.md

* removed unused ref files in examples folder

* add title MSI and fix patch contract (#5729)

* add title MSI and fix patch contract

* spell check & prettier fix

* fix lint error

* fix prettier issue

* changes as per feedback in review

* Added Swagger changes

* changes as per feedback in review

* changes as per feedback in review

* prettier fix

* changes as per feedback in review

* prettier error fix

* some small testing for resource comment in PR

* changing resource to parameters

* changes to fix x-ms-identifier-failure

* Updates for title settings support (#5792)

* Updates for title settings support

* Run PrettierCheck

* Address minor review comment.

* Update RG name maintain consistency.

* Remove extra new line

* Minor change.

* Revert "Updates for title settings support (#5792)" (#5811)

This reverts commit 9697c9592607817fefb01e962ac1cdb92dd23990.

* Add support for Title Settings (#5812)

* Update Swagger

* Update example files.

* few chhnages as per feedback in PR

* fix examples, remove user assigned identities as it is not supported (#5835)

* fix examples, remove user assigned identities as it is not supported

* remove user assigned identity support from swagger

* change which was missed in my previous commit

* changes as per review in PR

* changing playfabAccountPoolId to playfabPlayerAccountPoolId

* changing playfabAccountPoolId to playFabPlayerAccountPoolId

* changes because of typo in examples in renaming

Co-authored-by: Zainudeen V K <zainu.vk@hotmail.com>
Co-authored-by: Zainudeen V K <zainuvk@github.com>
Co-authored-by: shubgup3 <67748348+shubgup3@users.noreply.github.com>
Co-authored-by: Anshul Verma <88476874+AnshulVermaa@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants