[ACR] Add "19-05-01" GA specification for Microsoft.ContainerRegistry #5854

ankurkhemani · 2019-05-03T02:34:04Z

Latest improvements:

Remove support for PUT/PATCH of registry resource with Classic SKU.
Refactor Policy APIs: Policy is now part of RegistryProperties and hence managed by CRUD on registry resource.
PUT on ARM resources now supports replace semantics (no swagger change). // cc @ravbhatnagar
(no new APIs added, two APIs deprecated)

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.
The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

AutorestCI · 2019-05-03T02:35:07Z

Automation for azure-sdk-for-js

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-js#3197

AutorestCI · 2019-05-03T02:35:13Z

Automation for azure-sdk-for-python

Encountered a Subprocess error: (azure-sdk-for-python)

Command: python ./scripts/multiapi_init_gen.py azure-mgmt-containerregistry
Finished with return code 1
and output:

Traceback (most recent call last):
  File "./scripts/multiapi_init_gen.py", line 22, in <module>
    import azure.common
ModuleNotFoundError: No module named 'azure'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "./scripts/multiapi_init_gen.py", line 26, in <module>
    import azure.common
ModuleNotFoundError: No module named 'azure'

AutorestCI · 2019-05-03T02:35:31Z

Automation for azure-sdk-for-ruby

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-ruby#2471

azuresdkci · 2019-05-03T02:36:20Z

Can one of the admins verify this patch?

AutorestCI · 2019-05-03T02:36:52Z

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#4873

AutorestCI · 2019-05-03T02:40:51Z

Automation for azure-sdk-for-java

Encountered a Subprocess error: (azure-sdk-for-java)

Command: ['/usr/local/bin/autorest', '/tmp/tmpizm0bk8b/rest/specification/containerregistry/resource-manager/readme.md', '--perform-load=false', '--swagger-to-sdk', '--output-artifact=configuration.json', '--input-file=foo', '--output-folder=/tmp/tmpcui6pzj4']
Finished with return code 7
and output:

AutoRest code generation utility [version: 2.0.4283; node: v8.12.0]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest
Failure:
Error: Unable to start AutoRest Core from /root/.autorest/@microsoft.azure_autorest-core@2.0.4373/node_modules/@microsoft.azure/autorest-core
Error: Unable to start AutoRest Core from /root/.autorest/@microsoft.azure_autorest-core@2.0.4373/node_modules/@microsoft.azure/autorest-core
    at main (/opt/node_modules/autorest/dist/app.js:232:19)
    at <anonymous>

/root/.autorest/@microsoft.azure_autorest-core@2.0.4373/node_modules/@microsoft.azure/autorest-core/dist/app.js:33
    autorest_core_1.Shutdown();
    ^
ReferenceError: autorest_core_1 is not defined
    at process.on (/root/.autorest/@microsoft.azure_autorest-core@2.0.4373/node_modules/@microsoft.azure/autorest-core/dist/app.js:33:5)
    at emitOne (events.js:121:20)
    at process.emit (events.js:211:7)
    at process.emit (/node_modules/source-map-support/source-map-support.js:439:21)
fs.js:612
  return binding.close(fd);
                 ^

Error: EBADF: bad file descriptor, close
    at Object.fs.closeSync (fs.js:612:18)
    at StaticVolumeFile.shutdown (/opt/node_modules/autorest/dist/static-loader.js:352:10)
    at StaticFilesystem.shutdown (/opt/node_modules/autorest/dist/static-loader.js:406:17)
    at process.exit.n [as exit] (/opt/node_modules/autorest/dist/static-loader.js:169:11)
    at printErrorAndExit (/node_modules/source-map-support/source-map-support.js:423:11)
    at process.emit (/node_modules/source-map-support/source-map-support.js:435:16)
    at process._fatalException (bootstrap_node.js:391:26)

REST Spec PR 'Azure/azure-rest-api-specs#5854' REST Spec PR Author 'ankurkhemani' REST Spec PR Last commit

ankurkhemani · 2019-05-03T02:42:09Z

//cc @mnltejaswini @djyou @sajayantony

REST Spec PR 'Azure/azure-rest-api-specs#5854' REST Spec PR Author 'ankurkhemani' REST Spec PR Last commit

ravbhatnagar · 2019-05-16T07:31:19Z

@ankurkhemani - The new api-version does not contain many of the APis in the previous API version. Not sure why is this. Typically, all older APis are present in the latest api-version along with any additions or updates to existing. That way customer can move to the latest api-version and use all the functionality offered by your service. Please feel free to schedule a 30 min sync to close on this review quicker.

ankurkhemani · 2019-05-17T02:40:53Z

@ravbhatnagar Those must be the Tasks APIs which are not part of this API version?
// cc @mnltejaswini

Anyways, I will schedule a meeting to review these changes.

ankurkhemani · 2019-05-17T20:37:05Z

@ravbhatnagar Can you help me understand why is the CI failing for python and ruby sdk here?

dsgouda · 2019-05-21T17:03:44Z

startbuild

ankurkhemani · 2019-05-21T22:10:10Z

@dsgouda @ravbhatnagar Can you please help me understand the CI fail for ruby sdk? Also, not sure why the PR for python-sdk and ruby-sdk is not generated?

dsgouda · 2019-05-21T22:20:15Z

@sergey-shandar please take a look

REST Spec PR 'Azure/azure-rest-api-specs#5854' REST Spec PR Author 'ankurkhemani' REST Spec PR Last commit

adxsdknet · 2019-05-22T01:02:14Z

Automation for azure-sdk-for-net

A PR has been created for you:
Azure/azure-sdk-for-net#6370
.NET SDK Commits:
adxsdknet/azure-sdk-for-net@604a9e4
adxsdknet/azure-sdk-for-net@e28efc5

ravbhatnagar · 2019-05-22T19:55:32Z

3 changes in this new api-version

PUT behavior changed to replace semantics for all resource types.
policies on registry was being set using actions. In this api-version, its a property on the registry. Discussed cross api-version scenarios. The outstanding action item on ACR team is to block update of policies on a registry from an older api-version if it was created using the newer api version.
policy action APis are being deprecated and hence dont exist in this new api-version. They will be supported to 12 months in the old api-version.
another feedback was to make retentionPolicy status an enum
Signing off from ARM side since the team has agreed to make the recommended changes.

ankurkhemani · 2019-05-24T00:25:29Z

@ravbhatnagar @sergey-shandar As discussed, I have added the enum for retention policy status. Also, created a work item #4672516 to track cross-api scenarios as mentioned by @ravbhatnagar

Can you please help me with the CI here and get this PR merged? Also need to generate the python sdk. Thanks!

REST Spec PR 'Azure/azure-rest-api-specs#5854' REST Spec PR Author 'ankurkhemani' REST Spec PR Last commit

ankurkhemani changed the title ~~add v19_05_GA swagger~~ [ACR] Add v19_05_GA swagger May 3, 2019

azuresdkci assigned sergey-shandar May 3, 2019

azuresdkci requested a review from sergey-shandar May 3, 2019 02:35

ankurkhemani changed the title ~~[ACR] Add v19_05_GA swagger~~ [ACR] Add "19-05-01" GA specification for Microsoft.ContainerRegistry May 3, 2019

adxsdknet added a commit to adxsdknet/azure-sdk-for-net that referenced this pull request May 3, 2019

.NET SDK Resource Provider:'ContainerRegistry'

73b5609

REST Spec PR 'Azure/azure-rest-api-specs#5854' REST Spec PR Author 'ankurkhemani' REST Spec PR Last commit

ankurkhemani force-pushed the ankheman/v_19_05_GA_swagger branch 2 times, most recently from 9ce56f2 to 9f4f2fd Compare May 7, 2019 02:43

sergey-shandar added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label May 10, 2019

adxsdknet added a commit to adxsdknet/azure-sdk-for-net that referenced this pull request May 15, 2019

.NET SDK Resource Provider:'ContainerRegistry'

6211c6c

REST Spec PR 'Azure/azure-rest-api-specs#5854' REST Spec PR Author 'ankurkhemani' REST Spec PR Last commit

ravbhatnagar added ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review ARMReviewMeetingRequired labels May 16, 2019

ankurkhemani force-pushed the ankheman/v_19_05_GA_swagger branch from 8c6ac68 to bdad522 Compare May 17, 2019 02:15

Azure deleted a comment from adxsdknet May 21, 2019

ankurkhemani added 4 commits May 21, 2019 13:16

add v19_05_GA swagger

5b68349

add examples

b8371c4

update readme(s)

14412c3

policy api refactoring

083da3e

ankurkhemani added 2 commits May 21, 2019 13:35

lint: incompatible description fix

52d0676

lint: remove unused examples

1139213

ankurkhemani force-pushed the ankheman/v_19_05_GA_swagger branch from bf71018 to 1139213 Compare May 21, 2019 20:35

AutorestCI mentioned this pull request May 21, 2019

[AutoPR containerregistry/resource-manager] [ACR] Add "19-05-01" GA specification for Microsoft.ContainerRegistry Azure/azure-sdk-for-js#3096

Closed

adxsdknet added a commit to adxsdknet/azure-sdk-for-net that referenced this pull request May 22, 2019

.NET SDK Resource Provider:'ContainerRegistry'

604a9e4

REST Spec PR 'Azure/azure-rest-api-specs#5854' REST Spec PR Author 'ankurkhemani' REST Spec PR Last commit

make retention policy status as enum, undo ruby readme

d0e008c

change retention days to integer

49512e0

adxsdknet added a commit to adxsdknet/azure-sdk-for-net that referenced this pull request May 24, 2019

.NET SDK Resource Provider:'ContainerRegistry'

e28efc5

REST Spec PR 'Azure/azure-rest-api-specs#5854' REST Spec PR Author 'ankurkhemani' REST Spec PR Last commit

sergey-shandar approved these changes May 24, 2019

View reviewed changes

sergey-shandar merged commit 4e521e9 into Azure:master May 24, 2019

AutorestCI mentioned this pull request May 24, 2019

[AutoPR containerregistry/resource-manager] [ACR] Add "19-05-01" GA specification for Microsoft.ContainerRegistry Azure/azure-sdk-for-js#3196

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ACR] Add "19-05-01" GA specification for Microsoft.ContainerRegistry #5854

[ACR] Add "19-05-01" GA specification for Microsoft.ContainerRegistry #5854

ankurkhemani commented May 3, 2019 •

edited

Loading

AutorestCI commented May 3, 2019 •

edited

Loading

AutorestCI commented May 3, 2019 •

edited

Loading

AutorestCI commented May 3, 2019 •

edited

Loading

azuresdkci commented May 3, 2019

AutorestCI commented May 3, 2019 •

edited

Loading

AutorestCI commented May 3, 2019 •

edited

Loading

ankurkhemani commented May 3, 2019

ravbhatnagar commented May 16, 2019

ankurkhemani commented May 17, 2019

ankurkhemani commented May 17, 2019

dsgouda commented May 21, 2019

ankurkhemani commented May 21, 2019

dsgouda commented May 21, 2019

adxsdknet commented May 22, 2019 •

edited

Loading

ravbhatnagar commented May 22, 2019 •

edited

Loading

ankurkhemani commented May 24, 2019

[ACR] Add "19-05-01" GA specification for Microsoft.ContainerRegistry #5854

[ACR] Add "19-05-01" GA specification for Microsoft.ContainerRegistry #5854

Conversation

ankurkhemani commented May 3, 2019 • edited Loading

Latest improvements:

Contribution checklist:

ARM API Review Checklist

AutorestCI commented May 3, 2019 • edited Loading

Automation for azure-sdk-for-js

AutorestCI commented May 3, 2019 • edited Loading

Automation for azure-sdk-for-python

AutorestCI commented May 3, 2019 • edited Loading

Automation for azure-sdk-for-ruby

azuresdkci commented May 3, 2019

AutorestCI commented May 3, 2019 • edited Loading

Automation for azure-sdk-for-go

AutorestCI commented May 3, 2019 • edited Loading

Automation for azure-sdk-for-java

ankurkhemani commented May 3, 2019

ravbhatnagar commented May 16, 2019

ankurkhemani commented May 17, 2019

ankurkhemani commented May 17, 2019

dsgouda commented May 21, 2019

ankurkhemani commented May 21, 2019

dsgouda commented May 21, 2019

adxsdknet commented May 22, 2019 • edited Loading

Automation for azure-sdk-for-net

ravbhatnagar commented May 22, 2019 • edited Loading

ankurkhemani commented May 24, 2019

ankurkhemani commented May 3, 2019 •

edited

Loading

AutorestCI commented May 3, 2019 •

edited

Loading

AutorestCI commented May 3, 2019 •

edited

Loading

AutorestCI commented May 3, 2019 •

edited

Loading

AutorestCI commented May 3, 2019 •

edited

Loading

AutorestCI commented May 3, 2019 •

edited

Loading

adxsdknet commented May 22, 2019 •

edited

Loading

ravbhatnagar commented May 22, 2019 •

edited

Loading