Adding PrivateEndpoint (formerly called InterfaceEndpoint) and PrivateLinkService with operations. #5860

bowen0106 · 2019-05-03T18:17:47Z

No description provided.

…document.

2. Add availablePrivateEndpointTypes to readme.md file.

2. Modify PrivateEndpoint and its example to match the PrivateLinkService.

AutorestCI · 2019-05-03T18:19:18Z

Automation for azure-sdk-for-python

Encountered a Subprocess error: (azure-sdk-for-python)

Command: ['/usr/local/bin/autorest', '/tmp/tmp71ki1q3e/rest/specification/network/resource-manager/readme.md', '--multiapi', '--python', '--python-mode=update', '--python-sdks-folder=/tmp/tmp71ki1q3e/sdk', '--use=@microsoft.azure/autorest.python@~3.0.56', '--version=preview']
Finished with return code -6
and output:

AutoRest code generation utility [version: 2.0.4283; node: v10.15.3]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest
   Loading AutoRest core      '/root/.autorest/@microsoft.azure_autorest-core@2.0.4373/node_modules/@microsoft.azure/autorest-core/dist' (2.0.4373)
   Loading AutoRest extension '@microsoft.azure/autorest.python' (~3.0.56->3.0.62)
   Loading AutoRest extension '@microsoft.azure/autorest.modeler' (2.3.44->2.3.44)
Processing batch task - {"tag":"package-2019-02"} .

<--- Last few GCs --->

[20809:0x2cb9c00]    50510 ms: Mark-sweep 1377.7 (1425.4) -> 1377.4 (1425.9) MB, 1266.6 / 0.0 ms  (average mu = 0.107, current mu = 0.008) allocation failure scavenge might not succeed
[20809:0x2cb9c00]    52152 ms: Mark-sweep 1378.3 (1425.9) -> 1378.0 (1426.9) MB, 1629.6 / 0.0 ms  (average mu = 0.053, current mu = 0.007) allocation failure scavenge might not succeed


<--- JS stacktrace --->

==== JS stack trace =========================================

    0: ExitFrame [pc: 0x7af471dbe1d]
Security context: 0x36c75191e6e9 <JSObject>
    1: values [0x36c751905211](this=0x36c751904639 <JSFunction Object (sfi = 0x334ed1a8e301)>,0x08e88eb477a9 <JSProxy>)
    2: losslessJsonSerializable(aka losslessJsonSerializable) [0x37b11d7dde19] [/root/.autorest/@microsoft.azure_autorest-core@2.0.4373/node_modules/@microsoft.azure/autorest-core/dist/lib/ref/yaml.js:242] [bytecode=0x1b456eb22431 offset=106...

FATAL ERROR: Ineffective mark-compacts near heap limit Allocation failed - JavaScript heap out of memory
 1: 0x8dc510 node::Abort() [node]
 2: 0x8dc55c  [node]
 3: 0xad9b5e v8::Utils::ReportOOMFailure(v8::internal::Isolate*, char const*, bool) [node]
 4: 0xad9d94 v8::internal::V8::FatalProcessOutOfMemory(v8::internal::Isolate*, char const*, bool) [node]
 5: 0xec7bf2  [node]
 6: 0xec7cf8 v8::internal::Heap::CheckIneffectiveMarkCompact(unsigned long, double) [node]
 7: 0xed3dd2 v8::internal::Heap::PerformGarbageCollection(v8::internal::GarbageCollector, v8::GCCallbackFlags) [node]
 8: 0xed4704 v8::internal::Heap::CollectGarbage(v8::internal::AllocationSpace, v8::internal::GarbageCollectionReason, v8::GCCallbackFlags) [node]
 9: 0xed7371 v8::internal::Heap::AllocateRawWithRetryOrFail(int, v8::internal::AllocationSpace, v8::internal::AllocationAlignment) [node]
10: 0xea0466 v8::internal::Factory::AllocateRawArray(int, v8::internal::PretenureFlag) [node]
11: 0xea0cea v8::internal::Factory::NewFixedArrayWithFiller(v8::internal::Heap::RootListIndex, int, v8::internal::Object*, v8::internal::PretenureFlag) [node]
12: 0xea0dc7 v8::internal::Factory::NewFixedArray(int, v8::internal::PretenureFlag) [node]
13: 0xffc85f v8::internal::GetOwnValuesOrEntries(v8::internal::Isolate*, v8::internal::Handle<v8::internal::JSReceiver>, v8::internal::PropertyFilter, bool, bool) [node]
14: 0xffcaa8 v8::internal::JSReceiver::GetOwnValues(v8::internal::Handle<v8::internal::JSReceiver>, v8::internal::PropertyFilter, bool) [node]
15: 0x1169163 v8::internal::Runtime_ObjectValuesSkipFastPath(int, v8::internal::Object**, v8::internal::Isolate*) [node]
16: 0x7af471dbe1d

AutorestCI · 2019-05-03T18:19:49Z

Automation for azure-sdk-for-go

Encountered a Subprocess error: (azure-sdk-for-go)

Command: ['/usr/local/bin/autorest', '/tmp/tmp19qfbjgo/rest/specification/network/resource-manager/readme.md', '--go', '--go-sdk-folder=/tmp/tmp19qfbjgo/src/github.com/Azure/azure-sdk-for-go', '--multiapi', '--preview-chk', '--use=@microsoft.azure/autorest.go@~2.1.133', '--use-onever', '--verbose']
Finished with return code -6
and output:

AutoRest code generation utility [version: 2.0.4283; node: v8.12.0]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest
   Loading AutoRest core      '/root/.autorest/@microsoft.azure_autorest-core@2.0.4302/node_modules/@microsoft.azure/autorest-core/dist' (2.0.4302)
   Including configuration file 'file:///tmp/tmp19qfbjgo/rest/specification/network/resource-manager/readme.go.md'
   Loading AutoRest extension '@microsoft.azure/autorest.go' (~2.1.133->2.1.133)
   Loading AutoRest extension '@microsoft.azure/autorest.modeler' (2.3.38->2.3.38)
Processing batch task - {"tag":"package-2019-02"} .
   Including configuration file 'file:///tmp/tmp19qfbjgo/rest/specification/network/resource-manager/readme.go.md'

<--- Last few GCs --->

[4977:0x2ebf8c0]   100027 ms: Mark-sweep 1388.2 (1470.9) -> 1387.9 (1476.4) MB, 1638.9 / 0.0 ms  allocation failure GC in old space requested
[4977:0x2ebf8c0]   101735 ms: Mark-sweep 1387.9 (1476.4) -> 1387.8 (1438.9) MB, 1707.4 / 0.0 ms  last resort GC in old space requested
[4977:0x2ebf8c0]   103365 ms: Mark-sweep 1387.8 (1438.9) -> 1387.8 (1437.4) MB, 1629.6 / 0.0 ms  last resort GC in old space requested


<--- JS stacktrace --->

==== JS stack trace =========================================

Security context: 0x36c6686a5879 <JSObject>
    1: set [native weak-collection.js:~27] [pc=0x1e7a75c97209](this=0x3969fec41a79 <JSWeakMap>,key=0xafa0fd7d491 <Object map = 0x2f485f873381>,value=0x1108225a9679 <String[6]: String>)
    2: /* anonymous */(aka /* anonymous */) [/root/.autorest/@microsoft.azure_autorest-core@2.0.4302/node_modules/@microsoft.azure/autorest-core/dist/lib/ref/yaml.js:~101] [pc=0x1e7a75c89239](this=0x3239b1f022d1 <...

FATAL ERROR: CALL_AND_RETRY_LAST Allocation failed - JavaScript heap out of memory
 1: node::Abort() [node]
 2: 0x8cbf4c [node]
 3: v8::Utils::ReportOOMFailure(char const*, bool) [node]
 4: v8::internal::V8::FatalProcessOutOfMemory(char const*, bool) [node]
 5: v8::internal::Factory::NewFixedArray(int, v8::internal::PretenureFlag) [node]
 6: v8::internal::HashTable<v8::internal::ObjectHashTable, v8::internal::ObjectHashTableShape>::NewInternal(v8::internal::Isolate*, int, v8::internal::PretenureFlag) [node]
 7: v8::internal::HashTable<v8::internal::ObjectHashTable, v8::internal::ObjectHashTableShape>::New(v8::internal::Isolate*, int, v8::internal::PretenureFlag, v8::internal::MinimumCapacity) [node]
 8: v8::internal::HashTable<v8::internal::ObjectHashTable, v8::internal::ObjectHashTableShape>::EnsureCapacity(v8::internal::Handle<v8::internal::ObjectHashTable>, int, v8::internal::PretenureFlag) [node]
 9: v8::internal::ObjectHashTable::Put(v8::internal::Handle<v8::internal::ObjectHashTable>, v8::internal::Handle<v8::internal::Object>, v8::internal::Handle<v8::internal::Object>, int) [node]
10: v8::internal::JSWeakCollection::Set(v8::internal::Handle<v8::internal::JSWeakCollection>, v8::internal::Handle<v8::internal::Object>, v8::internal::Handle<v8::internal::Object>, int) [node]
11: v8::internal::Runtime_WeakCollectionSet(int, v8::internal::Object**, v8::internal::Isolate*) [node]
12: 0x1e7a759042fd

AutorestCI · 2019-05-03T18:20:44Z

Automation for azure-sdk-for-js

Encountered a Subprocess error: (azure-sdk-for-js)

Command: ['/usr/local/bin/autorest', '/tmp/tmpdgasdxx1/rest/specification/network/resource-manager/readme.md', '--license-header=MICROSOFT_MIT_NO_VERSION', '--typescript', '--typescript-sdks-folder=/tmp/tmpdgasdxx1/azure-sdk-for-js', '--use=@microsoft.azure/autorest.typescript@4.0.0']
Finished with return code -6
and output:

AutoRest code generation utility [version: 2.0.4283; node: v8.12.0]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest
   Loading AutoRest core      '/root/.autorest/@microsoft.azure_autorest-core@2.0.4299/node_modules/@microsoft.azure/autorest-core/dist' (2.0.4299)
   Loading AutoRest extension '@microsoft.azure/autorest.typescript' (4.0.0->4.0.0)
   Loading AutoRest extension '@microsoft.azure/autorest.modeler' (2.3.51->2.3.51)

<--- Last few GCs --->

[23875:0x38dd860]   116028 ms: Mark-sweep 1385.7 (1447.6) -> 1385.7 (1448.1) MB, 1889.1 / 0.0 ms  allocation failure GC in old space requested
[23875:0x38dd860]   117374 ms: Mark-sweep 1385.7 (1448.1) -> 1385.7 (1433.1) MB, 1346.8 / 0.0 ms  last resort GC in old space requested
[23875:0x38dd860]   118990 ms: Mark-sweep 1385.7 (1433.1) -> 1385.7 (1433.1) MB, 1615.5 / 0.0 ms  last resort GC in old space requested


<--- JS stacktrace --->

==== JS stack trace =========================================

Security context: 0x816795a5879 <JSObject>
    1: IdentitySourceMapping [/root/.autorest/@microsoft.azure_autorest-core@2.0.4299/node_modules/@microsoft.azure/autorest-core/dist/lib/source-map/merging.js:~189] [pc=0x32814069290e](this=0x1e6270241a9 <Object map = 0x3b6c96862601>,sourceYamlFileName=0x285a8b7f46c1 <String[30]: mem:///2686?code-model-v1.yaml>,sourceYamlAst=0x2e17d813ace9 <Object map = 0x4a52a7d5031>)
    2: ProcessCodeModel [...

FATAL ERROR: CALL_AND_RETRY_LAST Allocation failed - JavaScript heap out of memory
 1: node::Abort() [node]
 2: 0x8cbf4c [node]
 3: v8::Utils::ReportOOMFailure(char const*, bool) [node]
 4: v8::internal::V8::FatalProcessOutOfMemory(char const*, bool) [node]
 5: v8::internal::Factory::NewUninitializedFixedArray(int) [node]
 6: 0xd7fc13 [node]
 7: v8::internal::Runtime_GrowArrayElements(int, v8::internal::Object**, v8::internal::Isolate*) [node]
 8: 0x3281402842fd

AutorestCI · 2019-05-03T18:25:40Z

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

azuresdkci · 2019-05-03T18:31:26Z

Can one of the admins verify this patch?

...ork/resource-manager/Microsoft.Network/stable/2019-04-01/examples/PrivateEndpointCreate.json

...etwork/resource-manager/Microsoft.Network/stable/2019-04-01/examples/PrivateEndpointGet.json

...twork/resource-manager/Microsoft.Network/stable/2019-04-01/examples/PrivateEndpointList.json

...rk/resource-manager/Microsoft.Network/stable/2019-04-01/examples/PrivateEndpointListAll.json

AutorestCI · 2019-05-03T19:35:02Z

Automation for azure-sdk-for-java

Nothing to generate for azure-sdk-for-java

…LinkServiceConnections.

dsgouda

LGTM

dsgouda · 2019-05-10T21:13:07Z

@malopMSFT @number213 Please approve

malopMSFT · 2019-05-10T22:02:52Z

#sign-off

anton-evseev · 2019-05-13T12:21:47Z

LGTM, but please note that renaming InterfaceEndpoints to PrivateEndpoints is going to be a breaking change in SDK & PowerShell (hence failure in NetworkValidation, though it PowerShell you can fix it internally and add an alias))

anton-evseev

On second thought, I think x-ms-client-flatten is missing in multiple definitions. @dsgouda, could you please take a look?

anton-evseev · 2019-05-14T14:05:21Z

specification/network/resource-manager/Microsoft.Network/stable/2019-04-01/privateEndpoint.json

+    "PrivateLinkServiceConnection": {
+      "properties": {
+        "properties": {
+            "$ref": "#/definitions/PrivateLinkServiceConnectionProperties",


I think you need to add "x-ms-client-flatten": true here

specification/network/resource-manager/Microsoft.Network/stable/2019-04-01/privateEndpoint.json

...ication/network/resource-manager/Microsoft.Network/stable/2019-04-01/privateLinkService.json

anton-evseev · 2019-05-14T14:07:52Z

...ication/network/resource-manager/Microsoft.Network/stable/2019-04-01/privateLinkService.json

+    "PrivateEndpointConnection": {
+      "properties": {
+        "properties": {
+            "$ref": "#/definitions/PrivateEndpointConnectionProperties",


I think you need to add "x-ms-client-flatten": true here

dsgouda

Needs flattening of nested properties

specification/network/resource-manager/Microsoft.Network/stable/2019-04-01/privateEndpoint.json

veronicagg · 2019-05-15T21:30:19Z

@dsgouda I see it flagged by the linter, flattening is flagged as a warning though - see https://dev.azure.com/azure-sdk/public/_build/results?buildId=29431&view=logs&jobId=688669d0-441c-57c3-cf6d-f89a22ccfa5d&taskId=923b5a90-e462-5994-c166-86509c6bf5f2&lineStart=952&lineEnd=953&colStart=1&colEnd=1

ravbhatnagar · 2019-05-16T07:44:16Z

This was previously approved by ARM team when it was called interfaceEndpoints. SIgning off.

dsgouda

Per offline comments, nesting is a warning but we really do recommend the service to be designed with minimal nesting.

dsgouda · 2019-05-16T20:38:29Z

@bowen0106 please fix the model validation errors and we should be good to merge

anton-evseev

Please add "x-ms-client-flatten": true to definitions with nested properties for better SDK experience (2 in privateEndpoint.json and 3 in privateLinkService.json)

...ication/network/resource-manager/Microsoft.Network/stable/2019-04-01/privateLinkService.json

specification/network/resource-manager/Microsoft.Network/stable/2019-04-01/privateEndpoint.json

...ication/network/resource-manager/Microsoft.Network/stable/2019-04-01/privateLinkService.json

…ges. Other minor fix.

dsgouda · 2019-05-22T17:12:49Z

@number213 Please approve

anton-evseev · 2019-05-22T17:30:25Z

@dsgouda talked to @bowen0106 today (yesterday in your timezone), he agreed to add x-ms-client-flatten to properties. Once that's done, it's good to go

anton-evseev

LGTM

anton-evseev · 2019-05-22T18:19:15Z

@dsgouda for some reason CI didn't restart, could you please take a look?

* Adds base for updating Microsoft.Network from version stable/2019-02-01 to version 2019-04-01 * Updates readme * Updates API version in new specs and examples * Adding custom port for probe in Application Gateways. (#5758) * Adding custom port for probe in Application Gateways * Fix JSON * PR comments * PR comments * Add support for Get ResourceNavigationLinks and Get ServiceAssociationLinks (#5767) * Initial commit * Rename operation IDs * Sync from master. Improved code style (#5802) * Refactor enum list of /definitions/ReadableType (#5747) - Remove unnecessary "Regular Expression Entity Extractor" * Update rest-api-spec-scripts to 0.2 and remote travis-ci jobs (except… (#5742) * Update rest-api-spec-scripts to 0.2 and remote travis-ci jobs (except branch check) * return semantic and model * minor * modelValidation and semanticValidation use avocado diff. * Install .Net * semantic and model * restore travis * minor * Fix documentation issues. (#5721) * Introduce toBeDetached flag for Datadisks for ApiVersion 2019-03-01 (#5704) * ToBeDetached added in Json and an example added * Removed from OS disk and added to dataDisk * Initial stable version (#5683) * NFSAAS-2185 update to R4 standard * NFSAAS-2185 update to R4 RP standard * NFSAAS-2185 update to R4 RP standard * NFSAAS-2185 update to R4 RP standard * NFSAAS-2185 update to RP R4 standard * NFSAAS-2185 update to R4 RP standard * NFSAAS-2185 update to R4 RP standard * NFSAAS-2185 update to R4 RP standard * NFSAAS-2185 update to R4 RP standard * Adds Partners GET (#5726) * Fixing csharp multi profiles (#4092) * Fixing csharp multi profiles * minor fix * fixing network * unused * unused * FIxing dns * Moved AdditionalCapabilities out from VM profile to VMSS and updated SKUs API to support zonal capabilities (#5753) * Updated comments and introduced AvailabilitySetSkuType to help users use predefined constants * Moved AdditionalCapabilities out from VM profile to VMSS and updated SKUs API to support zonal capabilities * Fixed indentation * Fixed indentation in skus.json * QnAMaker DTO changes for Multiturn (#5738) * DTO updates for multiturn support * fix message * max len of display text * Resolve comments * missed additional property * Fix Namespace in Ruby Readme Qnamaker * [Hub Generated] Review request for Microsoft.ApiManagement to add version stable/2019-01-01 (#5732) * Policy Format * update example of creating revisions from api * upper case XML * Add hyperVGeneration enum property to ImageProperties (#5740) * added hyperV property along with hyperVGenerationType * Updated Compute.json by chaging HyperVGenerationTypes to V1,v2 * Update compute.json * Update compute.json to link enum to outer HyperVGeneration * Update compute.json Ad trailing , * Adding 2019-04-01 API version for Microsoft.DevSpaces RP (#5713) * Adding old spec and examples * Adding 2019-04-01 API version * Fix readmes for SDK * Add missing response code in swagger example * 2019-02-01-preview (#5698) * 2019-02-01-preview * Added ruby spec. Removed Node spec. Fixed spelling error in 'utilizing'. Removed BOM from the beginning of example files. * Sqldb serverless (#5760) * Add auto pause delay param to 2017-01-01-preview get/database * Add minCapacity param to 2017-01-01-preview database * Scripts v 0.3.9 (#5761) * Scripts v 0.3.9 * Update preproduction-azure-pipelines.yml * Remove SDK generation rom preprod. * branch protection (#5764) * branch protection * script * test * failOnstderr * on private * Added swagger spec for Microsoft.DynamicsTelemetry preview (#5161) * Added swagger spec for Microsoft.DynamicsTelemetry preview * host changed * Fix Operations_List * Update dynamicstelemetry.json Host changed to management.azure.com * "No Content" response added * change blobduration data type to "date-time" * Changed blobDuration format to "format":"duration" * add 204 response to the sample * fix validation error * modelValidation2 and semanticValidation2 (#5765) * modelValidation2 and semanticValidation2 * modelvalidation2 * rename * [TimeSeriesInsights] Spec bugfix for GetEvents API - projected properties are a list of EventProperty and not string. (#5681) * Fix or suppress spec violations Fix R2016 by making PATCH body properties optional. Suppress the remaining 4 violations that are confirmed as false positives. * Try removing 2nd top-level heading, which _may_ have been causing a linter warning. * Fix extra indention which prevented linter from running. * Added dataStringComparisonBehavior parameter to reference data put/update spec. * Fixed grammar. * adding partitionkeyProperty to environmentInfo * changing property name * changing modelAsString * Initial checkin of spec. Unchanged from GA release other than version. * Remove .orig files * Fix validation error by removing IoTHub ES from List ES example response * Add extra example that was missing from preview spec. * Add long-term environment to resource hierarchy, and update examples. * Switch to model-as-string for enums. Restore EnvironmentResource's inheritance from TrackedResource. * Upsate sku description * Add new TSI preview api-version to readme.md. * Add suppressions for false-positive linter failures. * Test suppression failures * Adding preview package tag to several other places in readme.md * Add preview package to the readme.go.md file * Remove invalid required property from EnvironmentCreateOrUpdateParameters * Initial version of data plane swagger spec for PAYG (Preview) SKU. * Added missing Readme.md * Fixed name of readme * Fixed path to swagger json * Attempt to fix readme * Apply suggestions from code review Co-Authored-By: dmdenmsft <dmden@microsoft.com> * Update timeseriesinsights.json * Update timeseriesinsights.json * Added link to oav issue * bug fix - get events payload projected properties to take in list of EventProperty and not string. * Fixed inconsistencies between examples and spec. * Fixed bug in spec specifying TSID array. * Updating the schema to adhere to the new design changes (#5769) * add storage package-2019-04 to Go SDK (#5773) * add netapp package-netapp-2019-05-01 to Go SDK (#5774) * fixes (#5770) * revert not support formats (#5763) * [Cogs Face] Align with latest Face API v1.12 (#5722) * Sync with APIM descriptions. * Remove description end with '\n' and add add face to person in person gourp descriptions. * Update * [Hub Generated] Review request for Microsoft.OperationalInsights to add version preview/2015-11-01-preview (#5645) * Update OperationalInsights.json * Adds suppression to readme * Adds suppression to readme * Adds suppression to readme * Adds suppression to readme * Adds suppression to readme * Revert "Adds suppression to readme" This reverts commit 8c0e9bd. * Revert "Adds suppression to readme" This reverts commit ecf7615. * Revert "Adds suppression to readme" This reverts commit c8a0d5c. * Revert "Adds suppression to readme" This reverts commit 7f54236. * Revert "Adds suppression to readme" This reverts commit 350be00. * Personalizer v1.0 preview (#5743) * Initial setup of Personalizer SDK * Add readme.md * fix some comments * Fix readme.md * fix enums and examples, work in progress * handle error codes * fix typos * resolve comments * using UTF-8 encoding * checking formatted Personalizer.json * use ASCII * use parameter names * remove example from definitions * Update examples * update operation names to noun_verb format * update generated swagger * deleting earlier example files * add back application/octet-stream * Change model type back to file * Update readonly properties * Update readonly properties * remove IActionResult * [Datafactory] Adding getFeatureValue API in factory scope (#5591) * Adding getFeatureValue API in factory scope * Updating examples for IfNoneMatch header on get calls * Fixing example validation errors * remove ifNoneMatch=null from examples * More example validation fixes * One more IR example fix * Deleted wrong property * Fixing last example * Restoring previous example * Testing example for validation * Reverting last commit * Compute Python 2019-04 (#5775) * [ACR] Support MSI in Task [NEW API VERSION] (#5561) * examples for new sdk * update examples * update examples * add identity to core examples * Add opaque example * add references to examples * spelling fix * update tag in all readmes * update jave readme * fix RunRequest examples * Delete extra file. * Delete extra file. * Fix examples from previous API version * fix example errors * FileTaskRunRequest fix * Add RunErrorMessage from previous version * update api-version in examples * old version: 2018-09-01 * add new API version: 2019-04-01 * Support Scheduler Trigger * fix build errors * rename to TimerTrigger * nit rename comment * Rename Gremlin container by graph (#5744) * Rename Gremlin container by graph * Replace rid in url with name * Replace mongo with mongodb * Replace rid with name in examples * Fix bug * Update MongoDB name * Update file name by git mv as windows doesn't work * Update MongDB name in example * Adding all sync methods to Personalizer API (#5777) * add stream as return type for get model * fix response type for correct op * change type file to stream * remove stream ref * Adding all sync methods to Personalizer API * Adding all sync methods to Personalizer API * Fix missing proxy override enum for managed instance swagger (#5780) * Initializing instance pools swagger and examples - no usages / managed instances get by instance pool * Fix missing enum for proxy override * Make Microsoft.Subscription.Admin api consistent. (#5771) * Make Microsoft.Subscription.Admin api consistent. * Remove location delete api * Change Metrics to metrics * Change MetricDefinitions to metricDefinitions * Remove the Delete.json * Fix examples (#5778) * chore: jsonfmt addons (#5785) Ran `jsonfmt -w specification/addons/**/*.json` * Add v3.0-preview APIs for LUIS (#5724) * Add v3.0-preview APIs * Remove the timezoneoffset property * Add the datetimeReference property * - Add description to the definitions and the APIs - Fix naming bugs (show-all-intents,dynamicLists) - Rename the definitions for consistency * [Merge is planed on 2019/04/29] Move scripts from this repo. (#5719) * Breaking Change2 * Experimental lintdiff * No more model/semantic/syntax validations in travis-CI. * Scripts 0.1.8 * Use scripts from @azure/rest-api-specs-scripts * ts-utils * fix breaking changes * momentOfTruthPostProcessing * momentOfTruthPostProcessing.ts * remove 'ts-utils.ts' * Remove `utils` * postToGitHub.ts * switch to momentOfTruthUtils * minor * Syntax.ts * semanticValidation.ts * another try * minor update * URL/fix * OAD ^0.2.13 * update to new scripts. * Use scripts from `sergey/move-from-specs-repo`. * simplified model validation. * preprod * postToGitHub * momentOfTruthPostProcessing * Semantic Validation * getSwaggers() * Use `getExamples()` and `getSwaggers()`. * Update package.json * Remove travis-CI jobs except branch strategy. * remove model and semantic validations version 2. * chore: Renormalize line endings (#5783) Ran `git add --renormalize .` * Adding Create, Delete and List Namespaces Endpoints for Event Hubs Cluster Resource (#5565) * Adding ClusterPut.json example * Create ListNamespaceInClusterPost.json * Create ClusterDelete.json * Update EventHub-preview.json * Adding valid responses to Cluster PUT example. * Update specification/eventhub/resource-manager/Microsoft.EventHub/preview/2018-01-01-preview/EventHub-preview.json Co-Authored-By: FBettati <franco.d.bettati@gmail.com> * Adding Available Regions API * Adding ListAvailableClusters POST example. * Modifying response in AvailableClusterList * Updating LIstAvailableClustersPost.json example * Delete ListAvailableClustersPost.json * Create ListAvailableClustersGet.json * Delete ListNamespaceInClusterPost.json * Create ListNamespacesInClusterGet.json * Update EventHub-preview.json * Modify availableClusters API to have a valid ARM collection response * Updating AvailableClusters collection response example * Updating /cluster/namespaces and /availableClusters calls * Adding parameters to ListAvailableClusters example. * Adding extra layer to namespace IDs in ListNamespacesInCluster example. * Removing comma from ListAvailableClusters example * Added regultory compliance to package-composite-v3 (#5786) * Added regultory compliance to package-composite-v3 * Added regultory compliance to package-composite-v3 * Improve documentation of sql database & elastic pool skus (#5756) * Improve documentation of db and pool skus * Update documentation for database 2017-10-01-preview * Update documentation for elastic pool 2017-10-01-preview * Fixed syntax error in databases 2017-10-01 * Fixed syntax error in elasticPools 2017-10-01 * Remove CreateVCoreDatabase example that is no longer referenced * Remove DW DTU capacity example due to feedback * Fixed broken Sku reference * Fixed model validation issues * Fixed another model validation error * Additional doc tweaks * Create new resource type: Microsoft.ResourceGraph/queries (#5478) * Adding Workbooks resource type. * Rename workbookDelete.json to WorkbookDelete.json * Fixed undefiend parameter issue with Delete verb. * Update swagger to add subscriptionId * Fixed duplicated operation id issue * Removed links endpoint * Removed unused samples * Revert "Removed unused samples" This reverts commit bed6bc3. * Revert "Removed links endpoint" This reverts commit c245a85. * Removed link logic and added get by resourceid * Applied PR comments * Added Resource Group parameter for GET. Removed get by sourceId since we are not using sourceId anymore * Resolved the merge conflicts with readme.md * Remove a location parameter since ARM routes it as we are using an tracted resource type * Created newer version (2018-04-01-preview) for workbook resource type. * Added Microsoft/Insights/Operations * Added Microsoft/Insights/Operations * Corrected the api version. * Made properties of PATCH operation as not required. Updated the version number to reflect the actual production one. * Updated Resource properties with the correct fields. Created new definition for PATCH operation since location is not required field * Update readme file * Uses plural for operation group name * Removed x-ms-mutability settings * Removed the location settings for PATCH * Added Microsoft.ResourceGraph/SavedQuery resource type * Fixed various validation errors * Updated ARG/resources to add a saved query support along with examples * Updated ARM/resources based on the feedback * Prepared for Swagger submittion * Added saved query entry in readme.md * Changed HTTP status code of 201 to 200 for DELETE * Removed a name from payload since it is already specified in url * Removed location since it is a global resource and added eTag * Moved savedquery.json along with all examples into 2018-09-01-preview folder * Update saved query metadata in OperationsList.json * Updated readme.md file to address a version * Fixed a version for saved query * Fixed indentation of -input-file in readme * Renamed Saved => Graph * Applied PR comments * Restored extended enum value in ResultKind since we are using it * Removed the extended enum value again * Apply ARM API team comments * Fix examples * Fix examples * Added nextLinkName * add Go SDK build * make descriptions match * Added nextLink definition in OperationListResult * Removed a duplicated OperationListResult and reference to resourcegraph.json * Added nextLinkName: nextLink for x-ms-pageable in operations * fix formatting and description * Removed extended from enum * Updating Profile format (#5768) * Updating Profile format Updating profile spec format to include actual path for resource spec * Update 2019-03-01-hybrid.json updating resourceName to resourceType * [Azure Search] New GA data-plane API spec for version 2019-05-06 (#5782) * [Azure Search] Copy 2017-11-11-Preview specs to 2019-05-06 * [Azure Search] Update 2019-05-06 spec to reflect new GA API Made the following changes to specs and examples: 1. Changed version number from 2017-11-11-Preview to 2019-05-06. 2. Removed encryptionKey from Index and SynonymMap, as well as supporting types and examples. Encryption with customer-managed keys is still in preview. 3. Added statusCode to IndexError since this was added to the 2019-05-06 API. 4. Made DataSourceCredentials.connectionString an optional property to suppress generation of client-side validation code. This will make it easier for customers to write correct code that updates their data sources. This is especially important now that Create and CreateOrUpdate do not return the connection string. No further changes are required because all other features from 2017-11-11-Preview are now GA in 2019-05-06. * [SRP] Expose lease container in Apr19 API. (#5733) * [SRP] Expose lease container in Apr19 API. * Fix lease container example files; fix casing in Lease Container URL * Update CODEOWNERS (#5794) assigning as one of the owners of profile directory * [Microsoft.ResourceGraph] Returning null for nextLink in example to preserve the existing scenario (#5792) * Adding Workbooks resource type. * Rename workbookDelete.json to WorkbookDelete.json * Fixed undefiend parameter issue with Delete verb. * Update swagger to add subscriptionId * Fixed duplicated operation id issue * Removed links endpoint * Removed unused samples * Revert "Removed unused samples" This reverts commit bed6bc3. * Revert "Removed links endpoint" This reverts commit c245a85. * Removed link logic and added get by resourceid * Applied PR comments * Added Resource Group parameter for GET. Removed get by sourceId since we are not using sourceId anymore * Resolved the merge conflicts with readme.md * Remove a location parameter since ARM routes it as we are using an tracted resource type * Created newer version (2018-04-01-preview) for workbook resource type. * Added Microsoft/Insights/Operations * Added Microsoft/Insights/Operations * Corrected the api version. * Made properties of PATCH operation as not required. Updated the version number to reflect the actual production one. * Updated Resource properties with the correct fields. Created new definition for PATCH operation since location is not required field * Update readme file * Uses plural for operation group name * Removed x-ms-mutability settings * Removed the location settings for PATCH * Added Microsoft.ResourceGraph/SavedQuery resource type * Fixed various validation errors * Updated ARG/resources to add a saved query support along with examples * Updated ARM/resources based on the feedback * Prepared for Swagger submittion * Added saved query entry in readme.md * Changed HTTP status code of 201 to 200 for DELETE * Removed a name from payload since it is already specified in url * Removed location since it is a global resource and added eTag * Moved savedquery.json along with all examples into 2018-09-01-preview folder * Update saved query metadata in OperationsList.json * Updated readme.md file to address a version * Fixed a version for saved query * Fixed indentation of -input-file in readme * Renamed Saved => Graph * Applied PR comments * Restored extended enum value in ResultKind since we are using it * Removed the extended enum value again * Apply ARM API team comments * Fix examples * Fix examples * Added nextLinkName * add Go SDK build * make descriptions match * Added nextLink definition in OperationListResult * Removed a duplicated OperationListResult and reference to resourcegraph.json * Added nextLinkName: nextLink for x-ms-pageable in operations * fix formatting and description * Removed extended from enum * Remove nextLink from the example * Returning null for nextLink in the example so that we can preserve the existing scenario. * Removed nextLink entirely per PR comment * Update the default tag for LUIS Runtime (#5793) * Sync 2019-04-01 with "git add --renormalize ."call * Fix style issues missed by automation * Add support for availability zones for azure firewall (#5888) * [Network]: get virtualnetwork gateway vpn connection health (#5883) * [Network]: get virtualnetwork gateway vpn connection health * [Network]: get virtualnetwork gateway vpn connection health * [Network] Remove text like "Possible values are" from props that have enum (#5879) * Remove text like "Possible values are" from props that have enum * Remove additional text * Top Level Waf Resource Swagger changes, Changes in PR#5906 by yanshu + some comments addressed (#5921) * top level waf resource swagger changes, changes in PR#5906 with some comments addressed on the right branch * Update specification/network/resource-manager/Microsoft.Network/stable/2019-04-01/webapplicationfirewall.json Co-Authored-By: EvgenyAgafonchikov <evgeny.agafonchikov@akvelon.com> * Update specification/network/resource-manager/Microsoft.Network/stable/2019-04-01/webapplicationfirewall.json Co-Authored-By: EvgenyAgafonchikov <evgeny.agafonchikov@akvelon.com> * some more review comments addressed * Addressing some more review comments * addressing more review comments * Add type field to child resources. Fix routefilter reference. Add ipv6peering property (#5975) * add type field to child resources, fix routefilter def. add ipv6 peering in routefilter * updated examples * Reverting the changes done by PR #5921 (#5986) * Changes related to setting VpnClient AAD authentication options to Virtual network gateway resource & Advertising virtual Wan 2 released APIs. (#5935) * Changes related to setting VpnClient AAD authentication options to Virtual network gateway resource. * Advertising virtual Wan 2 released APIs through swagger * Incorporate code review comments * Minor format fixes * Add newly added param:usePolicyBasedTrafficSelectors to VpnConnection resource. * Updated descriptions with trailing dot (#6020) * Updated descriptions with trailing dot * Fix example * Adding PrivateEndpoint (formerly called InterfaceEndpoint) and PrivateLinkService with operations. (#5860) * rename interfaceEndpoint to privateEndpoint. * Change the PrivateEndpoint properties by following private ip design document. * modify some of array part of private endpoint and other minor fix. * Add availablePrivateEndpointTypes and its examples. * Changes for privateEndpoint example. * 1. Add default response for privateEndpoint 2. Add availablePrivateEndpointTypes to readme.md file. * Fix some error detect by autorest. * Minor fix from Azure Pipeline model validation steps. * 1. Add PrivateLinkService and its example. 2. Modify PrivateEndpoint and its example to match the PrivateLinkService. * add privateLinkService to readme.md file. * Modify/Add examples to demonstrate PrivateEndpoint with manualPrivateLinkServiceConnections. * Fix some issue found by AzurePipelines model validator. * fix for model validator error. * Typo fix. * Minor fix for PR comment and others. * delete interfaceendpoint example. * edit some of descriptions. * Add some new features for private link service. * fix the issue found by ModelValidation. * Mdofiy update privateEndpointConnection method according to spec changes. Other minor fix. * fix issue found by model validation. * no comment. * Add x-ms-client-flatten property to the nested structure. * Use SubResource instead of creating new definition (#6005) * Reduced warnings count (#6043) * Suppress "expected" warnings * Refactored ApiVersion, SubscriptionId params usage * Fixed VMSS related warnings * Resource Navigation Link and Service Association Link merge issues (#6074) * Added missed features * Fix validation issues * Mark nextLink as read only * chore: jsonfmt network 2019 (#5904) Ran `jsonfmt -w "specification/network/**/stable/2019*/**/*.json"` * Fixed common warnings (#6085) * Swagger support for Bastion Host (#6023) * Swagger support for Bastion Host * Fixing example * Incorporated feedback comment * Incorporated feedback comment * Incorporated feedback comment * Fixes for descriptions; common suppression * Removing list by vnet api as we are not going to support it * Specs for ServiceTags resource (#6084) * Specs for ServiceTags * Add description * Addressed PR feedback * Add read-only flags * Update Zones for Nat Gateway (#6096) * fixed merging conflicts

bowen0106 added 10 commits April 30, 2019 18:06

rename interfaceEndpoint to privateEndpoint.

991b6ef

Change the PrivateEndpoint properties by following private ip design …

2e042dc

…document.

modify some of array part of private endpoint and other minor fix.

5626305

Add availablePrivateEndpointTypes and its examples.

3f24239

Changes for privateEndpoint example.

936f192

1. Add default response for privateEndpoint

6759b7f

2. Add availablePrivateEndpointTypes to readme.md file.

Fix some error detect by autorest.

24c8f8e

Minor fix from Azure Pipeline model validation steps.

1b3be50

1. Add PrivateLinkService and its example.

245d863

2. Modify PrivateEndpoint and its example to match the PrivateLinkService.

add privateLinkService to readme.md file.

15692a3

bowen0106 requested a review from MikhailTryakhov as a code owner May 3, 2019 18:17

azuresdkci assigned dsgouda May 3, 2019

azuresdkci requested a review from dsgouda May 3, 2019 18:18