-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Per collection Swagger plus multiple changes to conform to fluent SDK conventions and bug fixes #595
Conversation
General comment: for the future, could you add a Swashbuckle customization to remove (same with empty consumes/produces sections) |
Could you expand this description? I'm not sure what CSM stands for |
We're starting to ask for more descriptive/useful descriptions (e.g. https://github.com/naveedaz/azure-rest-api-specs/blob/1e97be15076e600610d10be3ebb1d33f137b01d9/arm-web/2016-03-01/AppServiceCertificateOrders.json#L333 could provide more information about the parameter). I think instead of blocking this PR, I'd like to provide some slides from the documentation team that go into what they ask for. Let's plan on doing a doc quality pass in a future PR |
Added an issue to track removal of sections that are repeated and have default values. #601 |
@tbombach For Documentation, we have been trying to enlist help from technical writers to clean it up and make it useful and descriptive. However, those resources were pulled into different projects, once we have them back we can address documentation issues more thoroughly. In the meantime, please do fwd the slides. |
@naveedaz Re: documentation - yes, I definitely understand. I want to bring up these kinds of issues for awareness that we want to tackle them, but we'll focus on getting this PR merged based for the scope of the fixes you listed (I'm through about half of the files right now) |
In https://github.com/naveedaz/azure-rest-api-specs/blob/1e97be15076e600610d10be3ebb1d33f137b01d9/arm-web/2016-03-01/AppServiceCertificateOrders.json#L324, the ResourceGroupName parameter is defined each time it's used in an operation. You can define it in the global parameters section and use x-ms-parameter-location: 'method' so that it's a method parameter anywhere it's referenced, not a property on the service client If you'd rather fix that in a future PR (if it's outside the scope for this one), please open an issue for tracking it. It's not something that would prevent me from merging this one, and it might take a fair amount of work to change it for all specs |
Thanks @tbombach. This PR is kind of a big reset, so future PRs should be smaller and more contained. |
@naveedaz Is it helpful to include comments in this PR for these issues as I see them? I understand that the goal of this one isn't to fix all of these issues, so I'd like to provide this info to you in an easy way for you to consume for later PRs. I'd be happy to open the issues myself if that saves you some time |
No modification for Ruby |
No modification for NodeJS |
No modification for Python |
PR information
api-version
in the path should match theapi-version
in the spec).Quality of Swagger