ARM spec review for validateAddress for BillingRP #6010

sarang-amondikar · 2019-05-17T19:16:39Z

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.
The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

AutorestCI · 2019-05-17T19:17:25Z

Automation for azure-sdk-for-ruby

Encountered a Subprocess error: (azure-sdk-for-ruby)

Command: ['/usr/local/bin/autorest', '/tmp/tmpqz2enl4d/rest/specification/billing/resource-manager/readme.md', '--perform-load=false', '--swagger-to-sdk', '--output-artifact=configuration.json', '--input-file=foo', '--output-folder=/tmp/tmpb_i9a0nq']
Finished with return code 7
and output:

AutoRest code generation utility [version: 2.0.4283; node: v8.12.0]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest
Failure:
Error: Unable to start AutoRest Core from /root/.autorest/@microsoft.azure_autorest-core@2.0.4370/node_modules/@microsoft.azure/autorest-core
Error: Unable to start AutoRest Core from /root/.autorest/@microsoft.azure_autorest-core@2.0.4370/node_modules/@microsoft.azure/autorest-core
    at main (/opt/node_modules/autorest/dist/app.js:232:19)
    at <anonymous>

/root/.autorest/@microsoft.azure_autorest-core@2.0.4370/node_modules/@microsoft.azure/autorest-core/dist/app.js:33
    autorest_core_1.Shutdown();
    ^
ReferenceError: autorest_core_1 is not defined
    at process.on (/root/.autorest/@microsoft.azure_autorest-core@2.0.4370/node_modules/@microsoft.azure/autorest-core/dist/app.js:33:5)
    at emitOne (events.js:121:20)
    at process.emit (events.js:211:7)
    at process.emit (/node_modules/source-map-support/source-map-support.js:439:21)
fs.js:612
  return binding.close(fd);
                 ^

Error: EBADF: bad file descriptor, close
    at Object.fs.closeSync (fs.js:612:18)
    at StaticVolumeFile.shutdown (/opt/node_modules/autorest/dist/static-loader.js:352:10)
    at StaticFilesystem.shutdown (/opt/node_modules/autorest/dist/static-loader.js:406:17)
    at process.exit.n [as exit] (/opt/node_modules/autorest/dist/static-loader.js:169:11)
    at printErrorAndExit (/node_modules/source-map-support/source-map-support.js:423:11)
    at process.emit (/node_modules/source-map-support/source-map-support.js:435:16)
    at process._fatalException (bootstrap_node.js:391:26)

AutorestCI · 2019-05-17T19:17:39Z

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#3853

AutorestCI · 2019-05-17T19:17:45Z

Automation for azure-sdk-for-js

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-js#3102

AutorestCI · 2019-05-17T19:19:23Z

Automation for azure-sdk-for-go

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-go#4849

AutorestCI · 2019-05-17T19:20:10Z

Automation for azure-sdk-for-java

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-java#3207

REST Spec PR 'Azure/azure-rest-api-specs#6010' REST Spec PR Author 'sarang-amondikar' REST Spec PR Last commit

adxsdknet · 2019-05-17T19:23:36Z

Automation for azure-sdk-for-net

A PR has been created for you:
Azure/azure-sdk-for-net#6319
.NET SDK Commits:
adxsdknet/azure-sdk-for-net@7194320

azuresdkci · 2019-05-17T19:31:06Z

Can one of the admins verify this patch?

ravbhatnagar

just one minor question

ravbhatnagar · 2019-05-21T18:33:45Z

...ification/billing/resource-manager/Microsoft.Billing/preview/2018-11-01-preview/billing.json

+          "$ref": "#/definitions/Address"
+        }
+      },
+      "validationMessage" : {


why is validation error message part of the request body. If the validation on an address fails, shouldnt it return an error with the details part of the error body which complies with the ARM RPC error contract

Validation error message is not part of request body. If AV fails, it returns a message in ValidationMessage property which is a part of Response object.

sorry i meant response body itself. What i meant is -> if POST /validateAddress fails to validate an address, shouldnt the response should be a failure? In the current model, the response will be a successful response, with the validation failure in the response body.

oh, yes, it always responds with 200, we internally call into other service which always returns 200, with validation results in response body. We apply some business logic and return 200.

ok, thanks for confirming.

Merge from master repo

ARM spec review for validateAddress

750169f

sarang-amondikar added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label May 17, 2019

sarang-amondikar requested a review from wilcobmsft as a code owner May 17, 2019 19:16

AutorestCI mentioned this pull request May 17, 2019

[AutoPR billing/resource-manager] ARM spec review for validateAddress for BillingRP Azure/azure-sdk-for-python#5300

Closed

AutorestCI mentioned this pull request May 17, 2019

[AutoPR billing/resource-manager] ARM spec review for validateAddress for BillingRP Azure/azure-sdk-for-js#2987

Closed

azuresdkci assigned kpajdzik May 17, 2019

azuresdkci requested a review from kpajdzik May 17, 2019 19:18

AutorestCI mentioned this pull request May 17, 2019

[AutoPR billing/resource-manager] ARM spec review for validateAddress for BillingRP Azure/azure-sdk-for-go#4826

Closed

AutorestCI mentioned this pull request May 17, 2019

[AutoPR billing/resource-manager] ARM spec review for validateAddress for BillingRP Azure/azure-sdk-for-java#3687

Closed

adxsdknet added a commit to adxsdknet/azure-sdk-for-net that referenced this pull request May 17, 2019

.NET SDK Resource Provider:'Billing'

7194320

REST Spec PR 'Azure/azure-rest-api-specs#6010' REST Spec PR Author 'sarang-amondikar' REST Spec PR Last commit

kpajdzik approved these changes May 20, 2019

View reviewed changes

ravbhatnagar reviewed May 21, 2019

View reviewed changes

sarang-amondikar and others added 2 commits May 21, 2019 14:42

Merge pull request #1 from Azure/master

68cb895

Merge from master repo

resolved merge conflicts

f300664

This was referenced May 21, 2019

[AutoPR billing/resource-manager] ARM spec review for validateAddress for BillingRP Azure/azure-sdk-for-python#5392

Merged

[AutoPR billing/resource-manager] ARM spec review for validateAddress for BillingRP Azure/azure-sdk-for-js#3100

Merged

kpajdzik merged commit c512fa2 into Azure:master May 21, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ARM spec review for validateAddress for BillingRP #6010

ARM spec review for validateAddress for BillingRP #6010

sarang-amondikar commented May 17, 2019 •

edited

Loading

AutorestCI commented May 17, 2019 •

edited

Loading

AutorestCI commented May 17, 2019 •

edited

Loading

AutorestCI commented May 17, 2019 •

edited

Loading

AutorestCI commented May 17, 2019 •

edited

Loading

AutorestCI commented May 17, 2019 •

edited

Loading

adxsdknet commented May 17, 2019

azuresdkci commented May 17, 2019

ravbhatnagar left a comment

ravbhatnagar May 21, 2019

sarang-amondikar May 21, 2019

ravbhatnagar May 21, 2019

sarang-amondikar May 21, 2019

ravbhatnagar May 21, 2019

ARM spec review for validateAddress for BillingRP #6010

ARM spec review for validateAddress for BillingRP #6010

Conversation

sarang-amondikar commented May 17, 2019 • edited Loading

Latest improvements:

Contribution checklist:

ARM API Review Checklist

AutorestCI commented May 17, 2019 • edited Loading

Automation for azure-sdk-for-ruby

AutorestCI commented May 17, 2019 • edited Loading

Automation for azure-sdk-for-python

AutorestCI commented May 17, 2019 • edited Loading

Automation for azure-sdk-for-js

AutorestCI commented May 17, 2019 • edited Loading

Automation for azure-sdk-for-go

AutorestCI commented May 17, 2019 • edited Loading

Automation for azure-sdk-for-java

adxsdknet commented May 17, 2019

Automation for azure-sdk-for-net

azuresdkci commented May 17, 2019

ravbhatnagar left a comment

Choose a reason for hiding this comment

ravbhatnagar May 21, 2019

Choose a reason for hiding this comment

sarang-amondikar May 21, 2019

Choose a reason for hiding this comment

ravbhatnagar May 21, 2019

Choose a reason for hiding this comment

sarang-amondikar May 21, 2019

Choose a reason for hiding this comment

ravbhatnagar May 21, 2019

Choose a reason for hiding this comment

sarang-amondikar commented May 17, 2019 •

edited

Loading

AutorestCI commented May 17, 2019 •

edited

Loading

AutorestCI commented May 17, 2019 •

edited

Loading

AutorestCI commented May 17, 2019 •

edited

Loading

AutorestCI commented May 17, 2019 •

edited

Loading

AutorestCI commented May 17, 2019 •

edited

Loading