Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ACR] Support Overriding Task parameters, support for ContinuationToken [NEW preview API VERSION] #6038

Merged
merged 27 commits into from
Jun 28, 2019
Merged

[ACR] Support Overriding Task parameters, support for ContinuationToken [NEW preview API VERSION] #6038

merged 27 commits into from
Jun 28, 2019

Conversation

shahzzzam
Copy link
Contributor

@shahzzzam shahzzzam commented May 21, 2019 •
edited
Loading

Introduces the API version 2019-06-01-preview for ACR Tasks.

  • OverrideTaskStepProperties for a TaskRunRequest - You can now override some properties when you created the Task. But you can now also override them.
  • updateTriggerToken, updateTriggerEndpoint, updateTriggerPayloadType properties for Break-the-loop
  • taskName -> taskId as a required property for Task run.
  • Adds arm64 and 386 to list of supported platforms.

Diff against previous swagger

You can diff it against stable/2019-04-01 swagger.

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@AutorestCI
Copy link

AutorestCI commented May 21, 2019 •
edited
Loading

Automation for azure-sdk-for-ruby

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-ruby#2594

@shahzzzam shahzzzam changed the title Shahzzam/add 2019 06 01 [ACR] Support Overriding Task parameters, support for ContinuationToken [NEW API VERSION] May 21, 2019
@AutorestCI
Copy link

AutorestCI commented May 21, 2019 •
edited
Loading

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#5950

@AutorestCI AutorestCI mentioned this pull request May 21, 2019
Closed
@AutorestCI
Copy link

AutorestCI commented May 21, 2019 •
edited
Loading

Automation for azure-sdk-for-js

A PR has been created for you:
Azure/azure-sdk-for-js#3884

@shahzzzam
Copy link
Contributor Author

@tjprescott is there any issue going on with azure-sdk-for-python and azure-sdk-for-ruby right now? Locally, I was able to create the SDK for python without any issues.
// cc: @jaysterp @northtyphoon

@AutorestCI
Copy link

AutorestCI commented May 21, 2019 •
edited
Loading

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#5158

@AutorestCI AutorestCI mentioned this pull request May 21, 2019
Closed
@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@azuresdkci azuresdkci requested a review from kpajdzik May 21, 2019 00:32
adxsdknet added a commit to adxsdknet/azure-sdk-for-net that referenced this pull request May 21, 2019
@adxsdknet
.NET SDK Resource Provider:'ContainerRegistry'
95b3ba5 
REST Spec PR 'Azure/azure-rest-api-specs#6038'
REST Spec PR Author 'shahzzzam'
REST Spec PR Last commit
@adxsdknet
Copy link

adxsdknet commented May 21, 2019 •
edited
Loading

Automation for azure-sdk-for-net

A PR has been created for you:
Azure/azure-sdk-for-net#6345
.NET SDK Commits:
adxsdknet/azure-sdk-for-net@95b3ba5
adxsdknet/azure-sdk-for-net@d1768ed
adxsdknet/azure-sdk-for-net@f73851a

@AutorestCI AutorestCI mentioned this pull request May 21, 2019
Merged
@AutorestCI
Copy link

AutorestCI commented May 21, 2019 •
edited
Loading

Automation for azure-sdk-for-java

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-java#3165

@kpajdzik kpajdzik added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label May 21, 2019
@AutorestCI AutorestCI mentioned this pull request May 22, 2019
Closed
@shahzzzam
Copy link
Contributor Author

shahzzzam commented Jun 19, 2019 •
edited
Loading

@kpajdzik Thanks. Fixed it. Let me know. The other ModelValidation issue seems to be a problem from rest-api-specs side. See #6221

If it looks okay, can you merge it? Or @ someone from ARM who can? Thanks in advance

@kpajdzik
Copy link
Contributor

@kpajdzik Thanks. Fixed it. Let me know. The other ModelValidation issue seems to be a problem from rest-api-specs side. See #6221

If it looks okay, can you merge it? Or @ someone from ARM who can? Thanks in advance

I'll merge it as soon as ARM team approves it. @RyanBensonMSFT, any updates here?

@shahzzzam
Copy link
Contributor Author

@RyanBensonMSFT did you get a chance to review this? We kind of want to get this out in the next AZ CLI release (with new Python SDK). Thanks!

@shahzzzam
Copy link
Contributor Author

@kpajdzik anyone else you know that can approve this? it's been two days.

@kpajdzik
Copy link
Contributor

@KrisBash, can this be reassigned to someone else from ARM team?

@ravbhatnagar
Copy link
Contributor

@kpajdzik - I will review this from ARM side shortly.

@ravbhatnagar
Copy link
Contributor

ravbhatnagar commented Jun 25, 2019 •
edited
Loading

Looks good. The previous API version with which this needs to be compared with is 2019-04-01 instead of 2019-05-01. Signing off from ARM side.

@ravbhatnagar ravbhatnagar added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Jun 25, 2019
@shahzzzam
Copy link
Contributor Author

@kpajdzik Hi Kamil, Can you please merge it?

@kpajdzik
Copy link
Contributor

@kpajdzik Hi Kamil, Can you please merge it?

What about OBJECT_ADDITIONAL_PROPERTIES errors in Model Validation?

@shahzzzam
Copy link
Contributor Author

@kpajdzik yup please refer to this: #6221

@shahzzzam
Copy link
Contributor Author

@amarzavery I think the only errors remaining are now OBJECT_ADDITIONAL_PROPERTIES. Let me know if something needs to be changed.

@kpajdzik
Copy link
Contributor

@amarzavery, Can you admin-merge if everything looks alright to you?

@kpajdzik kpajdzik merged commit 91c6342 into Azure:master Jun 28, 2019
celikcigdem pushed a commit to celikcigdem/azure-rest-api-specs that referenced this pull request Jul 17, 2019
@shahzzzam @celikcigdem
[ACR] Support Overriding Task parameters, support for ContinuationTok…
5dd71ca 
…en [NEW preview API VERSION] (Azure#6038)

* add 2019-06-01 api swagger with examples

* add 2019-06-01 api swagger with examples

* trigger new ci build

* add arm64 enum

* add includeTriggerMetadata

* rename variables

* add updateTriggerToken to run properties

* move 2019-06-01 to preview

* update examples

* revert 'Resource' definition

* update examples

* address comments

* remove readonly properties from request

* remove readonly properties from request

* remove readonly peoperty

* remove readonly peoperty
LGDoor pushed a commit that referenced this pull request Jan 29, 2022
@sophiaso
Merge pull request #6038 from Azure/appplatform/wepa/swagger-add-star…
87cf716 
…ting-stopping-on-dev

[AutoSync] Swagger updates for appplatform/wepa/swagger-add-starting-stopping-on-dev
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryansbenson ryansbenson ryansbenson left review comments

@sanjaiganesh sanjaiganesh sanjaiganesh left review comments

@amarzavery amarzavery amarzavery left review comments

@ankurkhemani ankurkhemani ankurkhemani approved these changes

@kpajdzik kpajdzik kpajdzik approved these changes

@northtyphoon northtyphoon northtyphoon approved these changes

Assignees

@kpajdzik kpajdzik

Labels
ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.