Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduced warnings count #6043

Merged
merged 3 commits into from
May 22, 2019
Merged

Reduced warnings count #6043

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6bd17fa
Suppress "expected" warnings
EvgenyAgafonchikov May 20, 2019
5d012c7
Refactored ApiVersion, SubscriptionId params usage
EvgenyAgafonchikov May 20, 2019
799f60a
Fixed VMSS related warnings
EvgenyAgafonchikov May 20, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 2 additions & 18 deletions ...on/network/resource-manager/Microsoft.Network/stable/2019-04-01/azureFirewallFqdnTag.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,10 +43,10 @@
"description":"Gets all the Azure Firewall FQDN Tags in a subscription.",
"parameters":[
{
"$ref":"#/parameters/ApiVersionParameter"
"$ref": "./network.json#/parameters/ApiVersionParameter"
},
{
"$ref":"#/parameters/SubscriptionIdParameter"
"$ref": "./network.json#/parameters/SubscriptionIdParameter"
}
],
"responses":{
Expand Down Expand Up @@ -120,21 +120,5 @@
},
"description":"Response for ListAzureFirewallFqdnTags API service call."
}
},
"parameters": {
"SubscriptionIdParameter": {
"name": "subscriptionId",
"in": "path",
"required": true,
"type": "string",
"description": "The subscription credentials which uniquely identify the Microsoft Azure subscription. The subscription ID forms part of the URI for every service call."
},
"ApiVersionParameter": {
"name": "api-version",
"in": "query",
"required": true,
"type": "string",
"description": "Client API version."
}
}
}
14 changes: 14 additions & 0 deletions specification/network/resource-manager/Microsoft.Network/stable/2019-04-01/network.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -282,6 +282,20 @@
"required": true,
"type": "string",
"description": "Client API version."
},
"ApiVersionVmssParameter": {
"name": "api-version",
"in": "query",
"required": true,
"type": "string",
"enum": [
"2017-03-30"
],
"x-ms-enum": {
"name": "ApiVersion",
"modelAsString": true
},
"description": "Client API version."
}
}
}
22 changes: 3 additions & 19 deletions ...ation/network/resource-manager/Microsoft.Network/stable/2019-04-01/virtualNetworkTap.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -301,8 +301,8 @@
}
}
}
},
"definitions": {
},
"definitions": {
"VirtualNetworkTap": {
"properties": {
"properties": {
Expand Down Expand Up @@ -374,21 +374,5 @@
},
"description": "Response for ListVirtualNetworkTap API service call."
}
},
"parameters": {
"SubscriptionIdParameter": {
"name": "subscriptionId",
"in": "path",
"required": true,
"type": "string",
"description": "The subscription credentials which uniquely identify the Microsoft Azure subscription. The subscription ID forms part of the URI for every service call."
},
"ApiVersionParameter": {
"name": "api-version",
"in": "query",
"required": true,
"type": "string",
"description": "Client API version."
}
}
}
}
65 changes: 5 additions & 60 deletions ...on/network/resource-manager/Microsoft.Network/stable/2019-04-01/vmssNetworkInterface.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,18 +64,7 @@
"description": "The virtual machine index."
},
{
"name": "api-version",
"in": "query",
"required": true,
"type": "string",
"enum": [
"2017-03-30"
],
"x-ms-enum": {
"name": "ApiVersion",
"modelAsString": true
},
"description": "Client API version."
"$ref": "./network.json#/parameters/ApiVersionVmssParameter"
},
{
"$ref": "./network.json#/parameters/SubscriptionIdParameter"
Expand Down Expand Up @@ -120,18 +109,7 @@
"description": "The name of the virtual machine scale set."
},
{
"name": "api-version",
"in": "query",
"required": true,
"type": "string",
"enum": [
"2017-03-30"
],
"x-ms-enum": {
"name": "ApiVersion",
"modelAsString": true
},
"description": "Client API version."
"$ref": "./network.json#/parameters/ApiVersionVmssParameter"
},
{
"$ref": "./network.json#/parameters/SubscriptionIdParameter"
Expand Down Expand Up @@ -190,18 +168,7 @@
"description": "The name of the network interface."
},
{
"name": "api-version",
"in": "query",
"required": true,
"type": "string",
"enum": [
"2017-03-30"
],
"x-ms-enum": {
"name": "ApiVersion",
"modelAsString": true
},
"description": "Client API version."
"$ref": "./network.json#/parameters/ApiVersionVmssParameter"
},
{
"$ref": "./network.json#/parameters/SubscriptionIdParameter"
Expand Down Expand Up @@ -264,18 +231,7 @@
"description": "The name of the network interface."
},
{
"name": "api-version",
"in": "query",
"required": true,
"type": "string",
"enum": [
"2017-03-30"
],
"x-ms-enum": {
"name": "ApiVersion",
"modelAsString": true
},
"description": "Client API version."
"$ref": "./network.json#/parameters/ApiVersionVmssParameter"
},
{
"$ref": "./network.json#/parameters/SubscriptionIdParameter"
Expand Down Expand Up @@ -348,18 +304,7 @@
"description": "The name of the ip configuration."
},
{
"name": "api-version",
"in": "query",
"required": true,
"type": "string",
"enum": [
"2017-03-30"
],
"x-ms-enum": {
"name": "ApiVersion",
"modelAsString": true
},
"description": "Client API version."
"$ref": "./network.json#/parameters/ApiVersionVmssParameter"
},
{
"$ref": "./network.json#/parameters/SubscriptionIdParameter"
Expand Down
39 changes: 3 additions & 36 deletions ...ion/network/resource-manager/Microsoft.Network/stable/2019-04-01/vmssPublicIpAddress.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,18 +54,7 @@
"description": "The name of the virtual machine scale set."
},
{
"name": "api-version",
"in": "query",
"required": true,
"type": "string",
"enum": [
"2017-03-30"
],
"x-ms-enum": {
"name": "ApiVersion",
"modelAsString": true
},
"description": "Client API version."
"$ref": "./network.json#/parameters/ApiVersionVmssParameter"
},
{
"$ref": "./network.json#/parameters/SubscriptionIdParameter"
Expand Down Expand Up @@ -128,18 +117,7 @@
"description": "The IP configuration name."
},
{
"name": "api-version",
"in": "query",
"required": true,
"type": "string",
"enum": [
"2017-03-30"
],
"x-ms-enum": {
"name": "ApiVersion",
"modelAsString": true
},
"description": "Client API version."
"$ref": "./network.json#/parameters/ApiVersionVmssParameter"
},
{
"$ref": "./network.json#/parameters/SubscriptionIdParameter"
Expand Down Expand Up @@ -209,18 +187,7 @@
"description": "The name of the public IP Address."
},
{
"name": "api-version",
"in": "query",
"required": true,
"type": "string",
"enum": [
"2017-03-30"
],
"x-ms-enum": {
"name": "ApiVersion",
"modelAsString": true
},
"description": "Client API version."
"$ref": "./network.json#/parameters/ApiVersionVmssParameter"
},
{
"$ref": "./network.json#/parameters/SubscriptionIdParameter"
Expand Down
30 changes: 7 additions & 23 deletions .../network/resource-manager/Microsoft.Network/stable/2019-04-01/webapplicationfirewall.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,10 +55,10 @@
"description": "The name of the resource group."
},
{
"$ref": "#/parameters/SubscriptionIdParameter"
"$ref": "./network.json#/parameters/SubscriptionIdParameter"
},
{
"$ref": "#/parameters/ApiVersionParameter"
"$ref": "./network.json#/parameters/ApiVersionParameter"
}
],
"responses": {
Expand Down Expand Up @@ -136,10 +136,10 @@
"description": "The name of the policy."
},
{
"$ref": "#/parameters/SubscriptionIdParameter"
"$ref": "./network.json#/parameters/SubscriptionIdParameter"
},
{
"$ref": "#/parameters/ApiVersionParameter"
"$ref": "./network.json#/parameters/ApiVersionParameter"
}
],
"responses": {
Expand Down Expand Up @@ -179,7 +179,7 @@
"description": "The name of the policy."
},
{
"$ref": "#/parameters/SubscriptionIdParameter"
"$ref": "./network.json#/parameters/SubscriptionIdParameter"
},
{
"description": "Policy to be created.",
Expand Down Expand Up @@ -237,10 +237,10 @@
"description": "The name of the policy."
},
{
"$ref": "#/parameters/SubscriptionIdParameter"
"$ref": "./network.json#/parameters/SubscriptionIdParameter"
},
{
"$ref": "#/parameters/ApiVersionParameter"
"$ref": "./network.json#/parameters/ApiVersionParameter"
}
],
"responses": {
Expand Down Expand Up @@ -533,21 +533,5 @@
}
}
}
},
"parameters": {
"SubscriptionIdParameter": {
"name": "subscriptionId",
"in": "path",
"required": true,
"type": "string",
"description": "The subscription credentials which uniquely identify the Microsoft Azure subscription. The subscription ID forms part of the URI for every service call."
},
"ApiVersionParameter": {
"name": "api-version",
"in": "query",
"required": true,
"type": "string",
"description": "Client API version."
}
}
}
42 changes: 42 additions & 0 deletions specification/network/resource-manager/readme.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1012,6 +1012,48 @@ directive:
- suppress: RequiredPropertiesMissingInResourceModel
from: webapplicationfirewall.json
reason: name, id and type properties are inherited from the upper level
- suppress: PostOperationIdContainsUrlVerb
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@EvgenyAgafonchikov were these suppressions approved?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+@ravbhatnagar, could you please review?

Mostly this suppresses warnings for operations using custom verbs. These changes are already released in SDKs and related warnings currently overcrowd validator's output that may lead to missing of the new entries.

where: $.paths["/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Network/applicationGateways/{applicationGatewayName}/getBackendHealthOnDemand"].post.operationId
reason: Customized verb is used for API
- suppress: PostOperationIdContainsUrlVerb
where: $.paths["/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Network/virtualWans/{virtualWANName}/vpnConfiguration"].post.operationId
reason: Customized verb is used for API
- suppress: ListInOperationName
where: $.paths["/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Network/applicationGateways/{applicationGatewayName}/backendhealth"].post.operationId
reason: Customized verb is used for API
- suppress: ListInOperationName
where: $.paths["/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Network/networkInterfaces/{networkInterfaceName}/effectiveRouteTable"].post.operationId
reason: Customized verb is used for API
- suppress: ListInOperationName
where: $.paths["/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Network/networkWatchers/{networkWatcherName}/securityGroupView"].post.operationId
reason: Customized verb is used for API
- suppress: ListInOperationName
where: $.paths["/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Network/networkWatchers/{networkWatcherName}/connectionMonitors/{connectionMonitorName}/query"].post.operationId
reason: Customized verb is used for API
- suppress: ListInOperationName
where: $.paths["/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Network/networkWatchers/{networkWatcherName}/networkConfigurationDiagnostic"].post.operationId
reason: Customized verb is used for API
- suppress: ListInOperationName
where: $.paths["/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Network/virtualNetworks/{virtualNetworkName}/CheckIPAddressAvailability"].get.operationId
reason: Customized verb is used for API
- suppress: ListInOperationName
where: $.paths["/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Network/virtualNetworkGateways/{virtualNetworkGatewayName}/getBgpPeerStatus"].post.operationId
reason: Customized verb is used for API
- suppress: ListInOperationName
where: $.paths["/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Network/virtualNetworkGateways/{virtualNetworkGatewayName}/getLearnedRoutes"].post.operationId
reason: Customized verb is used for API
- suppress: ListInOperationName
where: $.paths["/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Network/virtualNetworkGateways/{virtualNetworkGatewayName}/getAdvertisedRoutes"].post.operationId
reason: Customized verb is used for API
- suppress: ListInOperationName
where: $.paths["/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Network/virtualNetworkGateways/{virtualNetworkGatewayName}/getVpnClientConnectionHealth"].post.operationId
reason: Customized verb is used for API
- suppress: ListInOperationName
where: $.paths["/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Network/virtualWans/{virtualWANName}/supportedSecurityProviders"].get.operationId
reason: Customized verb is used for API
- suppress: GetInOperationName
where: $.paths["/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Network/virtualWans/{virtualWANName}/supportedSecurityProviders"].get.operationId
reason: Customized verb is used for API
```

---
Expand Down