Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding usage id property to support usages by VM family, Workspace & Compute #6055

Merged
merged 2 commits into from
May 23, 2019

Conversation

leizhaoPS
Copy link
Contributor

@leizhaoPS leizhaoPS commented May 21, 2019

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@AutorestCI
Copy link

AutorestCI commented May 21, 2019

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

@AutorestCI
Copy link

AutorestCI commented May 21, 2019

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#5456

@AutorestCI
Copy link

AutorestCI commented May 21, 2019

Automation for azure-sdk-for-js

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-js#3160

@AutorestCI
Copy link

AutorestCI commented May 21, 2019

Automation for azure-sdk-for-go

Nothing to generate for azure-sdk-for-go

@dsgouda
Copy link
Contributor

dsgouda commented May 21, 2019

Please fix the model validation errors here

@AutorestCI
Copy link

AutorestCI commented May 21, 2019

Automation for azure-sdk-for-java

Nothing to generate for azure-sdk-for-java

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@leizhaoPS
Copy link
Contributor Author

Please fix the model validation errors here

The modelvalidation failure is not related to my changes, it is related to a check-in by nschonni@gmail.com on MachineLearningCompute_Update

@leizhaoPS
Copy link
Contributor Author

@dsgouda dsgouda , any suggestion to skip the validation failure not related to my changes? Thanks a lot!

Copy link
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dsgouda
Copy link
Contributor

dsgouda commented May 22, 2019

@leizhaoPS @nschonni 's changes were only related to formatting and should not have introduced any errors. Please check if you can fix the example at your end.

Copy link
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sergey-shandar sergey-shandar merged commit 6d348f4 into Azure:master May 23, 2019
leizhaoPS added a commit to leizhaoPS/azure-rest-api-specs that referenced this pull request May 31, 2019
@leizhaoPS
Copy link
Contributor Author

@sergey-shandar quick question, why my PR was merged, this PR should hold until the feature code check-in

@dsgouda
Copy link
Contributor

dsgouda commented May 31, 2019

@leizhaoPS I wasn't aware this was not to be merged. Please open a PR to revert these changes and I will do the needful.
Please mark the title as [DO NOT MERGE] in future so we don't accidentally merge it.

@leizhaoPS
Copy link
Contributor Author

@dsgouda , Thanks for explain, I will mark it in my new PR

@leizhaoPS
Copy link
Contributor Author

@dsgouda , I sent the revert PR, please help revert the changes: #6171, one more question is how can I add reviewers and add label "WaitForARMFeedback"

sergey-shandar pushed a commit that referenced this pull request May 31, 2019
@leizhaoPS
Copy link
Contributor Author

leizhaoPS commented May 31, 2019

@dsgouda , new PR created: #6173, please help add WaitForARMFeedback able and add Gaurav Bhatnagar Gaurav.Bhatnagar@microsoft.com; Sanjai Ganesh Jeenagiri sanjaiga@microsoft.com as review.
Thanks a lot for quick response and explain and revert the merge, I am really appropriate it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants