-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding usage id property to support usages by VM family, Workspace & Compute #6055
Adding usage id property to support usages by VM family, Workspace & Compute #6055
Conversation
Automation for azure-sdk-for-rubyNothing to generate for azure-sdk-for-ruby |
Automation for azure-sdk-for-pythonThe initial PR has been merged into your service PR: |
Automation for azure-sdk-for-jsThe initial PR has been merged into your service PR: |
Automation for azure-sdk-for-goNothing to generate for azure-sdk-for-go |
Please fix the model validation errors here |
Automation for azure-sdk-for-javaNothing to generate for azure-sdk-for-java |
Can one of the admins verify this patch? |
The modelvalidation failure is not related to my changes, it is related to a check-in by nschonni@gmail.com on MachineLearningCompute_Update |
@dsgouda dsgouda , any suggestion to skip the validation failure not related to my changes? Thanks a lot! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@leizhaoPS @nschonni 's changes were only related to formatting and should not have introduced any errors. Please check if you can fix the example at your end. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…space & Compute (Azure#6055)" This reverts commit 6d348f4.
@sergey-shandar quick question, why my PR was merged, this PR should hold until the feature code check-in |
@leizhaoPS I wasn't aware this was not to be merged. Please open a PR to revert these changes and I will do the needful. |
@dsgouda , Thanks for explain, I will mark it in my new PR |
@dsgouda , new PR created: #6173, please help add WaitForARMFeedback able and add Gaurav Bhatnagar Gaurav.Bhatnagar@microsoft.com; Sanjai Ganesh Jeenagiri sanjaiga@microsoft.com as review. |
Latest improvements:
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
ARM API Review Checklist
Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.
Please follow the link to find more details on API review process.