Custom properties were updated to reflect all the possible values #6249

promoisha · 2019-06-06T21:11:37Z

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.
The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

openapi-sdkautomation · 2019-06-06T21:11:39Z

SDK Automation [Logs] (Generated from 50d490c)

Go: Azure/azure-sdk-for-go

Package generation pending.

Python: Azure/azure-sdk-for-python

Package generation pending.

JavaScript: Azure/azure-sdk-for-js

Package generation pending.

Ruby: Azure/azure-sdk-for-ruby

Package generation pending.

AutorestCI · 2019-06-06T21:12:53Z

Automation for azure-sdk-for-java

Encountered a Subprocess error: (azure-sdk-for-java)

Command: ['/usr/local/bin/autorest', '/tmp/tmpolxj39rh/rest/specification/apimanagement/resource-manager/readme.md', '--perform-load=false', '--swagger-to-sdk', '--output-artifact=configuration.json', '--input-file=foo', '--output-folder=/tmp/tmp8_45yyx9']
Finished with return code 7
and output:

AutoRest code generation utility [version: 2.0.4283; node: v8.12.0]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest
Failure:
Error: Unable to start AutoRest Core from /root/.autorest/@microsoft.azure_autorest-core@2.0.4373/node_modules/@microsoft.azure/autorest-core
Error: Unable to start AutoRest Core from /root/.autorest/@microsoft.azure_autorest-core@2.0.4373/node_modules/@microsoft.azure/autorest-core
    at main (/opt/node_modules/autorest/dist/app.js:232:19)
    at <anonymous>

/root/.autorest/@microsoft.azure_autorest-core@2.0.4373/node_modules/@microsoft.azure/autorest-core/dist/app.js:33
    autorest_core_1.Shutdown();
    ^
ReferenceError: autorest_core_1 is not defined
    at process.on (/root/.autorest/@microsoft.azure_autorest-core@2.0.4373/node_modules/@microsoft.azure/autorest-core/dist/app.js:33:5)
    at emitOne (events.js:121:20)
    at process.emit (events.js:211:7)
    at process.emit (/node_modules/source-map-support/source-map-support.js:439:21)
fs.js:612
  return binding.close(fd);
                 ^

Error: EBADF: bad file descriptor, close
    at Object.fs.closeSync (fs.js:612:18)
    at StaticVolumeFile.shutdown (/opt/node_modules/autorest/dist/static-loader.js:352:10)
    at StaticFilesystem.shutdown (/opt/node_modules/autorest/dist/static-loader.js:406:17)
    at process.exit.n [as exit] (/opt/node_modules/autorest/dist/static-loader.js:169:11)
    at printErrorAndExit (/node_modules/source-map-support/source-map-support.js:423:11)
    at process.emit (/node_modules/source-map-support/source-map-support.js:435:16)
    at process._fatalException (bootstrap_node.js:391:26)

AutorestCI · 2019-06-06T21:13:24Z

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#5754

azuresdkci · 2019-06-06T21:13:36Z

Can one of the admins verify this patch?

AutorestCI · 2019-06-06T21:13:53Z

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

AutorestCI · 2019-06-06T21:17:10Z

Automation for azure-sdk-for-js

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-js#3595

AutorestCI · 2019-06-06T21:19:51Z

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#4979

solankisamir · 2019-06-06T21:20:54Z

...apimanagement/resource-manager/Microsoft.ApiManagement/stable/2019-01-01/apimdeployment.json

@@ -1065,7 +1065,7 @@
          "additionalProperties": {
            "type": "string"
          },
-          "description": "Custom properties of the API Management service. Setting `Microsoft.WindowsAzure.ApiManagement.Gateway.Security.Ciphers.TripleDes168` will disable the cipher TLS_RSA_WITH_3DES_EDE_CBC_SHA for all TLS(1.0, 1.1 and 1.2). Setting `Microsoft.WindowsAzure.ApiManagement.Gateway.Security.Protocols.Tls11` can be used to disable just TLS 1.1 and setting `Microsoft.WindowsAzure.ApiManagement.Gateway.Security.Protocols.Tls10` can be used to disable TLS 1.0 on an API Management service."
+          "description": "Custom properties of the API Management service. Setting `Microsoft.WindowsAzure.ApiManagement.Gateway.Security.Ciphers.TripleDes168` will disable the cipher TLS_RSA_WITH_3DES_EDE_CBC_SHA for all TLS(1.0, 1.1 and 1.2). Setting `Microsoft.WindowsAzure.ApiManagement.Gateway.Security.Protocols.Tls11` can be used to disable just TLS 1.1. Setting `Microsoft.WindowsAzure.ApiManagement.Gateway.Security.Protocols.Tls10` can be used to disable TLS 1.0 on an API Management service. Setting `Microsoft.WindowsAzure.ApiManagement.Gateway.Security.Backend.Protocols.Tls11` can be used to disable just TLS 1.1 for communications with backends. Setting `Microsoft.WindowsAzure.ApiManagement.Gateway.Security.Backend.Protocols.Tls10` can be used to disable TLS 1.0 for communications with backends. Setting `Microsoft.WindowsAzure.ApiManagement.Gateway.Protocols.Server.Http2` can be used to enable HTTP2 protocol on an API Management service."


Adding </br> after each full stop, then all settings will come in new line

Also there are 8 settings. I see documentation for only 6

"Microsoft.WindowsAzure.ApiManagement.Gateway.Security.Protocols.Tls10": "False", "Microsoft.WindowsAzure.ApiManagement.Gateway.Security.Protocols.Tls11": "False", "Microsoft.WindowsAzure.ApiManagement.Gateway.Security.Protocols.Ssl30": "False", "Microsoft.WindowsAzure.ApiManagement.Gateway.Security.Ciphers.TripleDes168": "False", "Microsoft.WindowsAzure.ApiManagement.Gateway.Security.Backend.Protocols.Tls10": "False", "Microsoft.WindowsAzure.ApiManagement.Gateway.Security.Backend.Protocols.Tls11": "False", "Microsoft.WindowsAzure.ApiManagement.Gateway.Security.Backend.Protocols.Ssl30": "False", "Microsoft.WindowsAzure.ApiManagement.Gateway.Protocols.Server.Http2": "False"

In reply to: 291376587 [](ancestors = 291376587)

Ssl30 is always disabled, you can't change it's state

added line breaks though

solankisamir

Looks Good

promoisha requested a review from solankisamir as a code owner June 6, 2019 21:11

azuresdkci assigned jhendrixMSFT Jun 6, 2019

azuresdkci requested a review from jhendrixMSFT June 6, 2019 21:12

AutorestCI mentioned this pull request Jun 6, 2019

[AutoPR apimanagement/resource-manager] Custom properties were updated to reflect all the possible values Azure/azure-sdk-for-python#5725

Merged

AutorestCI mentioned this pull request Jun 6, 2019

[AutoPR apimanagement/resource-manager] Custom properties were updated to reflect all the possible values Azure/azure-sdk-for-js#3541

Closed

AutorestCI mentioned this pull request Jun 6, 2019

[AutoPR apimanagement/resource-manager] Custom properties were updated to reflect all the possible values Azure/azure-sdk-for-go#4971

Merged

solankisamir reviewed Jun 6, 2019

View reviewed changes

promoisha force-pushed the gleb_updatecustomsettings branch from 0f35adc to 157fcfa Compare June 7, 2019 17:40

solankisamir approved these changes Jun 7, 2019

View reviewed changes

Custom properties were updated to reflect all the possible values

50d490c

promoisha force-pushed the gleb_updatecustomsettings branch from 157fcfa to 50d490c Compare June 7, 2019 18:43

jhendrixMSFT approved these changes Jun 7, 2019

View reviewed changes

jhendrixMSFT merged commit 54555f3 into Azure:master Jun 7, 2019

AutorestCI mentioned this pull request Jun 7, 2019

[AutoPR apimanagement/resource-manager] Custom properties were updated to reflect all the possible values Azure/azure-sdk-for-js#3594

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Custom properties were updated to reflect all the possible values #6249

Custom properties were updated to reflect all the possible values #6249

promoisha commented Jun 6, 2019

openapi-sdkautomation bot commented Jun 6, 2019 •

edited

Loading

AutorestCI commented Jun 6, 2019 •

edited

Loading

AutorestCI commented Jun 6, 2019 •

edited

Loading

azuresdkci commented Jun 6, 2019

AutorestCI commented Jun 6, 2019 •

edited

Loading

AutorestCI commented Jun 6, 2019 •

edited

Loading

AutorestCI commented Jun 6, 2019 •

edited

Loading

solankisamir Jun 6, 2019

solankisamir Jun 6, 2019

promoisha Jun 7, 2019

promoisha Jun 7, 2019

solankisamir left a comment

Custom properties were updated to reflect all the possible values #6249

Custom properties were updated to reflect all the possible values #6249

Conversation

promoisha commented Jun 6, 2019

Latest improvements:

Contribution checklist:

ARM API Review Checklist

openapi-sdkautomation bot commented Jun 6, 2019 • edited Loading

SDK Automation [Logs] (Generated from 50d490c)

AutorestCI commented Jun 6, 2019 • edited Loading

Automation for azure-sdk-for-java

AutorestCI commented Jun 6, 2019 • edited Loading

Automation for azure-sdk-for-python

azuresdkci commented Jun 6, 2019

AutorestCI commented Jun 6, 2019 • edited Loading

Automation for azure-sdk-for-ruby

AutorestCI commented Jun 6, 2019 • edited Loading

Automation for azure-sdk-for-js

AutorestCI commented Jun 6, 2019 • edited Loading

Automation for azure-sdk-for-go

solankisamir Jun 6, 2019

Choose a reason for hiding this comment

solankisamir Jun 6, 2019

Choose a reason for hiding this comment

promoisha Jun 7, 2019

Choose a reason for hiding this comment

promoisha Jun 7, 2019

Choose a reason for hiding this comment

solankisamir left a comment

Choose a reason for hiding this comment

openapi-sdkautomation bot commented Jun 6, 2019 •

edited

Loading

AutorestCI commented Jun 6, 2019 •

edited

Loading

AutorestCI commented Jun 6, 2019 •

edited

Loading

AutorestCI commented Jun 6, 2019 •

edited

Loading

AutorestCI commented Jun 6, 2019 •

edited

Loading

AutorestCI commented Jun 6, 2019 •

edited

Loading