Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Microsoft.Billing] Customers resource for partner-channel #6299

Merged
merged 22 commits into from
Aug 14, 2019
Merged

[Microsoft.Billing] Customers resource for partner-channel #6299

merged 22 commits into from
Aug 14, 2019

Conversation

wilcobmsft
Copy link
Member

@wilcobmsft wilcobmsft commented Jun 12, 2019 •
edited
Loading

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jun 12, 2019 •
edited
Loading

In Testing, Please Ignore

[Logs] (Generated from fa34de2, Iteration 34)

Failed .NET: test-repo-billy/azure-sdk-for-net [Logs] [Diff]
Succeeded Python: test-repo-billy/azure-sdk-for-python [Logs] [Diff]
Failed Java: test-repo-billy/azure-sdk-for-java [Logs] [Diff]
  • Warning billing/resource-manager/v2017_02_27_preview [Logs]
  • Warning billing/resource-manager/v2017_04_24_preview [Logs]
  • Warning billing/resource-manager/v2018_03_01_preview [Logs]
  • Warning billing/resource-manager/v2018_11_01_preview [Logs]
  • Failed billing/resource-manager/v2019_10_01_preview [Logs] [Generation PR]
Warning Go: test-repo-billy/azure-sdk-for-go [Logs] [Diff]
Succeeded JavaScript: test-repo-billy/azure-sdk-for-js [Logs] [Diff]
Warning Ruby: test-repo-billy/azure-sdk-for-ruby [Logs] [Diff]
  • No packages generated.

@wilcobmsft wilcobmsft added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jun 12, 2019
@AutorestCI
Copy link

AutorestCI commented Jun 12, 2019 •
edited
Loading

Automation for azure-sdk-for-go

Nothing to generate for azure-sdk-for-go

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@AutorestCI
Copy link

AutorestCI commented Jun 12, 2019 •
edited
Loading

Automation for azure-sdk-for-python

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-python#5564

@AutorestCI
Copy link

AutorestCI commented Jun 12, 2019 •
edited
Loading

Automation for azure-sdk-for-js

A PR has been created for you:
Azure/azure-sdk-for-js#3912

@azuresdkci azuresdkci requested a review from tjprescott June 12, 2019 20:09
@AutorestCI
Copy link

AutorestCI commented Jun 12, 2019 •
edited
Loading

Automation for azure-sdk-for-java

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-java#3207

@AutorestCI AutorestCI mentioned this pull request Jun 12, 2019
Closed
@AutorestCI
Copy link

AutorestCI commented Jun 12, 2019 •
edited
Loading

Automation for azure-sdk-for-ruby

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-ruby#2628

This was referenced Jun 12, 2019
Closed
Closed
Closed
@NelsonDaniel
Copy link

Reassigning this b/c I will be OOF

@azuresdkci azuresdkci assigned sarangan12 and unassigned tjprescott Jun 12, 2019
@azuresdkci azuresdkci requested a review from sarangan12 June 12, 2019 21:08
This was referenced Aug 12, 2019
Merged
Merged
Merged
Merged
Merged
Merged
@wilcobmsft wilcobmsft changed the title [Do not merge] [Microsoft.Billing] Customers resource for partner-channel [Microsoft.Billing] Customers resource for partner-channel Aug 12, 2019
@wilcobmsft wilcobmsft force-pushed the wilcob/customers branch 9 times, most recently from 9908934 to 9cb1682 Compare August 12, 2019 20:06
@wilcobmsft wilcobmsft removed the DoNotMerge <valid label in PR review process> use to hold merge after approval label Aug 12, 2019
@wilcobmsft wilcobmsft removed the request for review from sarangan12 August 13, 2019 17:12
@yungezz
Copy link
Member

yungezz commented Aug 14, 2019

will merge this PR once CI finished.

@yungezz yungezz merged commit ec716fc into Azure:master Aug 14, 2019
@openapi-sdkautomation openapi-sdkautomation bot mentioned this pull request Aug 14, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yungezz yungezz yungezz approved these changes

@majastrz majastrz majastrz approved these changes

Assignees

@yungezz yungezz

Labels
ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review potential-sdk-breaking-change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@wilcobmsft @AutorestCI @azuresdkci @NelsonDaniel @majastrz @tjprescott @yungezz @sarangan12