Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update LUIS Runtime swagger to an auto generated version #6359

Merged
merged 5 commits into from
Jul 3, 2019
Merged

Update LUIS Runtime swagger to an auto generated version #6359

merged 5 commits into from
Jul 3, 2019

Conversation

moabba
Copy link
Member

@moabba moabba commented Jun 15, 2019 •
edited
Loading

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jun 15, 2019 •
edited
Loading

SDK Automation [Logs] (Generated from 3aa73f9)

Pending Go: Azure/azure-sdk-for-go
  • Package generation pending.
Pending Python: Azure/azure-sdk-for-python
  • Package generation pending.
Pending JavaScript: Azure/azure-sdk-for-js
  • Package generation pending.

@AutorestCI
Copy link

AutorestCI commented Jun 15, 2019 •
edited
Loading

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

@AutorestCI AutorestCI mentioned this pull request Jun 15, 2019
Merged
@AutorestCI
Copy link

AutorestCI commented Jun 15, 2019 •
edited
Loading

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#6217

@AutorestCI AutorestCI mentioned this pull request Jun 15, 2019
Closed
@AutorestCI
Copy link

AutorestCI commented Jun 15, 2019 •
edited
Loading

Automation for azure-sdk-for-js

A PR has been created for you:
Azure/azure-sdk-for-js#3834

@AutorestCI
Copy link

AutorestCI commented Jun 15, 2019 •
edited
Loading

Automation for azure-sdk-for-java

Nothing to generate for azure-sdk-for-java

@AutorestCI AutorestCI mentioned this pull request Jun 15, 2019
Merged
@AutorestCI
Copy link

AutorestCI commented Jun 15, 2019 •
edited
Loading

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#5191

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@moabba
Copy link
Member Author

moabba commented Jun 15, 2019

@yangyuan Do you know if there's a reason that we don't have java and .Net in the swagger-to-sdk section? Should I add them? Apparently Java wasn't updated in a long time.

@mmyyrroonn
Copy link
Contributor

LGTM. Most of commits are changes of the order of the code.

@mmyyrroonn
Copy link
Contributor

@yangyuan Please review this PR. Thanks

@mmyyrroonn
Copy link
Contributor

@yangyuan @DavidLiCIG Hi. Please review these changes when you are free. If you are ok with this PR, I plan to merge it this week.

@yangyuan
Copy link
Member

yangyuan commented Jul 1, 2019

By reading the Go SDK PR, this PR doesn't contain any actual change. Basically just reformat. Can you confirm?

@moabba
Copy link
Member Author

moabba commented Jul 1, 2019

By reading the Go SDK PR, this PR doesn't contain any actual change. Basically just reformat. Can you confirm?

@yangyuan Yes exactly. Before, we wrote this swagger file manually by hand. We made changes in our pipeline to auto-generate this from our code. So the generation shuffled some things around. But this is basically to make sure that any actual changes would be clear in the future and won't include this shuffling.

@mmyyrroonn mmyyrroonn merged commit 2abef0b into Azure:master Jul 3, 2019
celikcigdem pushed a commit to celikcigdem/azure-rest-api-specs that referenced this pull request Jul 17, 2019
@moabba @celikcigdem
Update LUIS Runtime swagger to an auto generated version (Azure#6359)
eff2aa9 
* Update LUIS Runtime swagger to an auto generated version

* Update the datetime in the examples

* Fix typo

* Stop generating v2.0 SDK for Go

* add runtime_2_0 back to Go SDK build
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhendrixMSFT jhendrixMSFT jhendrixMSFT left review comments

@NelsonDaniel NelsonDaniel NelsonDaniel left review comments

@yangyuan yangyuan yangyuan approved these changes

@mmyyrroonn mmyyrroonn mmyyrroonn approved these changes

@DavidLiCIG DavidLiCIG Awaiting requested review from DavidLiCIG

Assignees

@mmyyrroonn mmyyrroonn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@moabba @AutorestCI @azuresdkci @mmyyrroonn @yangyuan @jhendrixMSFT @NelsonDaniel