[READY TO MERGE] Adding workspace level quota management APIs in version 2019-06-01 #6366

leizhaoPS · 2019-06-17T21:05:14Z

This feature related changes is in 4ac4d6a
To update quota, we use the Post call with the action quota URI (similar to Usages): subscriptions/{subscriptionId}/providers/Microsoft.BatchAI/locations/{locationName}/updateQuotas

Parameters of this call:
Subscription ID (uri)
location (uri)
vmFamily (body)
workspaceId (body)
Quota (body)
api-version (query)

To get quota, we use Get call on the quota URI: subscriptions/{subscriptionId}/providers/Microsoft.BatchAI/locations/{locationName}/listQuotas

Parameters of this call:
Subscription ID (uri)
location (uri)
api-version (query)
Changes:
Added new API for update Quotas
Added new API for list Quotas
Added two examples:
ListWorkspaceQuotasByVMFamily.json
UpdateQuota.json

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.
The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

AutorestCI · 2019-06-17T21:05:59Z

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

AutorestCI · 2019-06-17T21:06:04Z

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#6892

AutorestCI · 2019-06-17T21:06:22Z

Automation for azure-sdk-for-js

A PR has been created for you:
Azure/azure-sdk-for-js#3862

openapi-sdkautomation · 2019-06-17T21:07:23Z

In Testing, Please Ignore

[Logs] (Generated from c89caf9, Iteration 19)

.NET: test-repo-billy/azure-sdk-for-net [Logs] [Diff]

No packages generated.

Go: test-repo-billy/azure-sdk-for-go [Logs] [Diff]

machinelearningservices/mgmt/2018-11-19 [Logs]
machinelearningservices/mgmt/2019-05-01 [Logs]
machinelearningservices/mgmt/2019-06-01 [Logs] [Instructions] [Generation PR] [Integration PR]
- machinelearningservices.mgmt.2019-06-01.zip
preview/machinelearningservices/mgmt/2018-03-01-preview [Logs]

Python: test-repo-billy/azure-sdk-for-python [Logs] [Diff]

azure-mgmt-machinelearningservices [Logs] [Instructions] [Generation PR] [Integration PR]
- azure-mgmt-machinelearningservices-0.1.0.zip
- azure_mgmt_machinelearningservices-0.1.0-py2.py3-none-any.whl

JavaScript: test-repo-billy/azure-sdk-for-js [Logs] [Diff]

@azure/arm-machinelearningservices [Logs] [Instructions] [Generation PR] [Integration PR]
- azure-arm-machinelearningservices-3.0.0.tgz

AutorestCI · 2019-06-17T21:07:51Z

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#5674

azuresdkci · 2019-06-17T21:23:00Z

Can one of the admins verify this patch?

AutorestCI · 2019-06-18T00:31:51Z

Automation for azure-sdk-for-java

Nothing to generate for azure-sdk-for-java

erich-wang · 2019-06-19T10:12:55Z

@leizhaoPS , please fix CI errors.

erich-wang

Please fix CI errors

leizhaoPS · 2019-06-20T05:04:23Z

@erich-wang , could you please help take a look at the design part related to workspace level quota managment API: 4ac4d6a, other validation failures we already fixed in the main branch.

…ttps://github.com/leizhaoPS/azure-rest-api-specs into leizhao/workspaceQuotaManagementInVersion2019-05-01

ravbhatnagar · 2019-06-27T00:27:30Z

@KrisBash - please let me know if you are good to sign off on this.

KrisBash

thanks for the changes

erich-wang · 2019-07-04T05:39:55Z

@leizhaoPS , please let me know when PR is ready for merge.

leizhaoPS · 2019-07-04T07:38:27Z

Thanks for follow up! I will check with the team when backend rollout and let you know.:) Get Outlook for iOS<https://aka.ms/o0ukef>

…

________________________________ From: erich-wang <notifications@github.com> Sent: Wednesday, July 3, 2019 10:40:22 PM To: Azure/azure-rest-api-specs Cc: Lei Zhao; Mention Subject: Re: [Azure/azure-rest-api-specs] [NEED DESIGN REVIEW, DO NOT MERGE] Adding workspace level quota management APIs in version 2019-05-01 (#6366) @leizhaoPS<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FleizhaoPS&data=02%7C01%7Cleizhao%40microsoft.com%7C8544b1e34f174664ea5708d700421bd6%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636978156246405603&sdata=QeNWl08niMMiNbleUMXsea2TQXPXD8uvsymJp7ah8Bg%3D&reserved=0> , please let me know when PR is ready for merge. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FAzure%2Fazure-rest-api-specs%2Fpull%2F6366%3Femail_source%3Dnotifications%26email_token%3DAE5CNUR7KCNYCVDABWPHNI3P5WEMNA5CNFSM4HY2IEN2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZGL27Q%23issuecomment-508345726&data=02%7C01%7Cleizhao%40microsoft.com%7C8544b1e34f174664ea5708d700421bd6%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636978156246415602&sdata=lJhaS19TqDrnfB2mHJO6EQWNtInTKWOceFMk5TPh7As%3D&reserved=0>, or mute the thread<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAE5CNUXN2EUESMXPDMARBXDP5WEMNANCNFSM4HY2IENQ&data=02%7C01%7Cleizhao%40microsoft.com%7C8544b1e34f174664ea5708d700421bd6%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636978156246415602&sdata=CxYoYfPn%2BQySX4n9qmEkqD2ChuqX69HRBJSGGz5QyOA%3D&reserved=0>.

erich-wang · 2019-08-01T13:10:00Z

@leizhaoPS , any process for this PR?

erich-wang · 2019-08-06T04:56:07Z

@@leizhaoPS , I added DoNotMerge for this PR, please let me know when it is ready for merge.

yungezz · 2019-08-28T05:53:18Z

Hi @leizhaoPS what's your plan to proceed this PR? is it ok to close it for now, pls reopen or create a new PR when service is ready

…019-05-01

…anges

leizhaoPS added 11 commits June 4, 2019 17:01

just migrate to verion 2019-05-01, no content update

1e19ed9

update readme files for adding new verion 2019-05-01

59de52f

fix name from 2018-11-19-preview to 2018-11-19

041a57c

add usages by VM family changes

5d26083

rename the readme.go.md namespace and change the tags order to desc

1b1a093

fix tag name for 2018-11-19

2931b65

remove not referenced example files

f5f34f6

switch backt to package-2018-03-preview

6205cf2

fix go SDK issue not related to this feature

b34cf06

fix go SDK issue not related to this feature

d720ac0

add workspace quota management API in version 2015-05-01

4ac4d6a

azuresdkci assigned erich-wang Jun 17, 2019

azuresdkci requested a review from erich-wang June 17, 2019 21:06

AutorestCI mentioned this pull request Jun 17, 2019

[AutoPR machinelearningservices/resource-manager] [Do not merge] Adding workspace level quota management APIs in version 2019-05-01 Azure/azure-sdk-for-js#3862

Closed

AutorestCI mentioned this pull request Jun 17, 2019

[AutoPR machinelearningservices/resource-manager] [Do not merge] Adding workspace level quota management APIs in version 2019-05-01 Azure/azure-sdk-for-go#5028

Closed

erich-wang added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jun 19, 2019

erich-wang suggested changes Jun 19, 2019

View reviewed changes

leizhaoPS added 2 commits June 19, 2019 19:00

fix model validation error and sdk error

505cf55

Merge branch 'master' into leizhao/createNewVersion2019-05-01

9059858

leizhaoPS added 2 commits June 19, 2019 22:15

add workspace quota management API in version 2015-05-01

3f0d58e

Merge branch 'leizhao/workspaceQuotaManagementInVersion2019-05-01' of h…

fb1dc88

…ttps://github.com/leizhaoPS/azure-rest-api-specs into leizhao/workspaceQuotaManagementInVersion2019-05-01

ravbhatnagar added the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Jun 27, 2019

KrisBash approved these changes Jul 2, 2019

View reviewed changes

erich-wang approved these changes Jul 4, 2019

View reviewed changes

fix a typo

849d86f

AutorestCI mentioned this pull request Jul 5, 2019

[AutoPR machinelearningservices/resource-manager] [NEED DESIGN REVIEW, DO NOT MERGE] Adding workspace level quota management APIs in version 2019-05-01 Azure/azure-sdk-for-python#6247

Closed

erich-wang added the DoNotMerge <valid label in PR review process> use to hold merge after approval label Aug 6, 2019

Merge branch 'master' into leizhao/workspaceQuotaManagementInVersion2…

f5ddfe8

…019-05-01

migrate quota management from 2019-05-01 to 2019-06-01, no content ch…

c89caf9

…anges

leizhaoPS changed the title ~~[NEED DESIGN REVIEW, DO NOT MERGE] Adding workspace level quota management APIs in version 2019-05-01~~ [NEED DESIGN REVIEW, DO NOT MERGE] Adding workspace level quota management APIs in version 2019-06-01 Aug 28, 2019

leizhaoPS changed the title ~~[NEED DESIGN REVIEW, DO NOT MERGE] Adding workspace level quota management APIs in version 2019-06-01~~ [READY TO MERGE] Adding workspace level quota management APIs in version 2019-06-01 Aug 28, 2019

raych1 self-requested a review August 29, 2019 05:11

raych1 approved these changes Aug 29, 2019

View reviewed changes

PhoenixHe-NV closed this Aug 29, 2019

PhoenixHe-NV reopened this Aug 29, 2019

AutorestCI mentioned this pull request Aug 29, 2019

[AutoPR machinelearningservices/resource-manager] [READY TO MERGE] Adding workspace level quota management APIs in version 2019-06-01 Azure/azure-sdk-for-python#6997

Merged

yungezz merged commit 8533dc5 into Azure:master Sep 2, 2019

yungezz removed the DoNotMerge <valid label in PR review process> use to hold merge after approval label Sep 2, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[READY TO MERGE] Adding workspace level quota management APIs in version 2019-06-01 #6366

[READY TO MERGE] Adding workspace level quota management APIs in version 2019-06-01 #6366

leizhaoPS commented Jun 17, 2019 •

edited

Loading

AutorestCI commented Jun 17, 2019 •

edited

Loading

AutorestCI commented Jun 17, 2019 •

edited

Loading

AutorestCI commented Jun 17, 2019 •

edited

Loading

openapi-sdkautomation bot commented Jun 17, 2019 •

edited

Loading

AutorestCI commented Jun 17, 2019 •

edited

Loading

azuresdkci commented Jun 17, 2019

AutorestCI commented Jun 18, 2019 •

edited

Loading

erich-wang commented Jun 19, 2019

erich-wang left a comment

leizhaoPS commented Jun 20, 2019

ravbhatnagar commented Jun 27, 2019

KrisBash left a comment

erich-wang commented Jul 4, 2019

leizhaoPS commented Jul 4, 2019 via email

erich-wang commented Aug 1, 2019

erich-wang commented Aug 6, 2019

yungezz commented Aug 28, 2019

[READY TO MERGE] Adding workspace level quota management APIs in version 2019-06-01 #6366

[READY TO MERGE] Adding workspace level quota management APIs in version 2019-06-01 #6366

Conversation

leizhaoPS commented Jun 17, 2019 • edited Loading

Latest improvements:

Contribution checklist:

ARM API Review Checklist

AutorestCI commented Jun 17, 2019 • edited Loading

Automation for azure-sdk-for-ruby

AutorestCI commented Jun 17, 2019 • edited Loading

Automation for azure-sdk-for-python

AutorestCI commented Jun 17, 2019 • edited Loading

Automation for azure-sdk-for-js

openapi-sdkautomation bot commented Jun 17, 2019 • edited Loading

In Testing, Please Ignore

[Logs] (Generated from c89caf9, Iteration 19)

AutorestCI commented Jun 17, 2019 • edited Loading

Automation for azure-sdk-for-go

azuresdkci commented Jun 17, 2019

AutorestCI commented Jun 18, 2019 • edited Loading

Automation for azure-sdk-for-java

erich-wang commented Jun 19, 2019

erich-wang left a comment

Choose a reason for hiding this comment

leizhaoPS commented Jun 20, 2019

ravbhatnagar commented Jun 27, 2019

KrisBash left a comment

Choose a reason for hiding this comment

erich-wang commented Jul 4, 2019

leizhaoPS commented Jul 4, 2019 via email

erich-wang commented Aug 1, 2019

erich-wang commented Aug 6, 2019

yungezz commented Aug 28, 2019

leizhaoPS commented Jun 17, 2019 •

edited

Loading

AutorestCI commented Jun 17, 2019 •

edited

Loading

AutorestCI commented Jun 17, 2019 •

edited

Loading

AutorestCI commented Jun 17, 2019 •

edited

Loading

openapi-sdkautomation bot commented Jun 17, 2019 •

edited

Loading

AutorestCI commented Jun 17, 2019 •

edited

Loading

AutorestCI commented Jun 18, 2019 •

edited

Loading