Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NetApp update swagger for R4.5 #6395

Merged
merged 10 commits into from
Jun 27, 2019
Merged

NetApp update swagger for R4.5 #6395

merged 10 commits into from
Jun 27, 2019

Conversation

tomasm9-zz
Copy link
Contributor

@tomasm9-zz tomasm9-zz commented Jun 20, 2019 •
edited
Loading

Summary of Changes

  • Added async responses to:
    -- Account update
    -- Pools update
    -- Volumes update
    -- Snapshots update
    -- Snapshots delete

  • Removed default value from size in poolProperties

  • Protocol types changed from an array inside a string, to an array of strings

  • Snapshot id allows resource id in volumeProperties
    -- Added to the regex

-Updated the API version

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jun 20, 2019 •
edited
Loading

SDK Automation [Logs] (Generated from 69314a7)

Pending Python: Azure/azure-sdk-for-python
  • Package generation pending.
Pending .NET: Azure/azure-sdk-for-net
  • Package generation pending.
Pending JavaScript: Azure/azure-sdk-for-js
  • Package generation pending.
Pending Go: Azure/azure-sdk-for-go
  • Package generation pending.
Pending Java: Azure/azure-sdk-for-java
  • Package generation pending.

@AutorestCI
Copy link

AutorestCI commented Jun 20, 2019 •
edited
Loading

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#5155

@AutorestCI
Copy link

AutorestCI commented Jun 20, 2019 •
edited
Loading

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

@AutorestCI
Copy link

AutorestCI commented Jun 20, 2019 •
edited
Loading

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#5675

@AutorestCI
Copy link

AutorestCI commented Jun 20, 2019 •
edited
Loading

Automation for azure-sdk-for-java

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-java#3253

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@AutorestCI AutorestCI mentioned this pull request Jun 20, 2019
Merged
@tomasm9-zz
Copy link
Contributor Author

For some reason one of the pipeline checks is failing(Breaking Changes). It's complaining about a line that is identical to last versions line. All other checks pass, and json validation doesn't complain.

Are you familiar with the error we're getting?

@AutorestCI AutorestCI mentioned this pull request Jun 26, 2019
Merged
@AutorestCI AutorestCI mentioned this pull request Jun 26, 2019
Merged
@amarzavery
Copy link
Contributor

@tomasm9 - Can you summarize the changes made in the new api version?

amarzavery
amarzavery suggested changes Jun 26, 2019
View reviewed changes
Copy link
Contributor

@amarzavery amarzavery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the test-swagger folder which contains the C# code. This repository only contains the swagger spec. Please send a PR to https://github.com/azure/azure-sdk-for-net repo for the C# sdk that is generated from this swagger spec.

@amarzavery amarzavery added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jun 26, 2019
@ravbhatnagar
Copy link
Contributor

looks like the parameters are being included for each API. earlier they were at the level of the path and now they are being added for each http verb. Signing off from ARM side.

@ravbhatnagar ravbhatnagar added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Jun 26, 2019
@tomasm9-zz
Copy link
Contributor Author

tomasm9-zz commented Jun 27, 2019 •
edited
Loading

I added a quick summary in the description with the changes

@amarzavery the C# code was accidentally added in, should be removed now :)

looks like the parameters are being included for each API. earlier they were at the level of the path and now they are being added for each http verb. Signing off from ARM side.

@ravbhatnagar should be reverted now

@amarzavery amarzavery merged commit 1e01123 into Azure:master Jun 27, 2019
This was referenced Jul 5, 2019
Closed
Merged
celikcigdem pushed a commit to celikcigdem/azure-rest-api-specs that referenced this pull request Jul 17, 2019
@tomasm9-zz @celikcigdem
NetApp update swagger for R4.5 (Azure#6395)
d5f7504 
* NFSAAS-2660 swagger update for R4.5

* NFSAAS-2660 delete swagger generated files

* NFSAAS-2660 fixing model validation error

* updated readme

* fixing up the json

* trying to fix serialization bug

* Updating description for responses

* Changing the protocolTypes example

* Fix Swaggers to get the diff working

* Reverting accidental netapp.json changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amarzavery amarzavery amarzavery approved these changes

Assignees

@amarzavery amarzavery

Labels
ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@tomasm9-zz @AutorestCI @azuresdkci @amarzavery @ravbhatnagar @tomasm9 @sarangan12