-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing displayName and domains properties to response of Tenants_List call #6473
Conversation
SDK Automation [Logs] (Generated from 38bec71)Python: Azure/azure-sdk-for-python [Logs]
Java: Azure/azure-sdk-for-java [Logs] [Diff]
Go: Azure/azure-sdk-for-go [Logs]
JavaScript: Azure/azure-sdk-for-js [Logs] [Diff]
|
Automation for azure-sdk-for-rubyNothing to generate for azure-sdk-for-ruby |
Automation for azure-sdk-for-pythonThe initial PR has been merged into your service PR: |
Automation for azure-sdk-for-goA PR has been created for you based on this PR content. Once this PR will be merged, content will be added to your service PR: |
Automation for azure-sdk-for-javaThe initial PR has been merged into your service PR: |
@zikalino @Tiano2017 @ravbhatnagar gentle ping 😀 |
@cormacpayne looks good in general. just doing a few checks :-) |
@cormacpayne I have actually tried GET /tenants using api_version 2018-06-01, and I didn't get these properties, so I think I would like to verify what's the reason.
@Tiano2017 @ravbhatnagar could you check that? |
@zikalino I did it just now.. and could see "domains" in the response. |
@stankovski is it ok to merge? |
@stankovski any update? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Cormac for these changes. :)
@zikalino @stankovski is this OK to merge? |
Description
Partial fix for issue #6468 -- the model object returned from the
Tenants_List
call in thesubscriptions.json
spec for ARM is missing a few properties (as outlined in the linked issue), and this change is adding two missing properties (displayName
anddomains
) to this object in the latest stable API version for this spec.CC: @Tiano2017 @ravbhatnagar -- would you mind taking a look at this change?
Latest improvements:
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
ARM API Review Checklist
Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.
Please follow the link to find more details on API review process.