Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

apim ciphers custom settings description #6474

Merged
merged 1 commit into from
Jul 8, 2019
Merged

apim ciphers custom settings description #6474

merged 1 commit into from
Jul 8, 2019

Conversation

vfedonkin
Copy link
Contributor

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@vfedonkin vfedonkin requested a review from solankisamir as a code owner June 27, 2019 00:15
@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jun 27, 2019 •
edited
Loading

SDK Automation [Logs] (Generated from de32f8f)

Pending Go: Azure/azure-sdk-for-go
  • Package generation pending.
Pending Python: Azure/azure-sdk-for-python
  • Package generation pending.
Pending JavaScript: Azure/azure-sdk-for-js
  • Package generation pending.
Pending Ruby: Azure/azure-sdk-for-ruby
  • Package generation pending.

@AutorestCI
Copy link

AutorestCI commented Jun 27, 2019 •
edited
Loading

Automation for azure-sdk-for-java

Nothing to generate for azure-sdk-for-java

@AutorestCI AutorestCI mentioned this pull request Jun 27, 2019
Merged
@AutorestCI
Copy link

AutorestCI commented Jun 27, 2019 •
edited
Loading

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#5754

@AutorestCI
Copy link

AutorestCI commented Jun 27, 2019 •
edited
Loading

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

@AutorestCI AutorestCI mentioned this pull request Jun 27, 2019
Merged
@AutorestCI
Copy link

AutorestCI commented Jun 27, 2019 •
edited
Loading

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#5147

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@azuresdkci azuresdkci requested a review from yaohaizh June 27, 2019 00:38
solankisamir
solankisamir approved these changes Jun 27, 2019
View reviewed changes
Copy link
Member

@solankisamir solankisamir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@yaohaizh yaohaizh added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jun 28, 2019
@yaohaizh yaohaizh removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jul 8, 2019
@yaohaizh yaohaizh merged commit d449325 into Azure:master Jul 8, 2019
celikcigdem pushed a commit to celikcigdem/azure-rest-api-specs that referenced this pull request Jul 17, 2019
@vfedonkin @celikcigdem
apim ciphers custom settings description (Azure#6474)
293855b
leni-msft pushed a commit to leni-msft/azure-rest-api-specs that referenced this pull request May 13, 2022
@xiaoliangshi
Testbase/xiaols/rp saa s master/test base add new api version20220301…
a88b629 
… preview (Azure#6474)

* add 2022-03-01-preview copy 2021-12-01 as base

* add 2022-03-01-preview

* fix readme

* fix readme error

* fix go readme
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yaohaizh yaohaizh yaohaizh approved these changes

@solankisamir solankisamir solankisamir approved these changes

Assignees

@yaohaizh yaohaizh

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@vfedonkin @AutorestCI @azuresdkci @solankisamir @yaohaizh