[DO NOT MERGE] httpCorrelationProtocol property was added to diagnostic entity #6487

promoisha · 2019-06-27T19:39:37Z

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.
The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

openapi-sdkautomation · 2019-06-27T19:39:39Z

SDK Automation [Logs] (Generated from 59b685d)

Go: Azure/azure-sdk-for-go [Logs]

Package generation in progress.

Python: Azure/azure-sdk-for-python [Logs] [Diff]

sdk/apimanagement/azure-mgmt-apimanagement [Logs] [Instructions]
- azure-mgmt-apimanagement-0.1.0.zip
- azure_mgmt_apimanagement-0.1.0-py2.py3-none-any.whl

JavaScript: Azure/azure-sdk-for-js [Logs] [Diff]

@azure/arm-apimanagement [Logs] [Instructions]
- azure-arm-apimanagement-5.1.0.tgz

Ruby: Azure/azure-sdk-for-ruby [Logs] [Diff]

azure_sdk [Logs] [Instructions]
- azure_sdk-0.27.0.gem
data/api_management [Logs] [Instructions]
- api_management-0.0.1.gem

AutorestCI · 2019-06-27T19:42:18Z

Automation for azure-sdk-for-python

Encountered an unknown error: (azure-sdk-for-python)

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 33, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 170, in rest_handle_action
    return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 185, in rest_pull_close
    rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
    sdk_tag=sdk_tag
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 254, in generate_sdk_from_git_object
    with manage_git_folder(gh_token, Path(temp_dir) / Path("rest"), branched_rest_api_id, pr_number=pr_number) as restapi_git_folder, \
  File "/usr/lib/python3.6/contextlib.py", line 81, in __enter__
    return next(self.gen)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 272, in manage_git_folder
    clone_to_path(gh_token, temp_dir, split_git_id[0], branch_or_commit=branch, pr_number=pr_number)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 212, in clone_to_path
    repo.git.checkout(branch_or_commit)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 548, in <lambda>
    return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 1014, in _call_process
    return self.execute(call, **exec_kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 825, in execute
    raise GitCommandError(command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(128)
  cmdline: git checkout b485e0b081f190c501ab8d86a9d116a36bbfbd00
  stderr: 'fatal: reference is not a tree: b485e0b081f190c501ab8d86a9d116a36bbfbd00'

AutorestCI · 2019-06-27T19:43:11Z

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

AutorestCI · 2019-06-27T19:51:50Z

Automation for azure-sdk-for-go

Encountered an unknown error: (azure-sdk-for-go)

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 33, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 170, in rest_handle_action
    return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 185, in rest_pull_close
    rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
    sdk_tag=sdk_tag
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 254, in generate_sdk_from_git_object
    with manage_git_folder(gh_token, Path(temp_dir) / Path("rest"), branched_rest_api_id, pr_number=pr_number) as restapi_git_folder, \
  File "/usr/lib/python3.6/contextlib.py", line 81, in __enter__
    return next(self.gen)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 272, in manage_git_folder
    clone_to_path(gh_token, temp_dir, split_git_id[0], branch_or_commit=branch, pr_number=pr_number)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 212, in clone_to_path
    repo.git.checkout(branch_or_commit)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 548, in <lambda>
    return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 1014, in _call_process
    return self.execute(call, **exec_kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 825, in execute
    raise GitCommandError(command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(128)
  cmdline: git checkout b485e0b081f190c501ab8d86a9d116a36bbfbd00
  stderr: 'fatal: reference is not a tree: b485e0b081f190c501ab8d86a9d116a36bbfbd00'

azuresdkci · 2019-06-27T20:03:26Z

Can one of the admins verify this patch?

AutorestCI · 2019-06-27T21:53:10Z

Automation for azure-sdk-for-java

Nothing to generate for azure-sdk-for-java

mmyyrroonn · 2019-06-28T01:31:07Z

@promoisha Hi. This PR add new property into a stable version. Besides, the field is required. So we should firstly wait for ARM feedback.

azure-rest-api-specs/specification/apimanagement/resource-manager/Microsoft.ApiManagement/stable/2019-01-01/apimapis.json

Lines 2668 to 2672 in 0737a48

    
           "name": "parameters", 
        
           "in": "body", 
        
           "required": true, 
        
           "schema": { 
        
             "$ref": "./definitions.json#/definitions/DiagnosticContract"

solankisamir · 2019-06-28T19:31:48Z

@promoisha Hi. This PR add new property into a stable version. Besides, the field is required. So we should firstly wait for ARM feedback.

azure-rest-api-specs/specification/apimanagement/resource-manager/Microsoft.ApiManagement/stable/2019-01-01/apimapis.json

Lines 2668 to 2672 in 0737a48

"name": "parameters",

"in": "body",

"required": true,

"schema": {

"$ref": "./definitions.json#/definitions/DiagnosticContract"

@myronfanqiu I don't see this property as being required in the Diagnostic entity contract. The only required property is loggerid

mmyyrroonn · 2019-07-01T02:05:23Z

@promoisha Hi. This PR add new property into a stable version. Besides, the field is required. So we should firstly wait for ARM feedback.

azure-rest-api-specs/specification/apimanagement/resource-manager/Microsoft.ApiManagement/stable/2019-01-01/apimapis.json

Lines 2668 to 2672 in 0737a48

"name": "parameters",

"in": "body",

"required": true,

"schema": {

"$ref": "./definitions.json#/definitions/DiagnosticContract"

@myronfanqiu I don't see this property as being required in the Diagnostic entity contract. The only required property is loggerid

@solankisamir Hello. My mistake. What I want to say is that the property DiagnosticContract is required. This PR add a new property into a required field in a stable version. I understand httpCorrelationProtocol is optional. This PR looks good to me. However, recently we are under transition process, any property or API change in the stable version should involve arm for review.

promoisha · 2019-07-05T19:23:01Z

@myronfanqiu who should I ping to expedite approval?

mmyyrroonn · 2019-07-08T00:49:53Z

@promoisha Let me try. 😃 @sanjaiganesh Hello, could you please review this PR?

jhendrixMSFT · 2019-07-08T23:21:46Z

@AutorestCI regenerate azure-sdk-for-go

promoisha · 2019-07-10T22:39:34Z

@Azure/arm-api-review-board could someone take a look at the PR? Thanks!

ryansbenson

This constitutes a breaking change and requires a new api version.

Take a look at the section for 'New property added to response'
https://microsoft.sharepoint.com/:w:/t/azureresourcemanagerteam/EWXsAQ1yx25KkyYCeeWGUgwBSBxEdUDEbHi6FZ__U8EOQw?rtime=FuqbLiIH10g

mmyyrroonn · 2019-07-19T09:14:41Z

@promoisha Hi. Are you creating a new api-version? How to deal with this PR?

mmyyrroonn · 2019-08-06T02:14:46Z

@promoisha Hello. Any update for this PR?

yungezz · 2019-08-28T07:40:57Z

hi @promoisha are you still on this PR? Is it ok to close the PR since no update over month? Pls create new PR or reopen when you're ready for reviewing and merging

mmyyrroonn · 2019-09-02T02:01:54Z

@promoisha Hello. Since this PR has not been updated for more than one month. I will close this PR first. If you need this PR in the future, please feel free to reopen it and ping me.

* Evolved Microsoft.Pki/pkis/certificateAuthorities. * Evolved Microsoft.Pki/pkis/certificateAuthorities. * Fixed PrettierCheck failures

httpCorrelationProtocol property was added to diagnostic entity

59b685d

promoisha requested a review from solankisamir as a code owner June 27, 2019 19:39

AutorestCI mentioned this pull request Jun 27, 2019

[AutoPR apimanagement/resource-manager] [DO NOT MERGE] httpCorrelationProtocol property was added to diagnostic entity Azure/azure-sdk-for-python#6148

Closed

AutorestCI mentioned this pull request Jun 27, 2019

[AutoPR apimanagement/resource-manager] [DO NOT MERGE] httpCorrelationProtocol property was added to diagnostic entity Azure/azure-sdk-for-go#5153

Closed

azuresdkci assigned mmyyrroonn Jun 27, 2019

azuresdkci requested a review from mmyyrroonn June 27, 2019 20:02

mmyyrroonn added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jun 28, 2019

AutorestCI mentioned this pull request Jul 8, 2019

[AutoPR apimanagement/resource-manager] [DO NOT MERGE] httpCorrelationProtocol property was added to diagnostic entity Azure/azure-sdk-for-go#5208

Closed

ryansbenson reviewed Jul 12, 2019

View reviewed changes

KrisBash added the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Jul 16, 2019

mmyyrroonn removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Aug 8, 2019

mmyyrroonn closed this Sep 2, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[DO NOT MERGE] httpCorrelationProtocol property was added to diagnostic entity #6487

[DO NOT MERGE] httpCorrelationProtocol property was added to diagnostic entity #6487

promoisha commented Jun 27, 2019

openapi-sdkautomation bot commented Jun 27, 2019 •

edited

Loading

AutorestCI commented Jun 27, 2019 •

edited

Loading

AutorestCI commented Jun 27, 2019 •

edited

Loading

AutorestCI commented Jun 27, 2019 •

edited

Loading

azuresdkci commented Jun 27, 2019

AutorestCI commented Jun 27, 2019 •

edited

Loading

mmyyrroonn commented Jun 28, 2019

solankisamir commented Jun 28, 2019

mmyyrroonn commented Jul 1, 2019

promoisha commented Jul 5, 2019

mmyyrroonn commented Jul 8, 2019

jhendrixMSFT commented Jul 8, 2019

promoisha commented Jul 10, 2019

ryansbenson left a comment

mmyyrroonn commented Jul 19, 2019

mmyyrroonn commented Aug 6, 2019

yungezz commented Aug 28, 2019

mmyyrroonn commented Sep 2, 2019

[DO NOT MERGE] httpCorrelationProtocol property was added to diagnostic entity #6487

[DO NOT MERGE] httpCorrelationProtocol property was added to diagnostic entity #6487

Conversation

promoisha commented Jun 27, 2019

Latest improvements:

Contribution checklist:

ARM API Review Checklist

openapi-sdkautomation bot commented Jun 27, 2019 • edited Loading

SDK Automation [Logs] (Generated from 59b685d)

AutorestCI commented Jun 27, 2019 • edited Loading

Automation for azure-sdk-for-python

AutorestCI commented Jun 27, 2019 • edited Loading

Automation for azure-sdk-for-ruby

AutorestCI commented Jun 27, 2019 • edited Loading

Automation for azure-sdk-for-go

azuresdkci commented Jun 27, 2019

AutorestCI commented Jun 27, 2019 • edited Loading

Automation for azure-sdk-for-java

mmyyrroonn commented Jun 28, 2019

solankisamir commented Jun 28, 2019

mmyyrroonn commented Jul 1, 2019

promoisha commented Jul 5, 2019

mmyyrroonn commented Jul 8, 2019

jhendrixMSFT commented Jul 8, 2019

promoisha commented Jul 10, 2019

ryansbenson left a comment

Choose a reason for hiding this comment

mmyyrroonn commented Jul 19, 2019

mmyyrroonn commented Aug 6, 2019

yungezz commented Aug 28, 2019

mmyyrroonn commented Sep 2, 2019

openapi-sdkautomation bot commented Jun 27, 2019 •

edited

Loading

AutorestCI commented Jun 27, 2019 •

edited

Loading

AutorestCI commented Jun 27, 2019 •

edited

Loading

AutorestCI commented Jun 27, 2019 •

edited

Loading

AutorestCI commented Jun 27, 2019 •

edited

Loading