Adding VpnSiteLink and VpnSiteLinkConnection properties. #6528

nalinrajgupta · 2019-07-01T21:51:12Z

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.
The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

AutorestCI · 2019-07-01T21:53:03Z

Automation for azure-sdk-for-python

Encountered a Subprocess error: (azure-sdk-for-python)

Command: ['/usr/local/bin/autorest', '/tmp/tmplsqkqum1/rest/specification/network/resource-manager/readme.md', '--keep-version-file', '--multiapi', '--no-async', '--python', '--python-mode=update', '--python-sdks-folder=/tmp/tmplsqkqum1/sdk/sdk', '--use=@microsoft.azure/autorest.python@4.0.70', '--version=preview']
Finished with return code -6
and output:

AutoRest code generation utility [version: 2.0.4283; node: v10.15.3]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest
   Loading AutoRest core      '/root/.autorest/@microsoft.azure_autorest-core@2.0.4387/node_modules/@microsoft.azure/autorest-core/dist' (2.0.4387)
   Loading AutoRest extension '@microsoft.azure/autorest.python' (4.0.70->4.0.70)
   Loading AutoRest extension '@microsoft.azure/autorest.modeler' (2.3.44->2.3.44)
Processing batch task - {"tag":"package-2019-04"} .

<--- Last few GCs --->

[29955:0x2525cc0]    99220 ms: Mark-sweep 1381.4 (1424.8) -> 1381.1 (1425.3) MB, 1337.9 / 0.0 ms  (average mu = 0.088, current mu = 0.003) allocation failure scavenge might not succeed
[29955:0x2525cc0]   100955 ms: Mark-sweep 1381.9 (1425.3) -> 1381.5 (1425.8) MB, 1732.1 / 0.0 ms  (average mu = 0.041, current mu = 0.002) allocation failure scavenge might not succeed


<--- JS stacktrace --->

==== JS stack trace =========================================

Security context: 0x0afb9f11e6e9 <JSObject>
    0: builtin exit frame: stringify(this=0x0afb9f111a21 <Object map = 0x1f384e9842a9>,0x035910a026f1 <undefined>,0x035910a026f1 <undefined>,0x1acf510e3119 <JSArray[15]>,0x0afb9f111a21 <Object map = 0x1f384e9842a9>)

    1: arguments adaptor frame: 1->3
    2: IdentitySourceMapping [0x27ff633afff1] [/root/.autorest/@microsoft.azure_autorest-core@2.0.4387/node_modules/@microsoft.azure/autorest-co...

FATAL ERROR: Ineffective mark-compacts near heap limit Allocation failed - JavaScript heap out of memory
 1: 0x8dc510 node::Abort() [node]
 2: 0x8dc55c  [node]
 3: 0xad9b5e v8::Utils::ReportOOMFailure(v8::internal::Isolate*, char const*, bool) [node]
 4: 0xad9d94 v8::internal::V8::FatalProcessOutOfMemory(v8::internal::Isolate*, char const*, bool) [node]
 5: 0xec7bf2  [node]
 6: 0xec7cf8 v8::internal::Heap::CheckIneffectiveMarkCompact(unsigned long, double) [node]
 7: 0xed3dd2 v8::internal::Heap::PerformGarbageCollection(v8::internal::GarbageCollector, v8::GCCallbackFlags) [node]
 8: 0xed4704 v8::internal::Heap::CollectGarbage(v8::internal::AllocationSpace, v8::internal::GarbageCollectionReason, v8::GCCallbackFlags) [node]
 9: 0xed7371 v8::internal::Heap::AllocateRawWithRetryOrFail(int, v8::internal::AllocationSpace, v8::internal::AllocationAlignment) [node]
10: 0xe9f655  [node]
11: 0xea6eca v8::internal::Factory::NewRawOneByteString(int, v8::internal::PretenureFlag) [node]
12: 0x11d69d0 v8::internal::IncrementalStringBuilder::IncrementalStringBuilder(v8::internal::Isolate*) [node]
13: 0xf99459 v8::internal::JsonStringifier::JsonStringifier(v8::internal::Isolate*) [node]
14: 0xba90ec v8::internal::Builtin_JsonStringify(int, v8::internal::Object**, v8::internal::Isolate*) [node]
15: 0x15236865bf7d

AutorestCI · 2019-07-01T21:53:33Z

Automation for azure-sdk-for-go

Nothing to generate for azure-sdk-for-go

AutorestCI · 2019-07-01T21:58:22Z

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

azuresdkci · 2019-07-01T22:29:54Z

Can one of the admins verify this patch?

AutorestCI · 2019-07-01T23:04:21Z

Automation for azure-sdk-for-java

Nothing to generate for azure-sdk-for-java

EvgenyAgafonchikov

Left some comments.
Please uses these tools to validate things are fixed locally

.../network/resource-manager/Microsoft.Network/stable/2019-06-01/examples/VpnConnectionPut.json

specification/network/resource-manager/Microsoft.Network/stable/2019-06-01/virtualWan.json

...cation/network/resource-manager/Microsoft.Network/stable/2019-06-01/examples/VpnSitePut.json

.../resource-manager/Microsoft.Network/stable/2019-06-01/examples/VpnSiteLinkListByVpnSite.json

...ion/network/resource-manager/Microsoft.Network/stable/2019-06-01/examples/VpnGatewayGet.json

...resource-manager/Microsoft.Network/stable/2019-06-01/examples/VpnSiteLinkConnectionList.json

anton-evseev

Please avoid using tabs in example files for he sake of consistency across all JSON files

.../network/resource-manager/Microsoft.Network/stable/2019-06-01/examples/VpnConnectionPut.json

...n/network/resource-manager/Microsoft.Network/stable/2019-06-01/examples/VpnSiteLinkList.json

jhendrixMSFT · 2019-07-03T22:50:23Z

@AutorestCI regenerate azure-sdk-for-go

MikhailTryakhov · 2019-07-10T17:50:24Z

Please merge it ASAP to be in the release

MikhailTryakhov · 2019-07-10T18:43:12Z

@nalinrajgupta FYI

anton-evseev · 2019-07-12T11:29:33Z

@Azure/arm-api-review-board for ARM review

specification/network/resource-manager/Microsoft.Network/stable/2019-06-01/virtualWan.json

specification/network/resource-manager/Microsoft.Network/stable/2019-06-01/network.json

MikhailTryakhov · 2019-07-15T20:19:24Z

hi guys,
need to close it today due to release dates. please escalate fixes soon

ryansbenson

Approved from ARMs side

* Adds base for updating Microsoft.Network from version stable/2019-04-01 to version 2019-06-01 * Updates readme * Updates API version in new specs and examples * Add PrivateIPAddressVersion in LoadBalancerFrontendIpConfiguration pr… (#6164) * Add PrivateIPAddressVersion in LoadBalancerFrontendIpConfiguration properties. * Fixed LB examples * Fix examples in 2019-06-01 * Remove API version number in privateIPAddressVersion description. * Add privateIPAddressVersion in LoadBalancer examples. * Add privateIPAddressVersion in 2019-06-01 API version. * Update specs to avoid readOnly in the request body (#6228) * typo: netowork May double word the (#6206) * Update cipher suites (#6213) * removing resource group name from PrepareNetworkPoliciesRequest (#6232) * Add exception for property "Conditon" in Network's webapplicationfirewall.json (#6335) * Extend long-running ops fixes to new API version; Suppression (#6336) * Update long-running for new API version * Add suppression for new API * Updated examples to have valid bodies for live put (#6349) * More examples fix after live testing (#6382) * Improved more examples after live testing * Fix validations * Improve descriptions in Network to align with Swagger guidelines (#6350) * Improve descriptions in Network to align with Swagger guidelines * Fix for CI * More examples improvements (#6444) * Add PATCH to Azure Firewall supported operations (#6486) * Add PATCH to Azure Firewall supported operations * Name the parameter how validation expects it * Patch is not a long running operation, so update the specs accordingly * PrivateEndpoint & PrivateLinkService APIs update (#6332) * Add two properties on Subnet for privateIp. Add two new APIs to support privateIp. Minor modify on readme.md file. * Fix some issue found by Model Validation. * Merge all apis relative to private end point / private link service to its json file. * Fix a typo name from design spec that casue GetAvailablePrivateEndpointType get null property. * Change AutoApprovedPrivateLinkService structure to fit with NRP side. * Delete suppress for merged APIs in readme.md. * 1. Change value to PrivateEndpointConnection when calling put PrivateEndpointConnect. 2. Change opertaion id for opertaions that relative to private endpoint and private link service. * Minor fix for model validation. * Revert opertion id changes for AvailablePrivateEndpointType to previous name. * 1. Change CheckPrivateLinkServiceVisibility API, the input now has a body content that contains a private link service alias string. 2. Change both CheckPrivateLinkServiceVisibility/AutoApprovedPrivateLinkServices API to support for with/without ResourceGroup parameter. * Improve Network's examples (#6493) * Removed read-only props from VPNGW example * Fixed LoadBalancer examples: * "outboundRules" array isn't returned for "Basic" SKU load balancer * added example for external LB with outboundRules * added missing read-only properties * Replace "regionName" in examples with real location * Fixed incorrect descriptions in LoadBalancer: child resource doesn't have to have a unique name within resource group, but within a set of similar resource on parent load balancer * chore: jsonfmt network (#6592) * Adding VpnSiteLink and VpnSiteLinkConnection properties. (#6528) * Added VpnSiteLink/VpnSiteLinkConnection operations. * Sdk changes for vpn site link. * Fixing error. * Fixing more comments. * Fixing json error. * Fixing json files. * Fixing comments. * Fixing more issues. * Fixing more errors. * Fixing more error. * Prettify JSON in VpnConnectionGet.json * Resolving more comments. * Fixing typo. * Adding type in examples of put. * Removing Child resource type. * chore: jsonfmt network-may * Fix incorrect examples

* Adds base for updating Microsoft.Network from version stable/2019-04-01 to version 2019-06-01 * Updates readme * Updates API version in new specs and examples * Add PrivateIPAddressVersion in LoadBalancerFrontendIpConfiguration pr… (Azure#6164) * Add PrivateIPAddressVersion in LoadBalancerFrontendIpConfiguration properties. * Fixed LB examples * Fix examples in 2019-06-01 * Remove API version number in privateIPAddressVersion description. * Add privateIPAddressVersion in LoadBalancer examples. * Add privateIPAddressVersion in 2019-06-01 API version. * Update specs to avoid readOnly in the request body (Azure#6228) * typo: netowork May double word the (Azure#6206) * Update cipher suites (Azure#6213) * removing resource group name from PrepareNetworkPoliciesRequest (Azure#6232) * Add exception for property "Conditon" in Network's webapplicationfirewall.json (Azure#6335) * Extend long-running ops fixes to new API version; Suppression (Azure#6336) * Update long-running for new API version * Add suppression for new API * Updated examples to have valid bodies for live put (Azure#6349) * More examples fix after live testing (Azure#6382) * Improved more examples after live testing * Fix validations * Improve descriptions in Network to align with Swagger guidelines (Azure#6350) * Improve descriptions in Network to align with Swagger guidelines * Fix for CI * More examples improvements (Azure#6444) * Add PATCH to Azure Firewall supported operations (Azure#6486) * Add PATCH to Azure Firewall supported operations * Name the parameter how validation expects it * Patch is not a long running operation, so update the specs accordingly * PrivateEndpoint & PrivateLinkService APIs update (Azure#6332) * Add two properties on Subnet for privateIp. Add two new APIs to support privateIp. Minor modify on readme.md file. * Fix some issue found by Model Validation. * Merge all apis relative to private end point / private link service to its json file. * Fix a typo name from design spec that casue GetAvailablePrivateEndpointType get null property. * Change AutoApprovedPrivateLinkService structure to fit with NRP side. * Delete suppress for merged APIs in readme.md. * 1. Change value to PrivateEndpointConnection when calling put PrivateEndpointConnect. 2. Change opertaion id for opertaions that relative to private endpoint and private link service. * Minor fix for model validation. * Revert opertion id changes for AvailablePrivateEndpointType to previous name. * 1. Change CheckPrivateLinkServiceVisibility API, the input now has a body content that contains a private link service alias string. 2. Change both CheckPrivateLinkServiceVisibility/AutoApprovedPrivateLinkServices API to support for with/without ResourceGroup parameter. * Improve Network's examples (Azure#6493) * Removed read-only props from VPNGW example * Fixed LoadBalancer examples: * "outboundRules" array isn't returned for "Basic" SKU load balancer * added example for external LB with outboundRules * added missing read-only properties * Replace "regionName" in examples with real location * Fixed incorrect descriptions in LoadBalancer: child resource doesn't have to have a unique name within resource group, but within a set of similar resource on parent load balancer * chore: jsonfmt network (Azure#6592) * Adding VpnSiteLink and VpnSiteLinkConnection properties. (Azure#6528) * Added VpnSiteLink/VpnSiteLinkConnection operations. * Sdk changes for vpn site link. * Fixing error. * Fixing more comments. * Fixing json error. * Fixing json files. * Fixing comments. * Fixing more issues. * Fixing more errors. * Fixing more error. * Prettify JSON in VpnConnectionGet.json * Resolving more comments. * Fixing typo. * Adding type in examples of put. * Removing Child resource type. * chore: jsonfmt network-may * Fix incorrect examples

nalinrajgupta and others added 2 commits June 24, 2019 12:56

Added VpnSiteLink/VpnSiteLinkConnection operations.

594c4d1

Sdk changes for vpn site link.

fcad638

nalinrajgupta requested a review from MikhailTryakhov as a code owner July 1, 2019 21:51

azuresdkci assigned sergey-shandar Jul 1, 2019

azuresdkci requested a review from sergey-shandar July 1, 2019 22:35

Nalin Gupta added 4 commits July 1, 2019 16:18

Fixing error.

c433da5

Fixing more comments.

568115b

Fixing json error.

dd785bc

Fixing json files.

bcc4d45

EvgenyAgafonchikov reviewed Jul 2, 2019

View reviewed changes

anton-evseev suggested changes Jul 2, 2019

View reviewed changes

.../network/resource-manager/Microsoft.Network/stable/2019-06-01/examples/VpnConnectionPut.json Outdated Show resolved Hide resolved

...n/network/resource-manager/Microsoft.Network/stable/2019-06-01/examples/VpnSiteLinkList.json Outdated Show resolved Hide resolved

Nalin Gupta added 4 commits July 2, 2019 10:50

Fixing comments.

781aaba

Fixing more issues.

6c622db

Fixing more errors.

b6a2b25

Fixing more error.

22f9c7b

AutorestCI mentioned this pull request Jul 3, 2019

[AutoPR network/resource-manager] Adding VpnSiteLink and VpnSiteLinkConnection properties. Azure/azure-sdk-for-go#5187

Closed

Prettify JSON in VpnConnectionGet.json

29a797d

anton-evseev approved these changes Jul 3, 2019

View reviewed changes

sergey-shandar added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jul 9, 2019

nalinrajgupta requested a review from EvgenyAgafonchikov July 10, 2019 19:49

EvgenyAgafonchikov approved these changes Jul 11, 2019

View reviewed changes

ryansbenson reviewed Jul 12, 2019

View reviewed changes

ryansbenson added the ARMReviewInProgress label Jul 12, 2019

Nalin Gupta added 4 commits July 12, 2019 17:04

Resolving more comments.

3e82c93

Merging with remote

20244c6

Fixing typo.

93b2780

Adding type in examples of put.

9acf879

anton-evseev suggested changes Jul 15, 2019

View reviewed changes

Removing Child resource type.

43a15d6

nalinrajgupta requested review from anton-evseev and ryansbenson July 15, 2019 16:04

MikhailTryakhov closed this Jul 15, 2019

nalinrajgupta reopened this Jul 15, 2019

Merging with original repo.

8bb28d8

ryansbenson approved these changes Jul 15, 2019

View reviewed changes

ryansbenson added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed ARMReviewInProgress WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Jul 15, 2019

sergey-shandar approved these changes Jul 16, 2019

View reviewed changes

sergey-shandar merged commit 293c053 into Azure:network-may-release Jul 16, 2019

gsumit10 mentioned this pull request Aug 14, 2021

CLI for VPN Mulit-Link feature Azure/azure-cli#19233

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adding VpnSiteLink and VpnSiteLinkConnection properties. #6528

Adding VpnSiteLink and VpnSiteLinkConnection properties. #6528

nalinrajgupta commented Jul 1, 2019 •

edited

Loading

AutorestCI commented Jul 1, 2019 •

edited

Loading

AutorestCI commented Jul 1, 2019 •

edited

Loading

AutorestCI commented Jul 1, 2019 •

edited

Loading

azuresdkci commented Jul 1, 2019

AutorestCI commented Jul 1, 2019 •

edited

Loading

EvgenyAgafonchikov left a comment

anton-evseev left a comment

jhendrixMSFT commented Jul 3, 2019

MikhailTryakhov commented Jul 10, 2019

MikhailTryakhov commented Jul 10, 2019

anton-evseev commented Jul 12, 2019

MikhailTryakhov commented Jul 15, 2019

ryansbenson left a comment

Adding VpnSiteLink and VpnSiteLinkConnection properties. #6528

Adding VpnSiteLink and VpnSiteLinkConnection properties. #6528

Conversation

nalinrajgupta commented Jul 1, 2019 • edited Loading

Latest improvements:

Contribution checklist:

ARM API Review Checklist

AutorestCI commented Jul 1, 2019 • edited Loading

Automation for azure-sdk-for-python

AutorestCI commented Jul 1, 2019 • edited Loading

Automation for azure-sdk-for-go

AutorestCI commented Jul 1, 2019 • edited Loading

Automation for azure-sdk-for-ruby

azuresdkci commented Jul 1, 2019

AutorestCI commented Jul 1, 2019 • edited Loading

Automation for azure-sdk-for-java

EvgenyAgafonchikov left a comment

Choose a reason for hiding this comment

anton-evseev left a comment

Choose a reason for hiding this comment

jhendrixMSFT commented Jul 3, 2019

MikhailTryakhov commented Jul 10, 2019

MikhailTryakhov commented Jul 10, 2019

anton-evseev commented Jul 12, 2019

MikhailTryakhov commented Jul 15, 2019

ryansbenson left a comment

Choose a reason for hiding this comment

nalinrajgupta commented Jul 1, 2019 •

edited

Loading

AutorestCI commented Jul 1, 2019 •

edited

Loading

AutorestCI commented Jul 1, 2019 •

edited

Loading

AutorestCI commented Jul 1, 2019 •

edited

Loading

AutorestCI commented Jul 1, 2019 •

edited

Loading