Add binary dataset in swagger #6569

TinaHu1 · 2019-07-09T07:47:22Z

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.
The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

openapi-sdkautomation · 2019-07-09T07:47:24Z

SDK Automation [Logs] (Generated from 25fb8b6, Iteration 3)

Python: Azure/azure-sdk-for-python [Logs] [Diff]

sdk/datafactory/azure-mgmt-datafactory [Logs] [Instructions]
- azure-mgmt-datafactory-0.7.0.zip
- azure_mgmt_datafactory-0.7.0-py2.py3-none-any.whl

Java: Azure/azure-sdk-for-java [Logs]

Package generation in progress.

Go: Azure/azure-sdk-for-go [Logs]

Package generation in progress.

JavaScript: Azure/azure-sdk-for-js [Logs]

Package generation in progress.

AutorestCI · 2019-07-09T07:48:24Z

Automation for azure-sdk-for-python

Encountered an unknown error: (azure-sdk-for-python)

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 33, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 170, in rest_handle_action
    return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 185, in rest_pull_close
    rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
    sdk_tag=sdk_tag
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 254, in generate_sdk_from_git_object
    with manage_git_folder(gh_token, Path(temp_dir) / Path("rest"), branched_rest_api_id, pr_number=pr_number) as restapi_git_folder, \
  File "/usr/lib/python3.6/contextlib.py", line 81, in __enter__
    return next(self.gen)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 272, in manage_git_folder
    clone_to_path(gh_token, temp_dir, split_git_id[0], branch_or_commit=branch, pr_number=pr_number)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 212, in clone_to_path
    repo.git.checkout(branch_or_commit)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 548, in <lambda>
    return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 1014, in _call_process
    return self.execute(call, **exec_kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 825, in execute
    raise GitCommandError(command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(128)
  cmdline: git checkout 3b91bf39cffee96102c9f67d98344673b94081dd
  stderr: 'fatal: reference is not a tree: 3b91bf39cffee96102c9f67d98344673b94081dd'

AutorestCI · 2019-07-09T07:49:34Z

Automation for azure-sdk-for-go

Encountered an unknown error: (azure-sdk-for-go)

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 33, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 170, in rest_handle_action
    return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 185, in rest_pull_close
    rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
    sdk_tag=sdk_tag
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 254, in generate_sdk_from_git_object
    with manage_git_folder(gh_token, Path(temp_dir) / Path("rest"), branched_rest_api_id, pr_number=pr_number) as restapi_git_folder, \
  File "/usr/lib/python3.6/contextlib.py", line 81, in __enter__
    return next(self.gen)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 272, in manage_git_folder
    clone_to_path(gh_token, temp_dir, split_git_id[0], branch_or_commit=branch, pr_number=pr_number)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 212, in clone_to_path
    repo.git.checkout(branch_or_commit)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 548, in <lambda>
    return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 1014, in _call_process
    return self.execute(call, **exec_kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 825, in execute
    raise GitCommandError(command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(128)
  cmdline: git checkout 3b91bf39cffee96102c9f67d98344673b94081dd
  stderr: 'fatal: reference is not a tree: 3b91bf39cffee96102c9f67d98344673b94081dd'

AutorestCI · 2019-07-09T07:51:37Z

Automation for azure-sdk-for-java

Encountered an unknown error: (azure-sdk-for-java)

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 33, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 170, in rest_handle_action
    return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 185, in rest_pull_close
    rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
    sdk_tag=sdk_tag
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 254, in generate_sdk_from_git_object
    with manage_git_folder(gh_token, Path(temp_dir) / Path("rest"), branched_rest_api_id, pr_number=pr_number) as restapi_git_folder, \
  File "/usr/lib/python3.6/contextlib.py", line 81, in __enter__
    return next(self.gen)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 272, in manage_git_folder
    clone_to_path(gh_token, temp_dir, split_git_id[0], branch_or_commit=branch, pr_number=pr_number)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 212, in clone_to_path
    repo.git.checkout(branch_or_commit)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 548, in <lambda>
    return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 1014, in _call_process
    return self.execute(call, **exec_kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 825, in execute
    raise GitCommandError(command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(128)
  cmdline: git checkout 3b91bf39cffee96102c9f67d98344673b94081dd
  stderr: 'fatal: reference is not a tree: 3b91bf39cffee96102c9f67d98344673b94081dd'

azuresdkci · 2019-07-09T08:31:52Z

Can one of the admins verify this patch?

amarzavery

Please provide updated x-ms-examples for the new model types that have been added to the spec.

amarzavery · 2019-07-11T18:38:06Z

...atafactory/resource-manager/Microsoft.DataFactory/stable/2018-06-01/entityTypes/Dataset.json

+      }
+    },
+    "BinaryDatasetTypeProperties": {
+      "description": "Binary dataset properties.",


missing "type": "object",

Hi, could you help review the pull request again? We need to merge our change as soon as possible to release our SDK and catch up the ETA of powershell release. Thanks.

amarzavery · 2019-07-11T18:39:41Z

...atafactory/resource-manager/Microsoft.DataFactory/stable/2018-06-01/entityTypes/Dataset.json

@@ -634,6 +634,39 @@
        "location"
      ]
    },
+    "BinaryDataset": {
+      "x-ms-discriminator-value": "Binary",


Adding a new polymorphic child to an existing stable api version constitutes a breaking change.

hey Amar, we've been adding new types all the time, and our customers are aware. If we had to create new API version for every type we would have tons API versions. It is not scalable.

Add binary dataset in swagger

d36a561

azuresdkci assigned amarzavery Jul 9, 2019

azuresdkci requested a review from amarzavery July 9, 2019 07:48

Merge branch 'master' into binary

4a41a1d

hvermis approved these changes Jul 11, 2019

View reviewed changes

add binary sink

25fb8b6

amarzavery suggested changes Jul 11, 2019

View reviewed changes

amarzavery added Breaking Change Review potential-sdk-breaking-change WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Jul 11, 2019

add type for binary type properties

d580034

AutorestCI mentioned this pull request Jul 12, 2019

[AutoPR datafactory/resource-manager] Add binary dataset in swagger Azure/azure-sdk-for-go#5229

Closed

TinaHu1 closed this Jul 16, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add binary dataset in swagger #6569

Add binary dataset in swagger #6569

TinaHu1 commented Jul 9, 2019

openapi-sdkautomation bot commented Jul 9, 2019 •

edited

Loading

AutorestCI commented Jul 9, 2019 •

edited

Loading

AutorestCI commented Jul 9, 2019 •

edited

Loading

AutorestCI commented Jul 9, 2019 •

edited

Loading

azuresdkci commented Jul 9, 2019

amarzavery left a comment

amarzavery Jul 11, 2019

TinaHu1 Jul 12, 2019

TinaHu1 Jul 15, 2019

amarzavery Jul 11, 2019

hvermis Jul 11, 2019

Add binary dataset in swagger #6569

Add binary dataset in swagger #6569

Conversation

TinaHu1 commented Jul 9, 2019

Latest improvements:

Contribution checklist:

ARM API Review Checklist

openapi-sdkautomation bot commented Jul 9, 2019 • edited Loading

SDK Automation [Logs] (Generated from 25fb8b6, Iteration 3)

AutorestCI commented Jul 9, 2019 • edited Loading

Automation for azure-sdk-for-python

AutorestCI commented Jul 9, 2019 • edited Loading

Automation for azure-sdk-for-go

AutorestCI commented Jul 9, 2019 • edited Loading

Automation for azure-sdk-for-java

azuresdkci commented Jul 9, 2019

amarzavery left a comment

Choose a reason for hiding this comment

amarzavery Jul 11, 2019

Choose a reason for hiding this comment

TinaHu1 Jul 12, 2019

Choose a reason for hiding this comment

TinaHu1 Jul 15, 2019

Choose a reason for hiding this comment

amarzavery Jul 11, 2019

Choose a reason for hiding this comment

hvermis Jul 11, 2019

Choose a reason for hiding this comment

openapi-sdkautomation bot commented Jul 9, 2019 •

edited

Loading

AutorestCI commented Jul 9, 2019 •

edited

Loading

AutorestCI commented Jul 9, 2019 •

edited

Loading

AutorestCI commented Jul 9, 2019 •

edited

Loading