Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improving Security Center pricing API documentation #6586

Merged
merged 1 commit into from
Jul 15, 2019

Conversation

nirwinter
Copy link
Contributor

@nirwinter nirwinter commented Jul 10, 2019

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 10, 2019

SDK Automation [Logs] (Generated from 149ce8a, Iteration 6)

Succeeded Go: Azure/azure-sdk-for-go [Logs] [Diff]
Succeeded Python: Azure/azure-sdk-for-python [Logs] [Diff]
Failed JavaScript: Azure/azure-sdk-for-js [Logs] [Diff]
  • No packages generated.

@AutorestCI
Copy link

AutorestCI commented Jul 10, 2019

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#5709

@AutorestCI
Copy link

AutorestCI commented Jul 10, 2019

Automation for azure-sdk-for-go

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-go#5176

@AutorestCI
Copy link

AutorestCI commented Jul 10, 2019

Automation for azure-sdk-for-java

Nothing to generate for azure-sdk-for-java

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@chlahav chlahav self-requested a review July 11, 2019 08:00
@raych1
Copy link
Member

raych1 commented Jul 11, 2019

@danschul, can you take a look at this JS SDK failures?

SDK Repository Error: {"message":"Bad credentials","documentation_url":"https://developer.github.com/v3"}

@nirwinter
Copy link
Contributor Author

@raych1 appreciate if you can complete this PR.

@ghost
Copy link

ghost commented Jul 12, 2019

@openapi sdkautomation rebuild

1 similar comment
@ghost
Copy link

ghost commented Jul 12, 2019

@openapi sdkautomation rebuild

@nirwinter
Copy link
Contributor Author

@daschult @raych1 appreciate of you can approve and complete this PR

@raych1 raych1 merged commit 41c7514 into Azure:master Jul 15, 2019
celikcigdem pushed a commit to celikcigdem/azure-rest-api-specs that referenced this pull request Jul 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants