Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dev/ccelik/dedicatedhostswagger #6612

Merged
merged 23 commits into from
Jul 17, 2019
Merged

Dev/ccelik/dedicatedhostswagger #6612

merged 23 commits into from
Jul 17, 2019

Conversation

celikcigdem
Copy link
Contributor

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@azuresdkci azuresdkci requested a review from yaohaizh July 12, 2019 22:39
@AutorestCI AutorestCI mentioned this pull request Jul 12, 2019
Merged
@AutorestCI
Copy link

AutorestCI commented Jul 12, 2019 •
edited
Loading

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#5853

@AutorestCI AutorestCI mentioned this pull request Jul 12, 2019
Merged
@AutorestCI
Copy link

AutorestCI commented Jul 12, 2019 •
edited
Loading

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#5212

@AutorestCI
Copy link

AutorestCI commented Jul 12, 2019 •
edited
Loading

Automation for azure-sdk-for-java

Nothing to generate for azure-sdk-for-java

hyonholee
hyonholee reviewed Jul 12, 2019
View reviewed changes
specification/compute/resource-manager/Microsoft.Compute/stable/2019-03-01/compute.json
@@ -5617,16 +5601,16 @@
"platformFaultDomain": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this also required property as platformFaultDomainCount?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not always, only if the platformDomainCount is > 1.

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

nschonni
nschonni reviewed Jul 12, 2019
View reviewed changes
specification/compute/resource-manager/Microsoft.Compute/stable/2019-03-01/compute.json Outdated
@@ -5617,16 +5601,16 @@
"platformFaultDomain": {
"type": "integer",
"format": "int32",
"description": "Fault domain of the host within a group. Supported values 0,1,2."
"description": "Fault domain of the dedicated host within a dedicated host group. Supported values 0,1,2."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could also use a min/max to describe the restriction

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the syntax for that?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found this in the repo

azure-rest-api-specs/specification/analysisservices/resource-manager/Microsoft.AnalysisServices/stable/2017-08-01/analysisservices.json

Lines 962 to 968 in 73cd215

"capacity": {
"type": "integer",
"minimum": 1,
"maximum": 8,
"default": 1,
"description": "The number of instances in the read only query pool."
}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although adding that rather than just the description, may be a breaking change

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! it is not breaking as service always rejected the requests with out of boundary values.

@celikcigdem
Copy link
Contributor Author

My model validation is failing due to a change that is already checked in. How can I unblock this PR?

@yaohaizh yaohaizh added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jul 13, 2019
@celikcigdem
Copy link
Contributor Author

My model validation is failing due to a change that is already checked in. How can I unblock this PR?

This is now fixed

@yaohaizh
Copy link
Contributor

@celikcigdem https://dev.azure.com/azure-sdk/public/_build/results?buildId=67405&view=logs&j=8d2f9c49-cd83-5a9d-f3fe-2fd651afa742&t=43324f1f-6724-5d61-785f-f0ac9fd256a1&l=28

Model validation error, please correct it.

KrisBash
KrisBash approved these changes Jul 17, 2019
View reviewed changes
Copy link
Contributor

@KrisBash KrisBash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These would be breaking changes, but SDKs for 2019-03-01 were generated prior to the introduction of these APIs. These are not breaking changes as they have not shipped previously.

@KrisBash KrisBash added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Jul 17, 2019
@yaohaizh yaohaizh merged commit c684818 into Azure:master Jul 17, 2019
@hyonholee hyonholee mentioned this pull request Jul 23, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nschonni nschonni nschonni left review comments

@hyonholee hyonholee hyonholee left review comments

@KrisBash KrisBash KrisBash approved these changes

@yaohaizh yaohaizh yaohaizh approved these changes

@huangpf huangpf Awaiting requested review from huangpf

Assignees

@yaohaizh yaohaizh

Labels
ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@celikcigdem @AutorestCI @azuresdkci @yaohaizh @nschonni @hyonholee @KrisBash