Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Hub Generated] Review request for Microsoft.Portal to add version preview/2019-01-01-preview #6643

Merged
merged 4 commits into from
Jul 23, 2019
Merged

[Hub Generated] Review request for Microsoft.Portal to add version preview/2019-01-01-preview #6643

merged 4 commits into from
Jul 23, 2019

Conversation

jjbfour
Copy link
Contributor

@jjbfour jjbfour commented Jul 16, 2019 •
edited
Loading

If you are a MSFT employee you can view your work branch via this link.

Contribution checklist:

@AutorestCI
Copy link

AutorestCI commented Jul 16, 2019 •
edited
Loading

Automation for azure-sdk-for-go

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-go#5324

@azuresdkci azuresdkci requested a review from lirenhe July 16, 2019 18:34
@AutorestCI AutorestCI mentioned this pull request Jul 16, 2019
Merged
@AutorestCI
Copy link

AutorestCI commented Jul 16, 2019 •
edited
Loading

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#5670

@AutorestCI
Copy link

AutorestCI commented Jul 16, 2019 •
edited
Loading

Automation for azure-sdk-for-java

Nothing to generate for azure-sdk-for-java

@AutorestCI AutorestCI mentioned this pull request Jul 16, 2019
Closed
@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@lirenhe
Copy link
Member

lirenhe commented Jul 18, 2019

@jjbfour , from your PR, I only find the version changed to 2019-01-01-preview. There is no other changes compared from the previous version. What is the purpose to release a new version with no actual change of the detail?

@jjbfour
Copy link
Contributor Author

jjbfour commented Jul 18, 2019 •
edited
Loading

@lirenhe The version update is because there was a backend change. Even though the schema didn't change we moved to a new system. This was to help that migration process.

@jjbfour jjbfour mentioned this pull request Jul 18, 2019
Closed
@lirenhe lirenhe added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jul 21, 2019
@anthony-c-martin anthony-c-martin added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Jul 22, 2019
anthony-c-martin
anthony-c-martin approved these changes Jul 22, 2019
View reviewed changes
Copy link
Member

@anthony-c-martin anthony-c-martin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Signing off for ARM

@lirenhe lirenhe merged commit f76827f into Azure:master Jul 23, 2019
@AutorestCI AutorestCI mentioned this pull request Jul 23, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lirenhe lirenhe lirenhe approved these changes

@anthony-c-martin anthony-c-martin anthony-c-martin approved these changes

Assignees

@lirenhe lirenhe

Labels
ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jjbfour @AutorestCI @azuresdkci @lirenhe @anthony-c-martin