Billing RP spec changes for GTM FieldLed-Go-Big #6661

asarkar84 · 2019-07-18T02:27:44Z

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.
The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

Added spec for Recurring charges api

Renamed recurring charges to recurring products

Updated the billing frequency type to string

Billing RP spec changes for GTM FieldLed-Go-Big

openapi-sdkautomation · 2019-07-18T02:27:47Z

In Testing, Please Ignore

[Logs] (Generated from 1527d6f, Iteration 33)

Python: test-repo-billy/azure-sdk-for-python [Logs] [Diff]

azure-mgmt-billing [Logs]

Java: test-repo-billy/azure-sdk-for-java [Logs] [Diff]

billing/resource-manager/v2017_02_27_preview [Logs]
billing/resource-manager/v2017_04_24_preview [Logs]
billing/resource-manager/v2018_03_01_preview [Logs]
billing/resource-manager/v2018_11_01_preview [Logs]
billing/resource-manager/v2019_10_01_preview [Logs]

Go: test-repo-billy/azure-sdk-for-go [Logs] [Diff]

preview/billing/mgmt/2017-02-27-preview [Logs]
preview/billing/mgmt/2017-04-24-preview [Logs]
preview/billing/mgmt/2018-03-01-preview [Logs]
preview/billing/mgmt/2018-11-01-preview [Logs]

JavaScript: test-repo-billy/azure-sdk-for-js [Logs] [Diff]

@azure/arm-billing [Logs]

Ruby: test-repo-billy/azure-sdk-for-ruby [Logs] [Diff]

No packages generated.

AutorestCI · 2019-07-18T02:28:33Z

Automation for azure-sdk-for-java

Encountered a Subprocess error: (azure-sdk-for-java)

Command: ['/usr/local/bin/autorest', '/tmp/tmpdd2hr_yz/rest/specification/billing/resource-manager/readme.md', '--azure-libraries-for-java-folder=/tmp/tmpdd2hr_yz/sdk', '--java', '--multiapi', '--use=@microsoft.azure/autorest.java@2.1.85', '--verbose']
Finished with return code 1
and output:

AutoRest code generation utility [version: 2.0.4283; node: v10.15.3]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest
   Loading AutoRest core      '/root/.autorest/@microsoft.azure_autorest-core@2.0.4383/node_modules/@microsoft.azure/autorest-core/dist' (2.0.4383)
   Loading AutoRest extension '@microsoft.azure/autorest.java' (2.1.85->2.1.85)
   Loading AutoRest extension '@microsoft.azure/autorest.modeler' (2.3.38->2.3.38)
Processing batch task - {"tag":"package-2019-10-preview"} .
FATAL: System.Exception: Duplicate File Generation: src/main/java/com/microsoft/azure/management/billing/v2019_10_01_preview/implementation/AddressInner.java
   at AutoRest.Core.CodeGenerator.<Write>d__13.MoveNext() in /home/vsts/work/1/s/autorest.common/src/CodeGenerator.cs:line 151
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at AutoRest.Core.CodeGenerator.<Write>d__12.MoveNext() in /home/vsts/work/1/s/autorest.common/src/CodeGenerator.cs:line 121
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at AutoRest.Java.Azure.Fluent.CodeGeneratorJvaf.<Generate>d__6.MoveNext() in /home/vsts/work/1/s/src/azurefluent/CodeGeneratorJvaf.cs:line 188
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at AutoRest.Java.Program.<ProcessInternal>d__3.MoveNext() in /home/vsts/work/1/s/src/Program.cs:line 114
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter`1.GetResult()
   at NewPlugin.<Process>d__20.MoveNext() in /home/vsts/work/1/s/autorest.common/src/Plugins/NewPlugin.cs:line 163
FATAL: java/generate - FAILED
FATAL: Error: Plugin java reported failure.
Process() cancelled due to exception : Plugin java reported failure.
Failure during batch task - {"tag":"package-2019-10-preview"} -- Error: Plugin java reported failure..
  Error: Plugin java reported failure.

AutorestCI · 2019-07-18T02:28:59Z

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#5564

AutorestCI · 2019-07-18T02:30:47Z

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#5446

azuresdkci · 2019-07-18T02:32:47Z

Can one of the admins verify this patch?

Rolled back the changes in 2018-11-01-preview version

Fixed build errors

Fixed build error

Updated policy properties

Incorporated review comments

asarkar84 · 2019-07-19T20:52:08Z

Updated action listInvoiceSectionsWithCreateSubscriptionPermission from GET to POST in this new iteration.

Incorporated review comments

Updated autorenew request params

Updated types for payment methods and available balance

Updated invoice section list examples

Updated pricesheet download path

Updated type for Invoice and Policy

Updated namespace for agreements

majastrz · 2019-08-01T23:07:16Z

  "post": {

POST on a collection URI in ARM is considered an anti-pattern. Is it possible to use PUT to create a billing role assignment on the billing account? If not, the alternative would be to have a POST action called createBillingRoleAssignment on a billingAccount resource. #Closed

Refers to: specification/billing/resource-manager/Microsoft.Billing/preview/2019-10-01-preview/billing.json:3346 in 18ddcc3. [](commit_id = 18ddcc3, deletion_comment = False)

majastrz · 2019-08-01T23:08:45Z

  "post": {

Same collection POST issue here. #Closed

Refers to: specification/billing/resource-manager/Microsoft.Billing/preview/2019-10-01-preview/billing.json:3431 in 18ddcc3. [](commit_id = 18ddcc3, deletion_comment = False)

majastrz · 2019-08-01T23:09:39Z

  "post": {

Same collection POST issue here. #Closed

Refers to: specification/billing/resource-manager/Microsoft.Billing/preview/2019-10-01-preview/billing.json:3519 in 18ddcc3. [](commit_id = 18ddcc3, deletion_comment = False)

majastrz · 2019-08-01T23:11:29Z

      "enum": [

You will need to specify the x-ms-enum extension. Also, you will need to use the modelAsString: true setting to make the linter happy. #Closed

Refers to: specification/billing/resource-manager/Microsoft.Billing/preview/2019-10-01-preview/billing.json:4311 in 18ddcc3. [](commit_id = 18ddcc3, deletion_comment = False)

majastrz · 2019-08-01T23:11:46Z

      "enum": [

This applies to all the enums in here.

In reply to: 517489699 [](ancestors = 517489699)

Refers to: specification/billing/resource-manager/Microsoft.Billing/preview/2019-10-01-preview/billing.json:4311 in 18ddcc3. [](commit_id = 18ddcc3, deletion_comment = False)

majastrz · 2019-08-01T23:17:44Z

"swagger": "2.0",

A few of the CI checks are failing. You'll need to fix the failures (the assigned SDK reviewer can help).

Refers to: specification/billing/resource-manager/Microsoft.Billing/preview/2019-10-01-preview/billing.json:2 in 18ddcc3. [](commit_id = 18ddcc3, deletion_comment = False)

majastrz

I added a few comments for the remaining issues.

Also, there are a lot of breaking changes in the API. I assume this is intentional, but how are you planning to deal with that? (If it was discussed with prior reviewers, I don’t have that context ☹.)

Fixed build errors

asarkar84 · 2019-08-03T00:30:55Z

      "enum": [
You will need to specify the x-ms-enum extension. Also, you will need to use the modelAsString: true setting to make the linter happy.

Refers to: specification/billing/resource-manager/Microsoft.Billing/preview/2019-10-01-preview/billing.json:4311 in 18ddcc3. [](commit_id = 18ddcc3, deletion_comment = False)

Sure. Done.

Updated BillingRoleAssignments actions

asarkar84 · 2019-08-03T00:47:32Z

@majastrz I have incorporated the comments provided. Please take a look.

Regarding BillingRoleAssignments actions in List API, I have removed the POST operation from the List API and created a new path with createBillingRoleAssignment action. We had this in our previous version and the current change was done as part of improvement. We will attempt this change again when we have support for PUT operation in our platform in future.

Added Transfer apis for partner led

Removing listInvoiceSectionsWithCreateSubscriptionPermission

majastrz

Signed off from ARM side.

…quest body

* API updates * run prettier * Remove old examples * more changes * update property name * update readme.go.md Co-authored-by: ArcturusZhang <dapzhang@microsoft.com>

asarkar84 added 5 commits June 17, 2019 18:04

Added spec for Recurring charges api

563a6ee

Added spec for Recurring charges api

Renamed recurring charges to recurring products

43140c4

Renamed recurring charges to recurring products

Updated the billing frequency type to string

03a7147

Updated the billing frequency type to string

Merge remote-tracking branch 'upstream/master'

57717d9

Billing RP spec changes for GTM FieldLed-Go-Big

967bc13

Billing RP spec changes for GTM FieldLed-Go-Big

asarkar84 requested a review from wilcobmsft as a code owner July 18, 2019 02:27

AutorestCI mentioned this pull request Jul 18, 2019

[AutoPR billing/resource-manager] Billing RP spec changes for GTM FieldLed-Go-Big Azure/azure-sdk-for-python#6397

Merged

azuresdkci assigned lirenhe Jul 18, 2019

azuresdkci requested a review from lirenhe July 18, 2019 02:29

AutorestCI mentioned this pull request Jul 18, 2019

[AutoPR billing/resource-manager] Billing RP spec changes for GTM FieldLed-Go-Big Azure/azure-sdk-for-go#5287

Merged

Rolled back the changes in 2018-11-01-preview version

b284504

Rolled back the changes in 2018-11-01-preview version

msft-adrianma added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jul 18, 2019

asarkar84 added 6 commits July 17, 2019 19:52

Fixed build errors

d091ef6

Fixed build errors

Fixed build error

3389cad

Fixed build error

Fixed build errors

d03bdfd

Update billing.json

12a3f4c

Updated policy properties

0a3d64e

Updated policy properties

Incorporated review comments

aa563c5

Incorporated review comments

asarkar84 added 6 commits July 22, 2019 15:25

Incorporated review comments

0675925

Incorporated review comments

Updated autorenew request params

cf675f3

Updated autorenew request params

Updated types for payment methods and available balance

f192330

Updated types for payment methods and available balance

Updated invoice section list examples

c018eb9

Updated invoice section list examples

Updated pricesheet download path

ec62a59

Updated pricesheet download path

Updated type for Invoice and Policy

9f20843

Updated type for Invoice and Policy

openapi-sdkautomation bot mentioned this pull request Jul 27, 2019

[AutoPR @azure/arm-billing] Billing RP spec changes for GTM FieldLed-Go-Big Azure/azure-sdk-for-js#4473

Closed

msft-adrianma self-requested a review July 30, 2019 21:12

Updated namespace for agreements

18ddcc3

Updated namespace for agreements

majastrz added the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Aug 1, 2019

majastrz requested changes Aug 1, 2019

View reviewed changes

asarkar84 added 6 commits August 2, 2019 16:17

Incorporated review coments

1790ba7

Incorporated review comments

d0721dd

Incorporated review comments

c61229b

Incorporated review comments

c16ee5e

Fixed build errors

5091b5f

Fixed build errors

Fixed build errors

3559e48

Fixed build errors

Updated BillingRoleAssignments actions

a30934c

Updated BillingRoleAssignments actions

asarkar84 added 2 commits August 2, 2019 19:44

Added Transfer apis for partner led

09cbd07

Added Transfer apis for partner led

Removing listInvoiceSectionsWithCreateSubscriptionPermission

be18185

Removing listInvoiceSectionsWithCreateSubscriptionPermission

majastrz approved these changes Aug 4, 2019

View reviewed changes

Removed unused property, billing profile id is not required in the re…

1527d6f

…quest body

lirenhe approved these changes Aug 6, 2019

View reviewed changes

lirenhe merged commit b6967e4 into Azure:master Aug 6, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Billing RP spec changes for GTM FieldLed-Go-Big #6661

Billing RP spec changes for GTM FieldLed-Go-Big #6661

asarkar84 commented Jul 18, 2019 •

edited

Loading

openapi-sdkautomation bot commented Jul 18, 2019 •

edited

Loading

AutorestCI commented Jul 18, 2019 •

edited

Loading

AutorestCI commented Jul 18, 2019 •

edited

Loading

AutorestCI commented Jul 18, 2019 •

edited

Loading

azuresdkci commented Jul 18, 2019

asarkar84 commented Jul 19, 2019 •

edited

Loading

majastrz commented Aug 1, 2019 •

edited

Loading

majastrz commented Aug 1, 2019 •

edited

Loading

majastrz commented Aug 1, 2019 •

edited

Loading

majastrz commented Aug 1, 2019 •

edited

Loading

majastrz commented Aug 1, 2019

majastrz commented Aug 1, 2019 •

edited

Loading

majastrz left a comment

asarkar84 commented Aug 3, 2019

asarkar84 commented Aug 3, 2019 •

edited

Loading

majastrz left a comment

Billing RP spec changes for GTM FieldLed-Go-Big #6661

Billing RP spec changes for GTM FieldLed-Go-Big #6661

Conversation

asarkar84 commented Jul 18, 2019 • edited Loading

Latest improvements:

Contribution checklist:

ARM API Review Checklist

openapi-sdkautomation bot commented Jul 18, 2019 • edited Loading

In Testing, Please Ignore

[Logs] (Generated from 1527d6f, Iteration 33)

AutorestCI commented Jul 18, 2019 • edited Loading

Automation for azure-sdk-for-java

AutorestCI commented Jul 18, 2019 • edited Loading

Automation for azure-sdk-for-python

AutorestCI commented Jul 18, 2019 • edited Loading

Automation for azure-sdk-for-go

azuresdkci commented Jul 18, 2019

asarkar84 commented Jul 19, 2019 • edited Loading

majastrz commented Aug 1, 2019 • edited Loading

majastrz commented Aug 1, 2019 • edited Loading

majastrz commented Aug 1, 2019 • edited Loading

majastrz commented Aug 1, 2019 • edited Loading

majastrz commented Aug 1, 2019

majastrz commented Aug 1, 2019 • edited Loading

majastrz left a comment

Choose a reason for hiding this comment

asarkar84 commented Aug 3, 2019

asarkar84 commented Aug 3, 2019 • edited Loading

majastrz left a comment

Choose a reason for hiding this comment

asarkar84 commented Jul 18, 2019 •

edited

Loading

openapi-sdkautomation bot commented Jul 18, 2019 •

edited

Loading

AutorestCI commented Jul 18, 2019 •

edited

Loading

AutorestCI commented Jul 18, 2019 •

edited

Loading

AutorestCI commented Jul 18, 2019 •

edited

Loading

asarkar84 commented Jul 19, 2019 •

edited

Loading

majastrz commented Aug 1, 2019 •

edited

Loading

majastrz commented Aug 1, 2019 •

edited

Loading

majastrz commented Aug 1, 2019 •

edited

Loading

majastrz commented Aug 1, 2019 •

edited

Loading

majastrz commented Aug 1, 2019 •

edited

Loading

asarkar84 commented Aug 3, 2019 •

edited

Loading