Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add terminate profile and scheduled events profile to Microsoft.Compute #6683

Merged
merged 10 commits into from
Aug 1, 2019
Merged

Add terminate profile and scheduled events profile to Microsoft.Compute #6683

merged 10 commits into from
Aug 1, 2019

Conversation

szimmer-dev
Copy link
Contributor

@szimmer-dev szimmer-dev commented Jul 20, 2019 •
edited
Loading

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 20, 2019 •
edited
Loading

SDK Automation [Logs] (Generated from 84963d0, Iteration 12)

Failed Python: Azure/azure-sdk-for-python [Logs]
  • No packages generated.
Failed Java: Azure/azure-sdk-for-java [Logs] [Diff]
Failed JavaScript: Azure/azure-sdk-for-js [Logs]
  • No packages generated.
Failed Go: test-repo-billy/azure-sdk-for-go [Logs]
  • No packages generated.
Succeeded Ruby: Azure/azure-sdk-for-ruby [Logs] [Diff]

@AutorestCI AutorestCI mentioned this pull request Jul 20, 2019
Closed
@AutorestCI
Copy link

AutorestCI commented Jul 20, 2019 •
edited
Loading

Automation for azure-sdk-for-python

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-python#6461

@AutorestCI AutorestCI mentioned this pull request Jul 20, 2019
Merged
@AutorestCI
Copy link

AutorestCI commented Jul 20, 2019 •
edited
Loading

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#5409

@AutorestCI
Copy link

AutorestCI commented Jul 20, 2019 •
edited
Loading

Automation for azure-sdk-for-java

Nothing to generate for azure-sdk-for-java

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

nschonni
nschonni reviewed Jul 20, 2019
View reviewed changes
Copy link
Contributor

@nschonni nschonni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there was a character encoding issue

specification/compute/resource-manager/Microsoft.Compute/stable/2019-03-01/compute.json Outdated Show resolved Hide resolved
specification/compute/resource-manager/Microsoft.Compute/stable/2019-03-01/compute.json Outdated Show resolved Hide resolved
@szimmer-dev @nschonni
Update specification/compute/resource-manager/Microsoft.Compute/stabl…
a7b448e 
…e/2019-03-01/compute.json

Co-Authored-By: Nick Schonning <nschonni@gmail.com>
@hyonholee hyonholee added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jul 24, 2019
szimmer-dev and others added 2 commits July 24, 2019 15:21
@szimmer-dev @nschonni
Update specification/compute/resource-manager/Microsoft.Compute/stabl…
d99620f 
…e/2019-03-01/compute.json

Co-Authored-By: Nick Schonning <nschonni@gmail.com>
@szimmer-dev
Add ScheduledEventsProfile to the UpdateVMScaleSetVM model, and add i…
722acaf 
…nstance

view expansion to get VM Scale Set VM.
This was referenced Jul 29, 2019
Merged
Merged
Merged
Merged
Merged
amarzavery
amarzavery suggested changes Jul 30, 2019
View reviewed changes
Copy link
Contributor

@amarzavery amarzavery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please provide new examples or update existing examples with the new properties/models being added in this PR.

specification/compute/resource-manager/Microsoft.Compute/stable/2019-03-01/compute.json Show resolved Hide resolved
specification/compute/resource-manager/Microsoft.Compute/stable/2019-03-01/compute.json Show resolved Hide resolved
specification/compute/resource-manager/Microsoft.Compute/stable/2019-03-01/compute.json Show resolved Hide resolved
@szimmer-dev
Copy link
Contributor Author

update

Example was added as requested.

@hyonholee
Copy link
Contributor

LGTM

majastrz
majastrz reviewed Aug 1, 2019
View reviewed changes
Copy link
Member

@majastrz majastrz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added some questions to the PR. Can you take a look?

@majastrz majastrz added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed ARMReviewInProgress WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Aug 1, 2019
majastrz
majastrz approved these changes Aug 1, 2019
View reviewed changes
Copy link
Member

@majastrz majastrz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Signed off from ARM side.

@amarzavery amarzavery merged commit ab88105 into Azure:master Aug 1, 2019
@szimmer-dev szimmer-dev mentioned this pull request Aug 2, 2019
Merged
@szimmer-dev szimmer-dev mentioned this pull request Sep 4, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nschonni nschonni nschonni left review comments

@hyonholee hyonholee hyonholee approved these changes

@amarzavery amarzavery amarzavery approved these changes

@majastrz majastrz majastrz approved these changes

@huangpf huangpf Awaiting requested review from huangpf

Assignees

@amarzavery amarzavery

Labels
ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@szimmer-dev @AutorestCI @azuresdkci @hyonholee @nschonni @amarzavery @majastrz