VMware by Virtustream API 2019-08-09-preview

[ctaggart]

This is a new API specification version based on ARM feedback in #6653. We still need to review the credentials handling on a call. Here is a list of changes:

• Get / Update the same types
• Add PrivateClouds_Update (PATCH)
• Remove PrivateClouds_AddIdentitySource, PrivateClouds_DeleteIdentitySource, PrivateClouds_AddAuthorization, PrivateClouds_DeleteAuthorization. Use PrivateClouds_Update instead.
• Follow long running async pattern for updates that return a 201 instead of a 202
• Make Clusters_List pageable
• use enums instead of booleans
• changed PrivateClouds_GetAdminCredentials to PrivateClouds_ListAdminCredentials for template deployments

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

• I have reviewed the documentation for the workflow.
• Validation tools were run on swagger spec(s) and have all been fixed in this PR.
• The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

• Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
• adding/removing APIs.
• adding/removing properties.
• adding/removing API-version.
• adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

• If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
  Please follow the link to find more details on API review process.

[openapi-sdkautomation]

In Testing, Please Ignore

[Logs] (Generated from f8c37b3, Iteration 16)

JavaScript: test-repo-billy/azure-sdk-for-js [Logs] [Diff]

• @azure/arm-vmwarevirtustream [Logs] [Instructions]
  • azure-arm-vmwarevirtustream-0.2.0.tgz

Python: test-repo-billy/azure-sdk-for-python [Logs] [Diff]

• No packages generated.

.NET: test-repo-billy/azure-sdk-for-net [Logs] [Diff]

• No packages generated.

[AutorestCI]

Automation for azure-sdk-for-go

Nothing to generate for azure-sdk-for-go

[AutorestCI]

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#7389

[azuresdkci]

Can one of the admins verify this patch?

[ctaggart]

@anthony-c-martin, I added an overview of changes to the description above. They are all based on feedback in #6653.

[anthony-c-martin]

Looks great to me! Thanks for incorporating all the feedback from the previous iteration.

[yungezz]

Hi @ctaggart is this PR ready to merge?

[ctaggart]

The feedback I received was that this would not be merged until the service is ready for public preview. To continue to receive feedback, I moved it to the private repository.

[ctaggart]

This VMware by Virtustream API 2019-08-09-preview is now available in all supported locations. I just released a new version of azure-vmware-virtustream-cli-extension that uses this. @yungezz, it is ready to merge.

[lmazuel]

LGTM

[yungezz]

HI @ctaggart , since the service is public now, do you need SDK released for this PR? If yes, pls share languages you're interested at. We'll do the release then, since the pipeline need Microsoft employee's permission. Or you just want SDK generated, but not released?

[yungezz]

@ctaggart , per communication with Microsoft team who worked with you on this service(pls ping me if you need the name) , the product is not ready for public, so we'll revert this PR in this repo. Pls continue working on private repo azure-rest-api-spesc-pr. Meanwhile, we'll looking at how to generate a private SDKs for you based on private repo's PR https://github.com/Azure/azure-rest-api-specs-pr/pull/885, but NOT releasing. Will let you know if there's any update. Meanwhile, pls ping me if any question about Swagger, SDK generation etc.