Remove billingProfile from PartnerLed transfer APIs. #6888

jbnpaul · 2019-08-07T03:23:26Z

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.
The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

openapi-sdkautomation · 2019-08-07T03:23:28Z

In Testing, Please Ignore

[Logs] (Generated from abcb289, Iteration 10)

.NET: test-repo-billy/azure-sdk-for-net [Logs] [Diff]

Microsoft.Azure.Management.Billing [Logs] [Instructions] [Generation PR]
- Microsoft.Azure.Management.Billing.2.1.1-preview.nupkg
- Microsoft.Azure.Management.Billing.2.1.1-preview.snupkg

Python: test-repo-billy/azure-sdk-for-python [Logs] [Diff]

azure-mgmt-billing [Logs] [Instructions] [Generation PR]
- azure-mgmt-billing-0.2.0.zip
- azure_mgmt_billing-0.2.0-py2.py3-none-any.whl

Java: test-repo-billy/azure-sdk-for-java [Logs] [Diff]

billing/resource-manager/v2017_02_27_preview [Logs] [Instructions] [Generation PR]
billing/resource-manager/v2017_04_24_preview [Logs] [Instructions] [Generation PR]
billing/resource-manager/v2018_03_01_preview [Logs] [Instructions] [Generation PR]
billing/resource-manager/v2018_11_01_preview [Logs] [Generation PR]
billing/resource-manager/v2019_10_01_preview [Logs] [Generation PR]

Go: test-repo-billy/azure-sdk-for-go [Logs] [Diff]

preview/billing/mgmt/2017-02-27-preview [Logs]
preview/billing/mgmt/2017-04-24-preview [Logs]
preview/billing/mgmt/2018-03-01-preview [Logs]
preview/billing/mgmt/2018-11-01-preview [Logs]

JavaScript: test-repo-billy/azure-sdk-for-js [Logs] [Diff]

@azure/arm-billing [Logs] [Instructions] [Generation PR]
- azure-arm-billing-2.2.0.tgz

Ruby: test-repo-billy/azure-sdk-for-ruby [Logs] [Diff]

No packages generated.

AutorestCI · 2019-08-07T03:24:51Z

Automation for azure-sdk-for-python

Encountered an unknown error: (azure-sdk-for-python)

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 33, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 170, in rest_handle_action
    return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 185, in rest_pull_close
    rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
    sdk_tag=sdk_tag
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 254, in generate_sdk_from_git_object
    with manage_git_folder(gh_token, Path(temp_dir) / Path("rest"), branched_rest_api_id, pr_number=pr_number) as restapi_git_folder, \
  File "/usr/lib/python3.6/contextlib.py", line 81, in __enter__
    return next(self.gen)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 272, in manage_git_folder
    clone_to_path(gh_token, temp_dir, split_git_id[0], branch_or_commit=branch, pr_number=pr_number)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 212, in clone_to_path
    repo.git.checkout(branch_or_commit)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 548, in <lambda>
    return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 1014, in _call_process
    return self.execute(call, **exec_kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 825, in execute
    raise GitCommandError(command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(128)
  cmdline: git checkout 73a23ca3a9617d0cf0d837e2361e2fa5fc966e27
  stderr: 'fatal: reference is not a tree: 73a23ca3a9617d0cf0d837e2361e2fa5fc966e27'

AutorestCI · 2019-08-07T03:26:10Z

Automation for azure-sdk-for-go

Encountered an unknown error: (azure-sdk-for-go)

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 33, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 170, in rest_handle_action
    return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 185, in rest_pull_close
    rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
    sdk_tag=sdk_tag
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 254, in generate_sdk_from_git_object
    with manage_git_folder(gh_token, Path(temp_dir) / Path("rest"), branched_rest_api_id, pr_number=pr_number) as restapi_git_folder, \
  File "/usr/lib/python3.6/contextlib.py", line 81, in __enter__
    return next(self.gen)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 272, in manage_git_folder
    clone_to_path(gh_token, temp_dir, split_git_id[0], branch_or_commit=branch, pr_number=pr_number)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 212, in clone_to_path
    repo.git.checkout(branch_or_commit)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 548, in <lambda>
    return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 1014, in _call_process
    return self.execute(call, **exec_kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 825, in execute
    raise GitCommandError(command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(128)
  cmdline: git checkout 73a23ca3a9617d0cf0d837e2361e2fa5fc966e27
  stderr: 'fatal: reference is not a tree: 73a23ca3a9617d0cf0d837e2361e2fa5fc966e27'

azuresdkci · 2019-08-07T03:32:17Z

Can one of the admins verify this patch?

ravbhatnagar · 2019-08-09T18:08:29Z

signing off from ARM side. This API is not live yet. So not a breaking change

yungezz · 2019-08-16T06:49:11Z

Hi @jbnpaul is this PR ready to merge? could you pls address errors in CI?

anuchandy

@jbnpaul please address CI failures

anuchandy · 2019-09-11T00:05:22Z

@jbnpaul closing this PR due to no activity, feel free to reopen when you're ready.

Remove billingProfile from PartnerLed transfer APIs.

9eb7350

jbnpaul requested a review from wilcobmsft as a code owner August 7, 2019 03:23

AutorestCI mentioned this pull request Aug 7, 2019

[AutoPR billing/resource-manager] Remove billingProfile from PartnerLed transfer APIs. Azure/azure-sdk-for-python#6709

Closed

azuresdkci assigned anuchandy Aug 7, 2019

azuresdkci requested a review from anuchandy August 7, 2019 03:25

wilcobmsft approved these changes Aug 7, 2019

View reviewed changes

ravbhatnagar added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Aug 9, 2019

Add validation transfer API for Microsoft.Billing.

abcb289

PhoenixHe-NV mentioned this pull request Aug 16, 2019

[Mirror] Remove billingProfile from PartnerLed transfer APIs. test-repo-tih/azure-rest-api-specs#126

Closed

anuchandy requested changes Aug 19, 2019

View reviewed changes

anuchandy closed this Sep 11, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove billingProfile from PartnerLed transfer APIs. #6888

Remove billingProfile from PartnerLed transfer APIs. #6888

jbnpaul commented Aug 7, 2019 •

edited

Loading

openapi-sdkautomation bot commented Aug 7, 2019 •

edited

Loading

AutorestCI commented Aug 7, 2019 •

edited

Loading

AutorestCI commented Aug 7, 2019 •

edited

Loading

azuresdkci commented Aug 7, 2019

ravbhatnagar commented Aug 9, 2019

yungezz commented Aug 16, 2019 •

edited

Loading

anuchandy left a comment

anuchandy commented Sep 11, 2019

Remove billingProfile from PartnerLed transfer APIs. #6888

Remove billingProfile from PartnerLed transfer APIs. #6888

Conversation

jbnpaul commented Aug 7, 2019 • edited Loading

Latest improvements:

Contribution checklist:

ARM API Review Checklist

openapi-sdkautomation bot commented Aug 7, 2019 • edited Loading

In Testing, Please Ignore

[Logs] (Generated from abcb289, Iteration 10)

AutorestCI commented Aug 7, 2019 • edited Loading

Automation for azure-sdk-for-python

AutorestCI commented Aug 7, 2019 • edited Loading

Automation for azure-sdk-for-go

azuresdkci commented Aug 7, 2019

ravbhatnagar commented Aug 9, 2019

yungezz commented Aug 16, 2019 • edited Loading

anuchandy left a comment

Choose a reason for hiding this comment

anuchandy commented Sep 11, 2019

jbnpaul commented Aug 7, 2019 •

edited

Loading

openapi-sdkautomation bot commented Aug 7, 2019 •

edited

Loading

AutorestCI commented Aug 7, 2019 •

edited

Loading

AutorestCI commented Aug 7, 2019 •

edited

Loading

yungezz commented Aug 16, 2019 •

edited

Loading