[Hub Generated] Review request for Microsoft.Devices to add version stable/2019-03-22 #6932

reshantchandra · 2019-08-12T17:56:25Z

If you are a MSFT employee you can view your work branch via this link.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.

…-22-preview to version 2019-03-22

openapi-sdkautomation · 2019-08-12T17:56:28Z

In Testing, Please Ignore

[Logs] (Generated from f05eef4, Iteration 19)

.NET: test-repo-billy/azure-sdk-for-net [Logs] [Diff]

Microsoft.Azure.Management.IotHub [Logs] [Instructions] [Generation PR]
- Microsoft.Azure.Management.IotHub.2.9.0-preview.nupkg
- Microsoft.Azure.Management.IotHub.2.9.0-preview.snupkg

Python: test-repo-billy/azure-sdk-for-python [Logs] [Diff]

azure-mgmt-iothub [Logs] [Instructions] [Generation PR] [Integration PR]
- azure-mgmt-iothub-0.8.2.zip
- azure_mgmt_iothub-0.8.2-py2.py3-none-any.whl

Java: test-repo-billy/azure-sdk-for-java [Logs] [Diff]

iothub/resource-manager/v2018_04_01 [Logs] [Generation PR] [Integration PR]
iothub/resource-manager/v2018_12_01_preview [Logs] [Generation PR] [Integration PR]
iothub/resource-manager/v2019_03_22_preview [Logs] [Generation PR]

Go: test-repo-billy/azure-sdk-for-go [Logs] [Diff]

iothub/mgmt/2016-02-03 [Logs]
iothub/mgmt/2017-01-19 [Logs]
iothub/mgmt/2017-07-01 [Logs]
iothub/mgmt/2018-01-22 [Logs]
iothub/mgmt/2018-04-01 [Logs]
preview/iothub/mgmt/2018-12-01-preview [Logs]
preview/iothub/mgmt/2019-03-22-preview [Logs]

JavaScript: test-repo-billy/azure-sdk-for-js [Logs] [Diff]

@azure/arm-iothub [Logs] [Instructions] [Generation PR] [Integration PR]
- azure-arm-iothub-3.0.0.tgz

Ruby: test-repo-billy/azure-sdk-for-ruby [Logs] [Diff]

azure_sdk [Logs] [Instructions]
- azure_sdk-0.19.7.gem

AutorestCI · 2019-08-12T17:57:48Z

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#6871

azuresdkci · 2019-08-12T18:02:36Z

Can one of the admins verify this patch?

AutorestCI · 2019-08-12T18:07:59Z

Automation for azure-sdk-for-go

Nothing to generate for azure-sdk-for-go

specification/iothub/resource-manager/Microsoft.Devices/stable/2019-03-22/iothub.json

jlian · 2019-08-12T19:42:43Z

Reason why we closed the PR for now: just talked to @reshantchandra and we noticed that the locations property isn't being properly returned by IoT Hub service for this API version (unlike 2019-03-22-preview). We figured the best thing to do is to close the PR until we figure out what to do.

The part that's missing

    "locations": [
      {
        "location": "West US",
        "role": "primary"
      },
      {
        "location": "East US",
        "role": "secondary"
      }
    ],

reshantchandra · 2019-08-20T21:57:51Z

We resolved the location property issue now we see primary and secondary location as expected.

…/2019-03-22/iothub.json Co-Authored-By: John Lian <jlian@users.noreply.github.com>

specification/iothub/resource-manager/Microsoft.Devices/stable/2019-03-22/iothub.json

jlian

Small description update

…/2019-03-22/iothub.json Co-Authored-By: John Lian <jlian@users.noreply.github.com>

specification/iothub/resource-manager/Microsoft.Devices/stable/2019-03-22/iothub.json

yungezz · 2019-08-28T08:45:37Z

hi @reshantchandra @myronfanqiu what's the status of this PR? is it ready for merge?

mmyyrroonn

LGTM. Compared with the corresponding preview version. Just small change. Please solve the ARM's comment and I can merge this PR.

mmyyrroonn · 2019-09-02T02:05:50Z

@reshantchandra Please resolve the ARM's comments. @jlian Looks like the author has updated the PR. Could you please check it and approve this PR?

reshantchandra · 2019-09-03T16:30:13Z

comments resolved

mmyyrroonn · 2019-09-04T02:08:46Z

@jlian If you think this PR is good, please approve it so that I can merge this PR.

reshantchandra and others added 6 commits July 2, 2019 22:21

Adds base for updating Microsoft.Devices from version preview/2019-03…

44e3faa

…-22-preview to version 2019-03-22

Updates readme

e635b1e

Updates API version in new specs and examples

fffb832

Adding new stable api for manual failover

c9a2f21

adding locations property

0e4e9ae

adding locations property

059a962

azuresdkci assigned mmyyrroonn Aug 12, 2019

azuresdkci requested a review from mmyyrroonn August 12, 2019 17:57

AutorestCI mentioned this pull request Aug 12, 2019

[AutoPR iothub/resource-manager] [Hub Generated] Review request for Microsoft.Devices to add version stable/2019-03-22 Azure/azure-sdk-for-python#6759

Closed

reshantchandra requested review from jlian, shansin and rkmanda August 12, 2019 17:59

reshantchandra added the DoNotMerge <valid label in PR review process> use to hold merge after approval label Aug 12, 2019

reshantchandra closed this Aug 12, 2019

jlian requested changes Aug 12, 2019

View reviewed changes

reshantchandra reopened this Aug 20, 2019

AutorestCI mentioned this pull request Aug 20, 2019

[AutoPR iothub/resource-manager] [Hub Generated] Review request for Microsoft.Devices to add version stable/2019-03-22 Azure/azure-sdk-for-python#6870

Merged

reshantchandra and others added 6 commits August 20, 2019 15:16

Update specification/iothub/resource-manager/Microsoft.Devices/stable…

96b62e4

…/2019-03-22/iothub.json Co-Authored-By: John Lian <jlian@users.noreply.github.com>

Update specification/iothub/resource-manager/Microsoft.Devices/stable…

83d902f

…/2019-03-22/iothub.json Co-Authored-By: John Lian <jlian@users.noreply.github.com>

Update specification/iothub/resource-manager/Microsoft.Devices/stable…

77b7c3e

…/2019-03-22/iothub.json Co-Authored-By: John Lian <jlian@users.noreply.github.com>

Update specification/iothub/resource-manager/Microsoft.Devices/stable…

8262bcd

…/2019-03-22/iothub.json Co-Authored-By: John Lian <jlian@users.noreply.github.com>

Update specification/iothub/resource-manager/Microsoft.Devices/stable…

4c0466f

…/2019-03-22/iothub.json Co-Authored-By: John Lian <jlian@users.noreply.github.com>

Update specification/iothub/resource-manager/Microsoft.Devices/stable…

8ba1b37

…/2019-03-22/iothub.json Co-Authored-By: John Lian <jlian@users.noreply.github.com>

shansin approved these changes Aug 20, 2019

View reviewed changes

jlian reviewed Aug 20, 2019

View reviewed changes

specification/iothub/resource-manager/Microsoft.Devices/stable/2019-03-22/iothub.json Outdated Show resolved Hide resolved

jlian reviewed Aug 20, 2019

View reviewed changes

specification/iothub/resource-manager/Microsoft.Devices/stable/2019-03-22/iothub.json Outdated Show resolved Hide resolved

jlian requested changes Aug 20, 2019

View reviewed changes

reshantchandra removed the DoNotMerge <valid label in PR review process> use to hold merge after approval label Aug 21, 2019

reshantchandra and others added 2 commits August 20, 2019 23:30

Update specification/iothub/resource-manager/Microsoft.Devices/stable…

3ae1861

…/2019-03-22/iothub.json Co-Authored-By: John Lian <jlian@users.noreply.github.com>

Update specification/iothub/resource-manager/Microsoft.Devices/stable…

bc92974

…/2019-03-22/iothub.json Co-Authored-By: John Lian <jlian@users.noreply.github.com>

mmyyrroonn added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Aug 22, 2019

anthony-c-martin approved these changes Aug 27, 2019

View reviewed changes

specification/iothub/resource-manager/Microsoft.Devices/stable/2019-03-22/iothub.json Outdated Show resolved Hide resolved

anthony-c-martin added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Aug 27, 2019

mmyyrroonn approved these changes Aug 28, 2019

View reviewed changes

Update iothub.json

f05eef4

openapi-sdkautomation bot mentioned this pull request Sep 3, 2019

[AutoPR Microsoft.Azure.Management.IotHub] [Hub Generated] Review request for Microsoft.Devices to add version stable/2019-03-22 test-repo-billy/azure-sdk-for-net#173

Merged

jlian approved these changes Sep 4, 2019

View reviewed changes

mmyyrroonn merged commit d90a116 into Azure:master Sep 5, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Hub Generated] Review request for Microsoft.Devices to add version stable/2019-03-22 #6932

[Hub Generated] Review request for Microsoft.Devices to add version stable/2019-03-22 #6932

reshantchandra commented Aug 12, 2019 •

edited

Loading

openapi-sdkautomation bot commented Aug 12, 2019 •

edited

Loading

AutorestCI commented Aug 12, 2019 •

edited

Loading

azuresdkci commented Aug 12, 2019

AutorestCI commented Aug 12, 2019 •

edited

Loading

jlian commented Aug 12, 2019

reshantchandra commented Aug 20, 2019

jlian left a comment

yungezz commented Aug 28, 2019

mmyyrroonn left a comment

mmyyrroonn commented Sep 2, 2019

reshantchandra commented Sep 3, 2019

mmyyrroonn commented Sep 4, 2019

[Hub Generated] Review request for Microsoft.Devices to add version stable/2019-03-22 #6932

[Hub Generated] Review request for Microsoft.Devices to add version stable/2019-03-22 #6932

Conversation

reshantchandra commented Aug 12, 2019 • edited Loading

Contribution checklist:

openapi-sdkautomation bot commented Aug 12, 2019 • edited Loading

In Testing, Please Ignore

[Logs] (Generated from f05eef4, Iteration 19)

AutorestCI commented Aug 12, 2019 • edited Loading

Automation for azure-sdk-for-python

azuresdkci commented Aug 12, 2019

AutorestCI commented Aug 12, 2019 • edited Loading

Automation for azure-sdk-for-go

jlian commented Aug 12, 2019

reshantchandra commented Aug 20, 2019

jlian left a comment

Choose a reason for hiding this comment

yungezz commented Aug 28, 2019

mmyyrroonn left a comment

Choose a reason for hiding this comment

mmyyrroonn commented Sep 2, 2019

reshantchandra commented Sep 3, 2019

mmyyrroonn commented Sep 4, 2019

reshantchandra commented Aug 12, 2019 •

edited

Loading

openapi-sdkautomation bot commented Aug 12, 2019 •

edited

Loading

AutorestCI commented Aug 12, 2019 •

edited

Loading

AutorestCI commented Aug 12, 2019 •

edited

Loading