Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ARM resources specs for 2019-08-01 #6948

Merged
merged 5 commits into from
Aug 28, 2019

Conversation

anthony-c-martin
Copy link
Member

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Aug 14, 2019

In Testing, Please Ignore

[Logs] (Generated from 70472db, Iteration 5)

Warning .NET: test-repo-billy/azure-sdk-for-net [Logs] [Diff]
  • No packages generated.
Failed Python: test-repo-billy/azure-sdk-for-python [Logs]
  • No packages generated.
Failed Java: test-repo-billy/azure-sdk-for-java [Logs]
  • No packages generated.
In-Progress Go: test-repo-billy/azure-sdk-for-go [Logs] [Diff]
  • Warning preview/resources/mgmt/2015-10-01-preview [Logs]
  • Warning preview/resources/mgmt/2016-09-01-preview [Logs]
  • Warning preview/resources/mgmt/2017-06-01-preview [Logs]
  • Warning resources/mgmt/2015-01-01 [Logs]
  • Warning resources/mgmt/2015-11-01 [Logs]
  • Warning resources/mgmt/2015-12-01 [Logs]
  • Warning resources/mgmt/2016-02-01 [Logs]
  • Warning resources/mgmt/2016-04-01 [Logs]
  • Warning resources/mgmt/2016-06-01 [Logs]
  • Warning resources/mgmt/2016-07-01 [Logs]
  • Warning resources/mgmt/2016-09-01 [Logs]
  • Warning resources/mgmt/2016-12-01 [Logs]
  • Warning resources/mgmt/2017-05-10 [Logs]
  • Warning resources/mgmt/2017-09-01 [Logs]
  • Warning resources/mgmt/2018-02-01 [Logs]
  • In-Progress resources/mgmt/2018-03-01 [Logs]
  • In-Progress resources/mgmt/2018-05-01 [Logs]
  • In-Progress resources/mgmt/2018-06-01 [Logs]
  • In-Progress resources/mgmt/2019-01-01 [Logs]
  • In-Progress resources/mgmt/2019-03-01 [Logs]
  • In-Progress resources/mgmt/2019-05-01 [Logs]
Failed JavaScript: test-repo-billy/azure-sdk-for-js [Logs] [Diff]

@AutorestCI
Copy link

AutorestCI commented Aug 14, 2019

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#6834

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@mmyyrroonn mmyyrroonn added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Aug 14, 2019
@mmyyrroonn
Copy link
Contributor

@anthony-c-martin Hello. Could you please resolve the CI errors?

@AutorestCI
Copy link

AutorestCI commented Aug 14, 2019

Automation for azure-sdk-for-go

Nothing to generate for azure-sdk-for-go

Copy link
Contributor

@ryansbenson ryansbenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved from ARMs side

@ryansbenson ryansbenson added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Aug 14, 2019
@anthony-c-martin
Copy link
Member Author

@myronfanqiu ping?

@mmyyrroonn
Copy link
Contributor

@anthony-c-martin Hello. What's the current status? Should I invite Java SDK owner to check this CI error? Or we are waiting for other PR merged first?

@anthony-c-martin
Copy link
Member Author

@anthony-c-martin Hello. What's the current status? Should I invite Java SDK owner to check this CI error? Or we are waiting for other PR merged first?

@myronfanqiu Yes please invite the Java SDK owner to take a look - I'm not able to see what's going on from the logs.

@mmyyrroonn
Copy link
Contributor

@yaohaizh Hello. Could you please check the Java CI errors? Looks like an error related with Autorest Java Extention.

@mmyyrroonn
Copy link
Contributor

@anthony-c-martin Meanwhile, please solve the CI errors of the lintdiff

@yaohaizh
Copy link
Contributor

Working on the Java SDK issue.

@mmyyrroonn
Copy link
Contributor

@anthony-c-martin Hello. Please solve the CI errors based on the error log and the suggestions.

@anthony-c-martin
Copy link
Member Author

@myronfanqiu mind merging if you're happy with the changes?

@mmyyrroonn mmyyrroonn merged commit 7a1256b into Azure:master Aug 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants