[DataFactory] Add Chaining Trigger #7001

haricr · 2019-08-20T06:26:25Z

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.
The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

openapi-sdkautomation · 2019-08-20T06:26:29Z

In Testing, Please Ignore

[Logs] (Generated from 5e1bb35, Iteration 5)

.NET: test-repo-billy/azure-sdk-for-net [Logs] [Diff]

Microsoft.Azure.Management.DataFactory [Logs] [Instructions]
- Microsoft.Azure.Management.DataFactory.4.1.2.nupkg
- Microsoft.Azure.Management.DataFactory.4.1.2.snupkg

Python: test-repo-billy/azure-sdk-for-python [Logs] [Diff]

azure-mgmt-datafactory [Logs] [Instructions] [Generation PR]
- azure-mgmt-datafactory-0.7.0.zip
- azure_mgmt_datafactory-0.7.0-py2.py3-none-any.whl

Java: test-repo-billy/azure-sdk-for-java [Logs] [Diff]

datafactory/resource-manager/v2017_09_01_preview [Logs] [Generation PR]
datafactory/resource-manager/v2018_06_01 [Logs]

Go: test-repo-billy/azure-sdk-for-go [Logs] [Diff]

datafactory/mgmt/2018-06-01 [Logs]
preview/datafactory/mgmt/2017-09-01-preview [Logs]

JavaScript: test-repo-billy/azure-sdk-for-js [Logs]

Package generation in progress.

azuresdkci · 2019-08-20T06:28:48Z

Can one of the admins verify this patch?

AutorestCI · 2019-08-20T06:29:18Z

Automation for azure-sdk-for-python

Encountered an unknown error: (azure-sdk-for-python)

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 33, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 170, in rest_handle_action
    return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 185, in rest_pull_close
    rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
    sdk_tag=sdk_tag
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 254, in generate_sdk_from_git_object
    with manage_git_folder(gh_token, Path(temp_dir) / Path("rest"), branched_rest_api_id, pr_number=pr_number) as restapi_git_folder, \
  File "/usr/lib/python3.6/contextlib.py", line 81, in __enter__
    return next(self.gen)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 272, in manage_git_folder
    clone_to_path(gh_token, temp_dir, split_git_id[0], branch_or_commit=branch, pr_number=pr_number)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 212, in clone_to_path
    repo.git.checkout(branch_or_commit)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 548, in <lambda>
    return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 1014, in _call_process
    return self.execute(call, **exec_kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 825, in execute
    raise GitCommandError(command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(128)
  cmdline: git checkout 62c926fa861c2b17887e842010a602f16c8ce497
  stderr: 'fatal: reference is not a tree: 62c926fa861c2b17887e842010a602f16c8ce497'

AutorestCI · 2019-08-20T06:33:19Z

Automation for azure-sdk-for-go

Encountered an unknown error: (azure-sdk-for-go)

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 33, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 170, in rest_handle_action
    return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 185, in rest_pull_close
    rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
    sdk_tag=sdk_tag
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 254, in generate_sdk_from_git_object
    with manage_git_folder(gh_token, Path(temp_dir) / Path("rest"), branched_rest_api_id, pr_number=pr_number) as restapi_git_folder, \
  File "/usr/lib/python3.6/contextlib.py", line 81, in __enter__
    return next(self.gen)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 272, in manage_git_folder
    clone_to_path(gh_token, temp_dir, split_git_id[0], branch_or_commit=branch, pr_number=pr_number)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 212, in clone_to_path
    repo.git.checkout(branch_or_commit)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 548, in <lambda>
    return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 1014, in _call_process
    return self.execute(call, **exec_kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 825, in execute
    raise GitCommandError(command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(128)
  cmdline: git checkout 62c926fa861c2b17887e842010a602f16c8ce497
  stderr: 'fatal: reference is not a tree: 62c926fa861c2b17887e842010a602f16c8ce497'

tjprescott · 2019-08-29T16:39:13Z

...cation/datafactory/resource-manager/Microsoft.DataFactory/stable/2018-06-01/datafactory.json

@@ -4335,8 +4335,8 @@
          },
          "readOnly": true
        },
-        "runDimension": {
-          "description": "Run dimension emitted by Pipeline run.",
+        "runDimensions": {


I believe this will result in a breaking change.

Hari Ramani added 2 commits August 14, 2019 11:01

Add Chaining Trigger

7711841

Add Chaining Trigger

7762acc

azuresdkci assigned tjprescott Aug 20, 2019

azuresdkci requested a review from tjprescott August 20, 2019 06:27

AutorestCI mentioned this pull request Aug 20, 2019

[AutoPR datafactory/resource-manager] [DataFactory] Add Chaining Trigger Azure/azure-sdk-for-python#6863

Closed

AutorestCI mentioned this pull request Aug 20, 2019

[AutoPR datafactory/resource-manager] [DataFactory] Add Chaining Trigger Azure/azure-sdk-for-go#5567

Closed

tjprescott added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Aug 20, 2019

Fix Issues

c1c2169

openapi-sdkautomation bot mentioned this pull request Aug 20, 2019

[AutoPR Microsoft.Azure.Management.DataFactory] [DataFactory] Add Chaining Trigger test-repo-billy/azure-sdk-for-net#111

Closed

Update review comments

5e1bb35

openapi-sdkautomation bot mentioned this pull request Aug 29, 2019

[AutoPR datafactory/resource-manager/v2017_09_01_preview] [DataFactory] Add Chaining Trigger test-repo-billy/azure-sdk-for-java#296

Closed

tjprescott requested changes Aug 29, 2019

View reviewed changes

haricr closed this Aug 29, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[DataFactory] Add Chaining Trigger #7001

[DataFactory] Add Chaining Trigger #7001

haricr commented Aug 20, 2019 •

edited

Loading

openapi-sdkautomation bot commented Aug 20, 2019 •

edited

Loading

azuresdkci commented Aug 20, 2019

AutorestCI commented Aug 20, 2019 •

edited

Loading

AutorestCI commented Aug 20, 2019 •

edited

Loading

tjprescott Aug 29, 2019

[DataFactory] Add Chaining Trigger #7001

[DataFactory] Add Chaining Trigger #7001

Conversation

haricr commented Aug 20, 2019 • edited Loading

Latest improvements:

Contribution checklist:

ARM API Review Checklist

openapi-sdkautomation bot commented Aug 20, 2019 • edited Loading

In Testing, Please Ignore

[Logs] (Generated from 5e1bb35, Iteration 5)

azuresdkci commented Aug 20, 2019

AutorestCI commented Aug 20, 2019 • edited Loading

Automation for azure-sdk-for-python

AutorestCI commented Aug 20, 2019 • edited Loading

Automation for azure-sdk-for-go

tjprescott Aug 29, 2019

Choose a reason for hiding this comment

haricr commented Aug 20, 2019 •

edited

Loading

openapi-sdkautomation bot commented Aug 20, 2019 •

edited

Loading

AutorestCI commented Aug 20, 2019 •

edited

Loading

AutorestCI commented Aug 20, 2019 •

edited

Loading