Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Container Services: add java package 2019 08 01 #7105

Merged
merged 2 commits into from
Sep 4, 2019
Merged

Container Services: add java package 2019 08 01 #7105

merged 2 commits into from
Sep 4, 2019

Conversation

ChenTanyi
Copy link
Contributor

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@ChenTanyi ChenTanyi requested a review from mboersma as a code owner September 3, 2019 07:30
@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Sep 3, 2019 •
edited
Loading

In Testing, Please Ignore

[Logs] (Generated from 65a6469, Iteration 2)

Warning Python: test-repo-billy/azure-sdk-for-python [Logs] [Diff]
  • No packages generated.
Failed Java: test-repo-billy/azure-sdk-for-java [Logs] [Diff]
Failed Go: test-repo-billy/azure-sdk-for-go [Logs] [Diff]
Warning JavaScript: test-repo-billy/azure-sdk-for-js [Logs] [Diff]
  • Warning @azure/arm-containerservice [Logs]
Failed .NET: test-repo-billy/azure-sdk-for-net [Logs] [Diff]
Succeeded Ruby: test-repo-billy/azure-sdk-for-ruby [Logs] [Diff]

@AutorestCI
Copy link

AutorestCI commented Sep 3, 2019 •
edited
Loading

Automation for azure-sdk-for-python

Nothing to generate for azure-sdk-for-python

@AutorestCI
Copy link

AutorestCI commented Sep 3, 2019 •
edited
Loading

Automation for azure-sdk-for-go

Nothing to generate for azure-sdk-for-go

@azuresdkci azuresdkci requested a review from anuchandy September 3, 2019 07:32
@ChenTanyi
Copy link
Contributor Author

@yaohaizh

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

This was referenced Sep 3, 2019
Merged
Merged
yaohaizh
yaohaizh reviewed Sep 3, 2019
View reviewed changes
specification/containerservice/resource-manager/readme.java.md
@@ -16,7 +16,20 @@ description: "Container Service Client"

``` yaml $(java) && $(multiapi)
batch:
- tag: package-2019-06
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should keep the original one.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it need to generate all these two package? I think this tag is just used for generate sdk and don't need to generate the old one again.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@yaohaizh yaohaizh assigned yaohaizh and unassigned anuchandy Sep 3, 2019
@yaohaizh yaohaizh merged commit d547b77 into Azure:master Sep 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yaohaizh yaohaizh yaohaizh approved these changes

@mboersma mboersma Awaiting requested review from mboersma

@anuchandy anuchandy Awaiting requested review from anuchandy

Assignees

@yaohaizh yaohaizh

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ChenTanyi @AutorestCI @azuresdkci @yaohaizh @anuchandy